| Message ID | 20240225235628.12473-1-neilb@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Supprt abstract addresses and disable broadcast | expand |
Hey Neil, My apologies on addressing this... Too much PTO :-) On 2/25/24 6:53 PM, NeilBrown wrote: > The first two patches here I wrote some years ago but never posted - sorry. > The third and fourth allow rpcbind to work with an abstract AF_UNIX > address as preferentially used by recent kernels. > > NeilBrown > > > [PATCH 1/4] manpage: describe use of extra port for broadcast rpc > [PATCH 2/4] rpcbind: allow broadcast RPC to be disabled. You realize that the broadcast code is configured out by default ./configure --help | grep rmt --enable-rmtcalls Enables Remote Calls [default=no] So do we want to introduce a flag and man page section for something that is off by default? steved. > [PATCH 3/4] Listen on an AF_UNIX abstract address if supported. > [PATCH 4/4] rpcinfo: try connecting using abstract address. >
Hi Neil, Steve, > Hey Neil, > My apologies on addressing this... > Too much PTO :-) > On 2/25/24 6:53 PM, NeilBrown wrote: > > The first two patches here I wrote some years ago but never posted - sorry. > > The third and fourth allow rpcbind to work with an abstract AF_UNIX > > address as preferentially used by recent kernels. > > NeilBrown > > [PATCH 1/4] manpage: describe use of extra port for broadcast rpc > > [PATCH 2/4] rpcbind: allow broadcast RPC to be disabled. > You realize that the broadcast code is configured out by default > ./configure --help | grep rmt > --enable-rmtcalls Enables Remote Calls [default=no] > So do we want to introduce a flag and man page section > for something that is off by default? I would say man page does not harm. If I'm not mistaken, it's disabled in openSUSE and Debian/Ubuntu, maybe disabling flag is really not needed. Kind regards, Petr > steved. > > [PATCH 3/4] Listen on an AF_UNIX abstract address if supported. > > [PATCH 4/4] rpcinfo: try connecting using abstract address.
On 3/4/24 1:29 PM, Petr Vorel wrote: > Hi Neil, Steve, > >> Hey Neil, > >> My apologies on addressing this... >> Too much PTO :-) > >> On 2/25/24 6:53 PM, NeilBrown wrote: >>> The first two patches here I wrote some years ago but never posted - sorry. >>> The third and fourth allow rpcbind to work with an abstract AF_UNIX >>> address as preferentially used by recent kernels. > >>> NeilBrown > > >>> [PATCH 1/4] manpage: describe use of extra port for broadcast rpc >>> [PATCH 2/4] rpcbind: allow broadcast RPC to be disabled. >> You realize that the broadcast code is configured out by default >> ./configure --help | grep rmt >> --enable-rmtcalls Enables Remote Calls [default=no] > >> So do we want to introduce a flag and man page section >> for something that is off by default? > > I would say man page does not harm. > > If I'm not mistaken, it's disabled in openSUSE and Debian/Ubuntu, maybe > disabling flag is really not needed. As well as RHEL but not Fedora. steved. > > Kind regards, > Petr > >> steved. >>> [PATCH 3/4] Listen on an AF_UNIX abstract address if supported. >>> [PATCH 4/4] rpcinfo: try connecting using abstract address. > >
On Tue, 05 Mar 2024, Steve Dickson wrote: > Hey Neil, > > My apologies on addressing this... > Too much PTO :-) > > On 2/25/24 6:53 PM, NeilBrown wrote: > > The first two patches here I wrote some years ago but never posted - sorry. > > The third and fourth allow rpcbind to work with an abstract AF_UNIX > > address as preferentially used by recent kernels. > > > > NeilBrown > > > > > > [PATCH 1/4] manpage: describe use of extra port for broadcast rpc > > [PATCH 2/4] rpcbind: allow broadcast RPC to be disabled. > You realize that the broadcast code is configured out by default > ./configure --help | grep rmt > --enable-rmtcalls Enables Remote Calls [default=no] > > So do we want to introduce a flag and man page section > for something that is off by default? > Hmmm.... I guess I didn't know that when I wrote the patch - or forgot. I wrote the patch a few years ago and found it when I was doing the abstract address stuff and though I better submit it. I was wrong. Please just ignore those first two patches. Thanks, NeilBrown
On 3/10/24 9:47 PM, NeilBrown wrote: > On Tue, 05 Mar 2024, Steve Dickson wrote: >> Hey Neil, >> >> My apologies on addressing this... >> Too much PTO :-) >> >> On 2/25/24 6:53 PM, NeilBrown wrote: >>> The first two patches here I wrote some years ago but never posted - sorry. >>> The third and fourth allow rpcbind to work with an abstract AF_UNIX >>> address as preferentially used by recent kernels. >>> >>> NeilBrown >>> >>> >>> [PATCH 1/4] manpage: describe use of extra port for broadcast rpc >>> [PATCH 2/4] rpcbind: allow broadcast RPC to be disabled. >> You realize that the broadcast code is configured out by default >> ./configure --help | grep rmt >> --enable-rmtcalls Enables Remote Calls [default=no] >> >> So do we want to introduce a flag and man page section >> for something that is off by default? >> > > Hmmm.... I guess I didn't know that when I wrote the patch - or forgot. > > I wrote the patch a few years ago and found it when I was doing the > abstract address stuff and though I better submit it. I was wrong. > > Please just ignore those first two patches. Ignored... the last two patches were committed (tag: rpcbind-1_2_7-rc3) steved. > > Thanks, > NeilBrown >