| Message ID | 20240227102914.8341-1-tiwai@suse.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | aa1767a3fcd75231e11822b0f95f017fc521691c |
| Headers | show |
| Series | Bluetooth: btmtk: Add MODULE_FIRMWARE() for MT7922 | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | fail | TestRunner_l2cap-tester: Total: 51, Passed: 50 (98.0%), Failed: 1, Not Run: 0 |
| tedd_an/TestRunner_iso-tester | fail | TestRunner_iso-tester: Total: 117, Passed: 116 (99.1%), Failed: 1, Not Run: 0 |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
Dear Takashi, Thank you for the patch. Am 27.02.24 um 11:29 schrieb Takashi Iwai: > Since dracut refers to the module info for defining the required > firmware files and btmtk driver doesn't provide the firmware info for > MT7922, the generate initrd misses the firmware, resulting in the generate*d* > broken Bluetooth. > > This patch simply adds the MODULE_FIRMWARE() for the missing entry > for covering that. > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1214133 > Signed-off-by: Takashi Iwai <tiwai@suse.de> > --- > drivers/bluetooth/btmtk.c | 1 + > drivers/bluetooth/btmtk.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c > index aaabb732082c..e5138a207f37 100644 > --- a/drivers/bluetooth/btmtk.c > +++ b/drivers/bluetooth/btmtk.c > @@ -420,5 +420,6 @@ MODULE_LICENSE("GPL"); > MODULE_FIRMWARE(FIRMWARE_MT7622); > MODULE_FIRMWARE(FIRMWARE_MT7663); > MODULE_FIRMWARE(FIRMWARE_MT7668); > +MODULE_FIRMWARE(FIRMWARE_MT7922); > MODULE_FIRMWARE(FIRMWARE_MT7961); > MODULE_FIRMWARE(FIRMWARE_MT7925); > diff --git a/drivers/bluetooth/btmtk.h b/drivers/bluetooth/btmtk.h > index 56f5502baadf..cbcdb99a22e6 100644 > --- a/drivers/bluetooth/btmtk.h > +++ b/drivers/bluetooth/btmtk.h > @@ -4,6 +4,7 @@ > #define FIRMWARE_MT7622 "mediatek/mt7622pr2h.bin" > #define FIRMWARE_MT7663 "mediatek/mt7663pr2h.bin" > #define FIRMWARE_MT7668 "mediatek/mt7668pr2h.bin" > +#define FIRMWARE_MT7922 "mediatek/BT_RAM_CODE_MT7922_1_1_hdr.bin" > #define FIRMWARE_MT7961 "mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin" > #define FIRMWARE_MT7925 "mediatek/mt7925/BT_RAM_CODE_MT7925_1_1_hdr.bin" Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Kind regards, Paul
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=830220 ---Test result--- Test Summary: CheckPatch PASS 0.63 seconds GitLint PASS 0.18 seconds SubjectPrefix PASS 0.28 seconds BuildKernel PASS 27.40 seconds CheckAllWarning PASS 30.15 seconds CheckSparse PASS 36.05 seconds CheckSmatch PASS 97.54 seconds BuildKernel32 PASS 26.81 seconds TestRunnerSetup PASS 506.45 seconds TestRunner_l2cap-tester FAIL 22.37 seconds TestRunner_iso-tester FAIL 38.89 seconds TestRunner_bnep-tester PASS 4.69 seconds TestRunner_mgmt-tester PASS 113.32 seconds TestRunner_rfcomm-tester PASS 7.29 seconds TestRunner_sco-tester PASS 13.00 seconds TestRunner_ioctl-tester PASS 8.43 seconds TestRunner_mesh-tester PASS 5.90 seconds TestRunner_smp-tester PASS 6.75 seconds TestRunner_userchan-tester PASS 4.95 seconds IncrementalBuild PASS 25.78 seconds Details ############################## Test: TestRunner_l2cap-tester - FAIL Desc: Run l2cap-tester with test-runner Output: Total: 51, Passed: 50 (98.0%), Failed: 1, Not Run: 0 Failed Test Cases L2CAP LE Client - Close socket 2 Timed out 2.167 seconds ############################## Test: TestRunner_iso-tester - FAIL Desc: Run iso-tester with test-runner Output: Total: 117, Passed: 116 (99.1%), Failed: 1, Not Run: 0 Failed Test Cases ISO Connect2 Suspend - Success Timed out 12.292 seconds --- Regards, Linux Bluetooth
On 27/02/2024 11:29, Takashi Iwai wrote: > Since dracut refers to the module info for defining the required > firmware files and btmtk driver doesn't provide the firmware info for > MT7922, the generate initrd misses the firmware, resulting in the > broken Bluetooth. > > This patch simply adds the MODULE_FIRMWARE() for the missing entry > for covering that. > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1214133 > Signed-off-by: Takashi Iwai <tiwai@suse.de> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/bluetooth/btmtk.c | 1 + > drivers/bluetooth/btmtk.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c > index aaabb732082c..e5138a207f37 100644 > --- a/drivers/bluetooth/btmtk.c > +++ b/drivers/bluetooth/btmtk.c > @@ -420,5 +420,6 @@ MODULE_LICENSE("GPL"); > MODULE_FIRMWARE(FIRMWARE_MT7622); > MODULE_FIRMWARE(FIRMWARE_MT7663); > MODULE_FIRMWARE(FIRMWARE_MT7668); > +MODULE_FIRMWARE(FIRMWARE_MT7922); > MODULE_FIRMWARE(FIRMWARE_MT7961); > MODULE_FIRMWARE(FIRMWARE_MT7925); > diff --git a/drivers/bluetooth/btmtk.h b/drivers/bluetooth/btmtk.h > index 56f5502baadf..cbcdb99a22e6 100644 > --- a/drivers/bluetooth/btmtk.h > +++ b/drivers/bluetooth/btmtk.h > @@ -4,6 +4,7 @@ > #define FIRMWARE_MT7622 "mediatek/mt7622pr2h.bin" > #define FIRMWARE_MT7663 "mediatek/mt7663pr2h.bin" > #define FIRMWARE_MT7668 "mediatek/mt7668pr2h.bin" > +#define FIRMWARE_MT7922 "mediatek/BT_RAM_CODE_MT7922_1_1_hdr.bin" > #define FIRMWARE_MT7961 "mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin" > #define FIRMWARE_MT7925 "mediatek/mt7925/BT_RAM_CODE_MT7925_1_1_hdr.bin" >
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 27 Feb 2024 11:29:14 +0100 you wrote: > Since dracut refers to the module info for defining the required > firmware files and btmtk driver doesn't provide the firmware info for > MT7922, the generate initrd misses the firmware, resulting in the > broken Bluetooth. > > This patch simply adds the MODULE_FIRMWARE() for the missing entry > for covering that. > > [...] Here is the summary with links: - Bluetooth: btmtk: Add MODULE_FIRMWARE() for MT7922 https://git.kernel.org/bluetooth/bluetooth-next/c/aa1767a3fcd7 You are awesome, thank you!
diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c index aaabb732082c..e5138a207f37 100644 --- a/drivers/bluetooth/btmtk.c +++ b/drivers/bluetooth/btmtk.c @@ -420,5 +420,6 @@ MODULE_LICENSE("GPL"); MODULE_FIRMWARE(FIRMWARE_MT7622); MODULE_FIRMWARE(FIRMWARE_MT7663); MODULE_FIRMWARE(FIRMWARE_MT7668); +MODULE_FIRMWARE(FIRMWARE_MT7922); MODULE_FIRMWARE(FIRMWARE_MT7961); MODULE_FIRMWARE(FIRMWARE_MT7925); diff --git a/drivers/bluetooth/btmtk.h b/drivers/bluetooth/btmtk.h index 56f5502baadf..cbcdb99a22e6 100644 --- a/drivers/bluetooth/btmtk.h +++ b/drivers/bluetooth/btmtk.h @@ -4,6 +4,7 @@ #define FIRMWARE_MT7622 "mediatek/mt7622pr2h.bin" #define FIRMWARE_MT7663 "mediatek/mt7663pr2h.bin" #define FIRMWARE_MT7668 "mediatek/mt7668pr2h.bin" +#define FIRMWARE_MT7922 "mediatek/BT_RAM_CODE_MT7922_1_1_hdr.bin" #define FIRMWARE_MT7961 "mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin" #define FIRMWARE_MT7925 "mediatek/mt7925/BT_RAM_CODE_MT7925_1_1_hdr.bin"
Since dracut refers to the module info for defining the required firmware files and btmtk driver doesn't provide the firmware info for MT7922, the generate initrd misses the firmware, resulting in the broken Bluetooth. This patch simply adds the MODULE_FIRMWARE() for the missing entry for covering that. Link: https://bugzilla.suse.com/show_bug.cgi?id=1214133 Signed-off-by: Takashi Iwai <tiwai@suse.de> --- drivers/bluetooth/btmtk.c | 1 + drivers/bluetooth/btmtk.h | 1 + 2 files changed, 2 insertions(+)