| Message ID | 20231215110639.45522-5-david@sigma-star.at (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | DCP as trusted keys backend | expand |
On Fri Dec 15, 2023 at 1:06 PM EET, David Gstir wrote: > This covers trusted keys backed by NXP's DCP (Data Co-Processor) chip > found in smaller i.MX SoCs. > > Signed-off-by: David Gstir <david@sigma-star.at> > --- > MAINTAINERS | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 90f13281d297..988d01226131 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11647,6 +11647,15 @@ S: Maintained > F: include/keys/trusted_caam.h > F: security/keys/trusted-keys/trusted_caam.c > > +KEYS-TRUSTED-DCP > +M: David Gstir <david@sigma-star.at> > +R: sigma star Kernel Team <upstream+dcp@sigma-star.at> > +L: linux-integrity@vger.kernel.org > +L: keyrings@vger.kernel.org > +S: Supported > +F: include/keys/trusted_dcp.h > +F: security/keys/trusted-keys/trusted_dcp.c > + > KEYS-TRUSTED-TEE > M: Sumit Garg <sumit.garg@linaro.org> > L: linux-integrity@vger.kernel.org Acked-by: Jarkko Sakkinen <jarkko@kernel.org> I can for sure put this. The code quality is *not* bad :-) However, your backing story really needs rework. It is otherwise impossible to understand the code changes later on because amount of information is vast, and you tend to forget details of stuff that you are not actively working on. That is why we care so deeply about them. BR, Jarkko
Jarkko, > On 04.03.2024, at 23:48, Jarkko Sakkinen <jarkko@kernel.org> wrote: > > On Fri Dec 15, 2023 at 1:06 PM EET, David Gstir wrote: >> This covers trusted keys backed by NXP's DCP (Data Co-Processor) chip >> found in smaller i.MX SoCs. >> >> Signed-off-by: David Gstir <david@sigma-star.at> >> --- >> MAINTAINERS | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 90f13281d297..988d01226131 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -11647,6 +11647,15 @@ S: Maintained >> F: include/keys/trusted_caam.h >> F: security/keys/trusted-keys/trusted_caam.c >> >> +KEYS-TRUSTED-DCP >> +M: David Gstir <david@sigma-star.at> >> +R: sigma star Kernel Team <upstream+dcp@sigma-star.at> >> +L: linux-integrity@vger.kernel.org >> +L: keyrings@vger.kernel.org >> +S: Supported >> +F: include/keys/trusted_dcp.h >> +F: security/keys/trusted-keys/trusted_dcp.c >> + >> KEYS-TRUSTED-TEE >> M: Sumit Garg <sumit.garg@linaro.org> >> L: linux-integrity@vger.kernel.org > > Acked-by: Jarkko Sakkinen <jarkko@kernel.org> > > I can for sure put this. The code quality is *not* bad :-) However, your > backing story really needs rework. It is otherwise impossible to > understand the code changes later on because amount of information is > vast, and you tend to forget details of stuff that you are not actively > working on. That is why we care so deeply about them. got it! :) I’ve tried to rework the commit messages as good as possible for v6 and will send that series momentarily. Thanks! - David
diff --git a/MAINTAINERS b/MAINTAINERS index 90f13281d297..988d01226131 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11647,6 +11647,15 @@ S: Maintained F: include/keys/trusted_caam.h F: security/keys/trusted-keys/trusted_caam.c +KEYS-TRUSTED-DCP +M: David Gstir <david@sigma-star.at> +R: sigma star Kernel Team <upstream+dcp@sigma-star.at> +L: linux-integrity@vger.kernel.org +L: keyrings@vger.kernel.org +S: Supported +F: include/keys/trusted_dcp.h +F: security/keys/trusted-keys/trusted_dcp.c + KEYS-TRUSTED-TEE M: Sumit Garg <sumit.garg@linaro.org> L: linux-integrity@vger.kernel.org
This covers trusted keys backed by NXP's DCP (Data Co-Processor) chip found in smaller i.MX SoCs. Signed-off-by: David Gstir <david@sigma-star.at> --- MAINTAINERS | 9 +++++++++ 1 file changed, 9 insertions(+)