| Message ID | 20240304-backlight-probe-v1-1-e5f57d0df6e6@linaro.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | backlight: Simplify probe in few drivers | expand |
On Mon, Mar 04, 2024 at 11:11:38AM +0100, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/video/backlight/gpio_backlight.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c > index d28c30b2a35d..9f960f853b6e 100644 > --- a/drivers/video/backlight/gpio_backlight.c > +++ b/drivers/video/backlight/gpio_backlight.c > @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev) > def_value = device_property_read_bool(dev, "default-on"); > > gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS); > - if (IS_ERR(gbl->gpiod)) { > - ret = PTR_ERR(gbl->gpiod); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, > - "Error: The gpios parameter is missing or invalid.\n"); > - return ret; > - } > + if (IS_ERR(gbl->gpiod)) > + return dev_err_probe(dev, PTR_ERR(gbl->gpiod), > + "Error: The gpios parameter is missing or invalid.\n"); The "Error: " should be removed from the string. dev_err_probe() already prints that. Daniel.
On 04/03/2024 11:40, Daniel Thompson wrote: > On Mon, Mar 04, 2024 at 11:11:38AM +0100, Krzysztof Kozlowski wrote: >> Common pattern of handling deferred probe can be simplified with >> dev_err_probe(). Less code and also it prints the error value. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> drivers/video/backlight/gpio_backlight.c | 10 +++------- >> 1 file changed, 3 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c >> index d28c30b2a35d..9f960f853b6e 100644 >> --- a/drivers/video/backlight/gpio_backlight.c >> +++ b/drivers/video/backlight/gpio_backlight.c >> @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev) >> def_value = device_property_read_bool(dev, "default-on"); >> >> gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS); >> - if (IS_ERR(gbl->gpiod)) { >> - ret = PTR_ERR(gbl->gpiod); >> - if (ret != -EPROBE_DEFER) >> - dev_err(dev, >> - "Error: The gpios parameter is missing or invalid.\n"); >> - return ret; >> - } >> + if (IS_ERR(gbl->gpiod)) >> + return dev_err_probe(dev, PTR_ERR(gbl->gpiod), >> + "Error: The gpios parameter is missing or invalid.\n"); > > The "Error: " should be removed from the string. dev_err_probe() already prints > that. Sure. Best regards, Krzysztof
diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c index d28c30b2a35d..9f960f853b6e 100644 --- a/drivers/video/backlight/gpio_backlight.c +++ b/drivers/video/backlight/gpio_backlight.c @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev) def_value = device_property_read_bool(dev, "default-on"); gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS); - if (IS_ERR(gbl->gpiod)) { - ret = PTR_ERR(gbl->gpiod); - if (ret != -EPROBE_DEFER) - dev_err(dev, - "Error: The gpios parameter is missing or invalid.\n"); - return ret; - } + if (IS_ERR(gbl->gpiod)) + return dev_err_probe(dev, PTR_ERR(gbl->gpiod), + "Error: The gpios parameter is missing or invalid.\n"); memset(&props, 0, sizeof(props)); props.type = BACKLIGHT_RAW;
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/video/backlight/gpio_backlight.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)