| Message ID | 1709053709-33742-2-git-send-email-lizhi.hou@amd.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | AMD QDMA driver | expand |
On 2/27/24 18:08, Lizhi Hou wrote: > Add amd/ for AMD dmaengine drivers. Create empty Kconfig and Makefile > underneath. > > Signed-off-by: Lizhi Hou<lizhi.hou@amd.com> > --- > drivers/dma/Kconfig | 2 ++ > drivers/dma/Makefile | 1 + > drivers/dma/amd/Kconfig | 1 + > drivers/dma/amd/Makefile | 4 ++++ > 4 files changed, 8 insertions(+) > create mode 100644 drivers/dma/amd/Kconfig > create mode 100644 drivers/dma/amd/Makefile Hi Lizhi, I think you may want to change the order of the patches. Adding the Kconfig and Makefile changes in the first patch, and the code itself in the second patch will hurt git bisect. Just swap them around. -- Regards, Tadeusz
On 3/5/24 01:16, Tadeusz Struk wrote: > On 2/27/24 18:08, Lizhi Hou wrote: >> Add amd/ for AMD dmaengine drivers. Create empty Kconfig and Makefile >> underneath. >> >> Signed-off-by: Lizhi Hou<lizhi.hou@amd.com> >> --- >> drivers/dma/Kconfig | 2 ++ >> drivers/dma/Makefile | 1 + >> drivers/dma/amd/Kconfig | 1 + >> drivers/dma/amd/Makefile | 4 ++++ >> 4 files changed, 8 insertions(+) >> create mode 100644 drivers/dma/amd/Kconfig >> create mode 100644 drivers/dma/amd/Makefile > > Hi Lizhi, > I think you may want to change the order of the patches. > Adding the Kconfig and Makefile changes in the first patch, > and the code itself in the second patch will hurt git bisect. > Just swap them around. This patch was introduced for another AMD driver ae4dma patchset. It looks ae4dma plan has changed. I am going to merge this 2 patches into 1 patch. Thanks, Lizhi > -- > Regards, > Tadeusz
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index e928f2ca0f1e..62d09090b94d 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -748,6 +748,8 @@ config XILINX_ZYNQMP_DPDMA display driver. # driver files +source "drivers/dma/amd/Kconfig" + source "drivers/dma/bestcomm/Kconfig" source "drivers/dma/mediatek/Kconfig" diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile index dfd40d14e408..f2c614fcf2a4 100644 --- a/drivers/dma/Makefile +++ b/drivers/dma/Makefile @@ -84,6 +84,7 @@ obj-$(CONFIG_ST_FDMA) += st_fdma.o obj-$(CONFIG_FSL_DPAA2_QDMA) += fsl-dpaa2-qdma/ obj-$(CONFIG_INTEL_LDMA) += lgm/ +obj-y += amd/ obj-y += mediatek/ obj-y += qcom/ obj-y += ti/ diff --git a/drivers/dma/amd/Kconfig b/drivers/dma/amd/Kconfig new file mode 100644 index 000000000000..a4e40e534e6a --- /dev/null +++ b/drivers/dma/amd/Kconfig @@ -0,0 +1 @@ +# SPDX-License-Identifier: GPL-2.0-only diff --git a/drivers/dma/amd/Makefile b/drivers/dma/amd/Makefile new file mode 100644 index 000000000000..47c9577b8cac --- /dev/null +++ b/drivers/dma/amd/Makefile @@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Copyright (C) 2023, Advanced Micro Devices, Inc. +#
Add amd/ for AMD dmaengine drivers. Create empty Kconfig and Makefile underneath. Signed-off-by: Lizhi Hou <lizhi.hou@amd.com> --- drivers/dma/Kconfig | 2 ++ drivers/dma/Makefile | 1 + drivers/dma/amd/Kconfig | 1 + drivers/dma/amd/Makefile | 4 ++++ 4 files changed, 8 insertions(+) create mode 100644 drivers/dma/amd/Kconfig create mode 100644 drivers/dma/amd/Makefile