| Message ID | 3aca1707-9eab-4b85-a4ae-e56508b15843@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | 9pfsd: allow building with old glibc | expand |
On 05.03.24 15:33, Jan Beulich wrote: > Neither pread() / pwrite() nor O_DIRECTORY are available from glibc > 2.11.3 headers without defining (e.g.) _GNU_SOURCE. Supplying the > definition unconditionally shouldn't be a problem, seeing that various > other tools/ components do so, too. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> Fine with me. Reviewed-by: Juergen Gross <jgross@suse.com> Juergen
On Tue, Mar 05, 2024 at 04:23:23PM +0100, Jürgen Groß wrote: > On 05.03.24 15:33, Jan Beulich wrote: > > Neither pread() / pwrite() nor O_DIRECTORY are available from glibc > > 2.11.3 headers without defining (e.g.) _GNU_SOURCE. Supplying the > > definition unconditionally shouldn't be a problem, seeing that various > > other tools/ components do so, too. > > > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > > Fine with me. > > Reviewed-by: Juergen Gross <jgross@suse.com> Acked-by: Anthony PERARD <anthony.perard@citrix.com> Thanks,
--- a/tools/9pfsd/Makefile +++ b/tools/9pfsd/Makefile @@ -5,7 +5,7 @@ XEN_ROOT = $(CURDIR)/../.. include $(XEN_ROOT)/tools/Rules.mk -CFLAGS += $(PTHREAD_CFLAGS) +CFLAGS += $(PTHREAD_CFLAGS) -D_GNU_SOURCE LDFLAGS += $(PTHREAD_LDFLAGS) TARGETS := xen-9pfsd
Neither pread() / pwrite() nor O_DIRECTORY are available from glibc 2.11.3 headers without defining (e.g.) _GNU_SOURCE. Supplying the definition unconditionally shouldn't be a problem, seeing that various other tools/ components do so, too. Signed-off-by: Jan Beulich <jbeulich@suse.com>