| Message ID | 20240306063721.1.I4a32475190334e1fa4eef4700ecd2787a43c94b5@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "drm/udl: Add ARGB8888 as a format" | expand |
Am 06.03.24 um 15:37 schrieb Douglas Anderson: > This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. > > Apparently there was a previous discussion about emulation of formats > and it was decided XRGB8888 was the only format to support for legacy > userspace [1]. Remove ARGB8888. Userspace needs to be fixed to accept > XRGB8888. > > [1] https://lore.kernel.org/r/60dc7697-d7a0-4bf4-a22e-32f1bbb792c2@suse.de > > Signed-off-by: Douglas Anderson <dianders@chromium.org> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > > drivers/gpu/drm/udl/udl_modeset.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c > index 0f8d3678770e..7702359c90c2 100644 > --- a/drivers/gpu/drm/udl/udl_modeset.c > +++ b/drivers/gpu/drm/udl/udl_modeset.c > @@ -253,7 +253,6 @@ static int udl_handle_damage(struct drm_framebuffer *fb, > static const uint32_t udl_primary_plane_formats[] = { > DRM_FORMAT_RGB565, > DRM_FORMAT_XRGB8888, > - DRM_FORMAT_ARGB8888, > }; > > static const uint64_t udl_primary_plane_fmtmods[] = {
Douglas Anderson <dianders@chromium.org> writes: Hello Doug, > This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. > > Apparently there was a previous discussion about emulation of formats > and it was decided XRGB8888 was the only format to support for legacy > userspace [1]. Remove ARGB8888. Userspace needs to be fixed to accept > XRGB8888. > > [1] https://lore.kernel.org/r/60dc7697-d7a0-4bf4-a22e-32f1bbb792c2@suse.de > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hi, On Wed, Mar 6, 2024 at 6:38 AM Douglas Anderson <dianders@chromium.org> wrote: > > This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. > > Apparently there was a previous discussion about emulation of formats > and it was decided XRGB8888 was the only format to support for legacy > userspace [1]. Remove ARGB8888. Userspace needs to be fixed to accept > XRGB8888. > > [1] https://lore.kernel.org/r/60dc7697-d7a0-4bf4-a22e-32f1bbb792c2@suse.de > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > drivers/gpu/drm/udl/udl_modeset.c | 1 - > 1 file changed, 1 deletion(-) Pushed to drm-misc-fixes with Thomas and Javier's tags: 317f86dc1b8e Revert "drm/udl: Add ARGB8888 as a format"
diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c index 0f8d3678770e..7702359c90c2 100644 --- a/drivers/gpu/drm/udl/udl_modeset.c +++ b/drivers/gpu/drm/udl/udl_modeset.c @@ -253,7 +253,6 @@ static int udl_handle_damage(struct drm_framebuffer *fb, static const uint32_t udl_primary_plane_formats[] = { DRM_FORMAT_RGB565, DRM_FORMAT_XRGB8888, - DRM_FORMAT_ARGB8888, }; static const uint64_t udl_primary_plane_fmtmods[] = {
This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. Apparently there was a previous discussion about emulation of formats and it was decided XRGB8888 was the only format to support for legacy userspace [1]. Remove ARGB8888. Userspace needs to be fixed to accept XRGB8888. [1] https://lore.kernel.org/r/60dc7697-d7a0-4bf4-a22e-32f1bbb792c2@suse.de Signed-off-by: Douglas Anderson <dianders@chromium.org> --- drivers/gpu/drm/udl/udl_modeset.c | 1 - 1 file changed, 1 deletion(-)