| Message ID | 20240302-opp_support-v8-2-158285b86b10@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | PCI: qcom: Add support for OPP | expand |
On 3/2/24 04:59, Krishna chaitanya chundru wrote: > Add pcie-mem & cpu-pcie interconnect path to the PCIe nodes. > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index 01e4dfc4babd..6b1d2e0d9d14 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -1781,6 +1781,10 @@ pcie0: pcie@1c00000 { > <0 0 0 3 &intc 0 0 0 151 IRQ_TYPE_LEVEL_HIGH>, /* int_c */ > <0 0 0 4 &intc 0 0 0 152 IRQ_TYPE_LEVEL_HIGH>; /* int_d */ > > + interconnects = <&pcie_noc MASTER_PCIE_0 0 &mc_virt SLAVE_EBI1 0>, Please use QCOM_ICC_TAG_ALWAYS. > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_0 0>; And this path could presumably be demoted to QCOM_ICC_TAG_ACTIVE_ONLY? Konrad
On Wed, Mar 06, 2024 at 05:04:54PM +0100, Konrad Dybcio wrote: > > > On 3/2/24 04:59, Krishna chaitanya chundru wrote: > > Add pcie-mem & cpu-pcie interconnect path to the PCIe nodes. > > > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > > --- > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > index 01e4dfc4babd..6b1d2e0d9d14 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > @@ -1781,6 +1781,10 @@ pcie0: pcie@1c00000 { > > <0 0 0 3 &intc 0 0 0 151 IRQ_TYPE_LEVEL_HIGH>, /* int_c */ > > <0 0 0 4 &intc 0 0 0 152 IRQ_TYPE_LEVEL_HIGH>; /* int_d */ > > + interconnects = <&pcie_noc MASTER_PCIE_0 0 &mc_virt SLAVE_EBI1 0>, > > Please use QCOM_ICC_TAG_ALWAYS. > > > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_0 0>; > > And this path could presumably be demoted to QCOM_ICC_TAG_ACTIVE_ONLY? > I think it should be fine since there would be no register access done while the RPMh is put into sleep state. Krishna, can you confirm that by executing the CX shutdown with QCOM_ICC_TAG_ACTIVE_ONLY vote for cpu-pcie path on any supported platform? But if we do such change, then it should also be applied to other SoCs. - Mani
On 4/5/2024 1:10 PM, Manivannan Sadhasivam wrote: > On Wed, Mar 06, 2024 at 05:04:54PM +0100, Konrad Dybcio wrote: >> >> >> On 3/2/24 04:59, Krishna chaitanya chundru wrote: >>> Add pcie-mem & cpu-pcie interconnect path to the PCIe nodes. >>> >>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> index 01e4dfc4babd..6b1d2e0d9d14 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> @@ -1781,6 +1781,10 @@ pcie0: pcie@1c00000 { >>> <0 0 0 3 &intc 0 0 0 151 IRQ_TYPE_LEVEL_HIGH>, /* int_c */ >>> <0 0 0 4 &intc 0 0 0 152 IRQ_TYPE_LEVEL_HIGH>; /* int_d */ >>> + interconnects = <&pcie_noc MASTER_PCIE_0 0 &mc_virt SLAVE_EBI1 0>, >> >> Please use QCOM_ICC_TAG_ALWAYS. >> >>> + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_0 0>; >> >> And this path could presumably be demoted to QCOM_ICC_TAG_ACTIVE_ONLY? >> > > I think it should be fine since there would be no register access done while the > RPMh is put into sleep state. Krishna, can you confirm that by executing the CX > shutdown with QCOM_ICC_TAG_ACTIVE_ONLY vote for cpu-pcie path on any supported > platform? > > But if we do such change, then it should also be applied to other SoCs. > > - Mani > we don't a have platform to test this now, we will keep QCOM_ICC_TAG_ALWAYS for now. - Krishna Chaitanya.
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 01e4dfc4babd..6b1d2e0d9d14 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -1781,6 +1781,10 @@ pcie0: pcie@1c00000 { <0 0 0 3 &intc 0 0 0 151 IRQ_TYPE_LEVEL_HIGH>, /* int_c */ <0 0 0 4 &intc 0 0 0 152 IRQ_TYPE_LEVEL_HIGH>; /* int_d */ + interconnects = <&pcie_noc MASTER_PCIE_0 0 &mc_virt SLAVE_EBI1 0>, + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_0 0>; + interconnect-names = "pcie-mem", "cpu-pcie"; + clocks = <&gcc GCC_PCIE_0_PIPE_CLK>, <&gcc GCC_PCIE_0_PIPE_CLK_SRC>, <&pcie0_phy>, @@ -1890,6 +1894,10 @@ pcie1: pcie@1c08000 { <0 0 0 3 &intc 0 0 0 438 IRQ_TYPE_LEVEL_HIGH>, /* int_c */ <0 0 0 4 &intc 0 0 0 439 IRQ_TYPE_LEVEL_HIGH>; /* int_d */ + interconnects = <&pcie_noc MASTER_PCIE_1 0 &mc_virt SLAVE_EBI1 0>, + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_1 0>; + interconnect-names = "pcie-mem", "cpu-pcie"; + clocks = <&gcc GCC_PCIE_1_PIPE_CLK>, <&gcc GCC_PCIE_1_PIPE_CLK_SRC>, <&pcie1_phy>,