| Message ID | 20240307-j7200-usb-suspend-v4-2-5ec7615431f3@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: cdns: fix suspend on J7200 by assuming reset-on-resume | expand |
On Thu, Mar 07, 2024 at 10:55:03AM +0100, Théo Lebrun wrote: > On J7200, the controller & its wrapper are reset on resume. It has the > same behavior as ti,j721e-usb with a different SoC integration. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- > Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > index 653a89586f4e..e8f7e7511483 100644 > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > @@ -16,6 +16,9 @@ properties: > - items: > - const: ti,am64-usb > - const: ti,j721e-usb > + - items: > + - const: ti,j7200-usb > + - const: ti,j721e-usb Combine this with the previous entry: items: - enum: - ti,am64-usb - ti,j7200-usb - const: ti,j721e-usb
Hello Rob, On Thu Mar 7, 2024 at 3:21 PM CET, Rob Herring wrote: > On Thu, Mar 07, 2024 at 10:55:03AM +0100, Théo Lebrun wrote: > > On J7200, the controller & its wrapper are reset on resume. It has the > > same behavior as ti,j721e-usb with a different SoC integration. > > > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > > --- > > Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > index 653a89586f4e..e8f7e7511483 100644 > > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > @@ -16,6 +16,9 @@ properties: > > - items: > > - const: ti,am64-usb > > - const: ti,j721e-usb > > + - items: > > + - const: ti,j7200-usb > > + - const: ti,j721e-usb > > Combine this with the previous entry: > > items: > - enum: > - ti,am64-usb > - ti,j7200-usb > - const: ti,j721e-usb Makes sense, will do. Full block will become: properties: compatible: oneOf: - const: ti,j721e-usb - items: - enum: - const: ti,am64-usb - const: ti,j7200-usb - const: ti,j721e-usb Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml index 653a89586f4e..e8f7e7511483 100644 --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml @@ -16,6 +16,9 @@ properties: - items: - const: ti,am64-usb - const: ti,j721e-usb + - items: + - const: ti,j7200-usb + - const: ti,j721e-usb reg: maxItems: 1
On J7200, the controller & its wrapper are reset on resume. It has the same behavior as ti,j721e-usb with a different SoC integration. Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> --- Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 3 +++ 1 file changed, 3 insertions(+)