mbox series

[net-next,v3,0/3] netdev: add per-queue statistics

Message ID 20240306195509.1502746-1-kuba@kernel.org (mailing list archive)
Headers show
Series netdev: add per-queue statistics | expand

Message

Jakub Kicinski March 6, 2024, 7:55 p.m. UTC
Hi!

Per queue stats keep coming up, so it's about time someone laid
the foundation. This series adds the uAPI, a handful of stats
and a sample support for bnxt. It's not very comprehensive in
terms of stat types or driver support. The expectation is that
the support will grow organically. If we have the basic pieces
in place it will be easy for reviewers to request new stats,
or use of the API in place of ethtool -S.

See patch 3 for sample output.

v3:
 - remove the dump error handling, core does it now (b5a899154aa94)
 - fix ring mapping w/ XDP in bnxt
v2: https://lore.kernel.org/all/20240229010221.2408413-1-kuba@kernel.org/
 - un-wrap short lines
 - s/stats/qstats/
v1: https://lore.kernel.org/all/20240226211015.1244807-1-kuba@kernel.org/
 - rename projection -> scope
 - turn projection/scope into flags
 - remove the "netdev" scope since it's always implied
rfc: https://lore.kernel.org/all/20240222223629.158254-1-kuba@kernel.org/

Jakub Kicinski (3):
  netdev: add per-queue statistics
  netdev: add queue stat for alloc failures
  eth: bnxt: support per-queue statistics

 Documentation/netlink/specs/netdev.yaml   |  91 +++++++++
 Documentation/networking/statistics.rst   |  15 ++
 drivers/net/ethernet/broadcom/bnxt/bnxt.c |  65 +++++++
 include/linux/netdevice.h                 |   3 +
 include/net/netdev_queues.h               |  56 ++++++
 include/uapi/linux/netdev.h               |  20 ++
 net/core/netdev-genl-gen.c                |  12 ++
 net/core/netdev-genl-gen.h                |   2 +
 net/core/netdev-genl.c                    | 214 ++++++++++++++++++++++
 tools/include/uapi/linux/netdev.h         |  20 ++
 10 files changed, 498 insertions(+)

Comments

Xuan Zhuo March 7, 2024, 3:57 a.m. UTC | #1
For series:

Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>

On Wed,  6 Mar 2024 11:55:06 -0800, Jakub Kicinski <kuba@kernel.org> wrote:
> Hi!
>
> Per queue stats keep coming up, so it's about time someone laid
> the foundation. This series adds the uAPI, a handful of stats
> and a sample support for bnxt. It's not very comprehensive in
> terms of stat types or driver support. The expectation is that
> the support will grow organically. If we have the basic pieces
> in place it will be easy for reviewers to request new stats,
> or use of the API in place of ethtool -S.
>
> See patch 3 for sample output.
>
> v3:
>  - remove the dump error handling, core does it now (b5a899154aa94)
>  - fix ring mapping w/ XDP in bnxt
> v2: https://lore.kernel.org/all/20240229010221.2408413-1-kuba@kernel.org/
>  - un-wrap short lines
>  - s/stats/qstats/
> v1: https://lore.kernel.org/all/20240226211015.1244807-1-kuba@kernel.org/
>  - rename projection -> scope
>  - turn projection/scope into flags
>  - remove the "netdev" scope since it's always implied
> rfc: https://lore.kernel.org/all/20240222223629.158254-1-kuba@kernel.org/
>
> Jakub Kicinski (3):
>   netdev: add per-queue statistics
>   netdev: add queue stat for alloc failures
>   eth: bnxt: support per-queue statistics
>
>  Documentation/netlink/specs/netdev.yaml   |  91 +++++++++
>  Documentation/networking/statistics.rst   |  15 ++
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c |  65 +++++++
>  include/linux/netdevice.h                 |   3 +
>  include/net/netdev_queues.h               |  56 ++++++
>  include/uapi/linux/netdev.h               |  20 ++
>  net/core/netdev-genl-gen.c                |  12 ++
>  net/core/netdev-genl-gen.h                |   2 +
>  net/core/netdev-genl.c                    | 214 ++++++++++++++++++++++
>  tools/include/uapi/linux/netdev.h         |  20 ++
>  10 files changed, 498 insertions(+)
>
> --
> 2.44.0
>
>
patchwork-bot+netdevbpf@kernel.org March 8, 2024, 6 a.m. UTC | #2
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  6 Mar 2024 11:55:06 -0800 you wrote:
> Hi!
> 
> Per queue stats keep coming up, so it's about time someone laid
> the foundation. This series adds the uAPI, a handful of stats
> and a sample support for bnxt. It's not very comprehensive in
> terms of stat types or driver support. The expectation is that
> the support will grow organically. If we have the basic pieces
> in place it will be easy for reviewers to request new stats,
> or use of the API in place of ethtool -S.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/3] netdev: add per-queue statistics
    https://git.kernel.org/netdev/net-next/c/ab63a2387cb9
  - [net-next,v3,2/3] netdev: add queue stat for alloc failures
    https://git.kernel.org/netdev/net-next/c/92f8b1f5ca0f
  - [net-next,v3,3/3] eth: bnxt: support per-queue statistics
    https://git.kernel.org/netdev/net-next/c/af7b3b4adda5

You are awesome, thank you!