| Message ID | 20240308114339.1340549-3-john.g.garry@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ad802f7f27fc9f8a2dd463b815d10aca8a3cc668 |
| Headers | show |
| Series | Add LIBSAS_SHT_BASE for libsas | expand |
On Fri, Mar 08, 2024 at 11:43:35AM +0000, John Garry wrote: > Use standard template for scsi_host_template structure to reduce > duplication. > > Signed-off-by: John Garry <john.g.garry@oracle.com> > --- > drivers/scsi/pm8001/pm8001_init.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) Reviewed-by: Igor Pylypiv <ipylypiv@google.com> Thanks, Igor
On 2024/3/8 19:43, John Garry wrote: > Use standard template for scsi_host_template structure to reduce > duplication. > > Signed-off-by: John Garry<john.g.garry@oracle.com> > --- > drivers/scsi/pm8001/pm8001_init.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) Reviewed-by: Jason Yan <yanaijie@huawei.com>
diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c index ed6b7d954dda..2ba320ff0d50 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -110,29 +110,11 @@ static void pm8001_map_queues(struct Scsi_Host *shost) * The main structure which LLDD must register for scsi core. */ static const struct scsi_host_template pm8001_sht = { - .module = THIS_MODULE, - .name = DRV_NAME, - .proc_name = DRV_NAME, - .queuecommand = sas_queuecommand, - .dma_need_drain = ata_scsi_dma_need_drain, - .target_alloc = sas_target_alloc, - .slave_configure = sas_slave_configure, + LIBSAS_SHT_BASE .scan_finished = pm8001_scan_finished, .scan_start = pm8001_scan_start, - .change_queue_depth = sas_change_queue_depth, - .bios_param = sas_bios_param, .can_queue = 1, - .this_id = -1, .sg_tablesize = PM8001_MAX_DMA_SG, - .max_sectors = SCSI_DEFAULT_MAX_SECTORS, - .eh_device_reset_handler = sas_eh_device_reset_handler, - .eh_target_reset_handler = sas_eh_target_reset_handler, - .slave_alloc = sas_slave_alloc, - .target_destroy = sas_target_destroy, - .ioctl = sas_ioctl, -#ifdef CONFIG_COMPAT - .compat_ioctl = sas_ioctl, -#endif .shost_groups = pm8001_host_groups, .track_queue_depth = 1, .cmd_per_lun = 32,
Use standard template for scsi_host_template structure to reduce duplication. Signed-off-by: John Garry <john.g.garry@oracle.com> --- drivers/scsi/pm8001/pm8001_init.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-)