[0/3] ALSA: scarlett2: Scarlett 4th Gen fixes for 6.8

Message

Geoffrey D. Bennett March 10, 2024, 10:34 a.m. UTC

Hi Takashi,

I have three minor fixes for the Scarlett 4th Gen driver in 6.8:
- The low-voltage indication is now being read from the correct offset
- The autogain status values are now all correctly interpreted
- The input gain range is now correct

Regards,
Geoffrey.

Geoffrey D. Bennett (3):
  ALSA: scarlett2: Fix Scarlett 4th Gen 4i4 low-voltage detection
  ALSA: scarlett2: Fix Scarlett 4th Gen autogain status values
  ALSA: scarlett2: Fix Scarlett 4th Gen input gain range

 sound/usb/mixer_scarlett2.c | 85 ++++++++++++++++++++-----------------
 1 file changed, 46 insertions(+), 39 deletions(-)

Comments

Takashi Iwai March 11, 2024, 8:16 a.m. UTC | #1

On Sun, 10 Mar 2024 11:34:09 +0100,
Geoffrey D. Bennett wrote:
> 
> Hi Takashi,
> 
> I have three minor fixes for the Scarlett 4th Gen driver in 6.8:
> - The low-voltage indication is now being read from the correct offset
> - The autogain status values are now all correctly interpreted
> - The input gain range is now correct
> 
> Regards,
> Geoffrey.
> 
> Geoffrey D. Bennett (3):
>   ALSA: scarlett2: Fix Scarlett 4th Gen 4i4 low-voltage detection
>   ALSA: scarlett2: Fix Scarlett 4th Gen autogain status values
>   ALSA: scarlett2: Fix Scarlett 4th Gen input gain range

Applied all patches now.  Thanks.


Takashi

Geoffrey D. Bennett March 11, 2024, 8:42 a.m. UTC | #2

On Mon, Mar 11, 2024 at 09:16:04AM +0100, Takashi Iwai wrote:
> On Sun, 10 Mar 2024 11:34:09 +0100,
> Geoffrey D. Bennett wrote:
> > 
> > Hi Takashi,
> > 
> > I have three minor fixes for the Scarlett 4th Gen driver in 6.8:
> > - The low-voltage indication is now being read from the correct offset
> > - The autogain status values are now all correctly interpreted
> > - The input gain range is now correct
> > 
> > Regards,
> > Geoffrey.
> > 
> > Geoffrey D. Bennett (3):
> >   ALSA: scarlett2: Fix Scarlett 4th Gen 4i4 low-voltage detection
> >   ALSA: scarlett2: Fix Scarlett 4th Gen autogain status values
> >   ALSA: scarlett2: Fix Scarlett 4th Gen input gain range
> 
> Applied all patches now.  Thanks.

Hi Takashi,

Sorry for the inconvience, I have a v2 of the 3rd patch "Fix Scarlett
4th Gen input gain range" which I will send in a moment. Please let me
know if you prefer a patch on top of the above rather than a
replacement patch.

Thanks,
Geoffrey.

Takashi Iwai March 11, 2024, 8:44 a.m. UTC | #3

On Mon, 11 Mar 2024 09:42:34 +0100,
Geoffrey D. Bennett wrote:
> 
> On Mon, Mar 11, 2024 at 09:16:04AM +0100, Takashi Iwai wrote:
> > On Sun, 10 Mar 2024 11:34:09 +0100,
> > Geoffrey D. Bennett wrote:
> > > 
> > > Hi Takashi,
> > > 
> > > I have three minor fixes for the Scarlett 4th Gen driver in 6.8:
> > > - The low-voltage indication is now being read from the correct offset
> > > - The autogain status values are now all correctly interpreted
> > > - The input gain range is now correct
> > > 
> > > Regards,
> > > Geoffrey.
> > > 
> > > Geoffrey D. Bennett (3):
> > >   ALSA: scarlett2: Fix Scarlett 4th Gen 4i4 low-voltage detection
> > >   ALSA: scarlett2: Fix Scarlett 4th Gen autogain status values
> > >   ALSA: scarlett2: Fix Scarlett 4th Gen input gain range
> > 
> > Applied all patches now.  Thanks.
> 
> Hi Takashi,
> 
> Sorry for the inconvience, I have a v2 of the 3rd patch "Fix Scarlett
> 4th Gen input gain range" which I will send in a moment. Please let me
> know if you prefer a patch on top of the above rather than a
> replacement patch.

Yes, please send an incremental fix.
You can get the commits in for-linus branch of sound.git tree.


thanks,

Takashi

Geoffrey D. Bennett March 11, 2024, 9:27 a.m. UTC | #4

On Mon, Mar 11, 2024 at 09:44:51AM +0100, Takashi Iwai wrote:
> On Mon, 11 Mar 2024 09:42:34 +0100,
> Geoffrey D. Bennett wrote:
> > 
> > On Mon, Mar 11, 2024 at 09:16:04AM +0100, Takashi Iwai wrote:
> > > On Sun, 10 Mar 2024 11:34:09 +0100,
> > > Geoffrey D. Bennett wrote:
> > > > 
> > > > Hi Takashi,
> > > > 
> > > > I have three minor fixes for the Scarlett 4th Gen driver in 6.8:
> > > > - The low-voltage indication is now being read from the correct offset
> > > > - The autogain status values are now all correctly interpreted
> > > > - The input gain range is now correct
> > > > 
> > > > Regards,
> > > > Geoffrey.
> > > > 
> > > > Geoffrey D. Bennett (3):
> > > >   ALSA: scarlett2: Fix Scarlett 4th Gen 4i4 low-voltage detection
> > > >   ALSA: scarlett2: Fix Scarlett 4th Gen autogain status values
> > > >   ALSA: scarlett2: Fix Scarlett 4th Gen input gain range
> > > 
> > > Applied all patches now.  Thanks.
> > 
> > Hi Takashi,
> > 
> > Sorry for the inconvience, I have a v2 of the 3rd patch "Fix Scarlett
> > 4th Gen input gain range" which I will send in a moment. Please let me
> > know if you prefer a patch on top of the above rather than a
> > replacement patch.
> 
> Yes, please send an incremental fix.
> You can get the commits in for-linus branch of sound.git tree.

Thanks for your patience. I have submitted an incremental fix,
hopefully correct this time!