| Message ID | 20240310145503.32721-1-witu@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | eaf657f7adba8984509db7403ac6bdaa219e5722 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net-next] devlink: Add comments to use netlink gen tool | expand |
Sun, Mar 10, 2024 at 03:55:03PM CET, witu@nvidia.com wrote: >Add the comment to remind people not to manually modify >the net/devlink/netlink_gen.c, but to use tools/net/ynl/ynl-regen.sh >to generate it. > >Signed-off-by: William Tu <witu@nvidia.com> >Suggested-by: Jiri Pirko <jiri@nvidia.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com> Thanks!
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sun, 10 Mar 2024 16:55:03 +0200 you wrote: > Add the comment to remind people not to manually modify > the net/devlink/netlink_gen.c, but to use tools/net/ynl/ynl-regen.sh > to generate it. > > Signed-off-by: William Tu <witu@nvidia.com> > Suggested-by: Jiri Pirko <jiri@nvidia.com> > > [...] Here is the summary with links: - [v2,net-next] devlink: Add comments to use netlink gen tool https://git.kernel.org/netdev/net-next/c/eaf657f7adba You are awesome, thank you!
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index 130cae0d3e20..2da0c7eb6710 100644 --- a/include/uapi/linux/devlink.h +++ b/include/uapi/linux/devlink.h @@ -614,7 +614,10 @@ enum devlink_attr { DEVLINK_ATTR_REGION_DIRECT, /* flag */ - /* add new attributes above here, update the policy in devlink.c */ + /* Add new attributes above here, update the spec in + * Documentation/netlink/specs/devlink.yaml and re-generate + * net/devlink/netlink_gen.c. + */ __DEVLINK_ATTR_MAX, DEVLINK_ATTR_MAX = __DEVLINK_ATTR_MAX - 1
Add the comment to remind people not to manually modify the net/devlink/netlink_gen.c, but to use tools/net/ynl/ynl-regen.sh to generate it. Signed-off-by: William Tu <witu@nvidia.com> Suggested-by: Jiri Pirko <jiri@nvidia.com> --- v2: fix checkpatch error --- include/uapi/linux/devlink.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)