| Message ID | 20240307221122.2094511-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 900b2801bf250affe410193a0d27a2ba9f2db4e5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] ynl: samples: fix recycling rate calculation | expand |
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 7 Mar 2024 14:11:22 -0800 you wrote: > Running the page-pool sample on production machines under moderate > networking load shows recycling rate higher than 100%: > > $ page-pool > eth0[2] page pools: 14 (zombies: 0) > refs: 89088 bytes: 364904448 (refs: 0 bytes: 0) > recycling: 100.3% (alloc: 1392:2290247724 recycle: 469289484:1828235386) > > [...] Here is the summary with links: - [net-next] ynl: samples: fix recycling rate calculation https://git.kernel.org/netdev/net-next/c/900b2801bf25 You are awesome, thank you!
diff --git a/tools/net/ynl/samples/page-pool.c b/tools/net/ynl/samples/page-pool.c index 098b5190d0e5..332f281ee5cb 100644 --- a/tools/net/ynl/samples/page-pool.c +++ b/tools/net/ynl/samples/page-pool.c @@ -95,6 +95,8 @@ int main(int argc, char **argv) if (pp->_present.alloc_fast) s->alloc_fast += pp->alloc_fast; + if (pp->_present.alloc_refill) + s->alloc_fast += pp->alloc_refill; if (pp->_present.alloc_slow) s->alloc_slow += pp->alloc_slow; if (pp->_present.recycle_ring)
Running the page-pool sample on production machines under moderate networking load shows recycling rate higher than 100%: $ page-pool eth0[2] page pools: 14 (zombies: 0) refs: 89088 bytes: 364904448 (refs: 0 bytes: 0) recycling: 100.3% (alloc: 1392:2290247724 recycle: 469289484:1828235386) Note that outstanding refs (89088) == slow alloc * cache size (1392 * 64) which means this machine is recycling page pool pages perfectly, not a single page has been released. The extra 0.3% is because sample ignores allocations from the ptr_ring. Treat those the same as alloc_fast, the ring vs cache alloc is already captured accurately enough by recycling stats. With the fix: $ page-pool eth0[2] page pools: 14 (zombies: 0) refs: 89088 bytes: 364904448 (refs: 0 bytes: 0) recycling: 100.0% (alloc: 1392:2331141604 recycle: 473625579:1857460661) Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: hawk@kernel.org --- tools/net/ynl/samples/page-pool.c | 2 ++ 1 file changed, 2 insertions(+)