[0/9] Move camss version related defs in to resources

Message

Gjorgji Rosikopulos (Consultant) Feb. 27, 2024, 12:24 p.m. UTC

The different resources required for different camss versions are
split in to two groups:

1. Camss device related. In this group are all resources described
in the device tree, clocks, regulators etc.

2. Sub-device specific resources. In the initialization
of the each sub-device, the version of camss is passed.
Based on this version the sub-device adds: hw layer support,
per pad formats, number of dma's etc.

The code for "1" group lives in camss.c itself. However the "2" group
is spread across all sub-device implementations including video device.

This kind of separation is not very convenient when adding new hw
version. The reason is that you need to add support in all sub-device
implementations.

There were some improvements in this direction where some of the
hw version related definitions were moved in to the "1". One
example is attaching of the hw operations.

This series aim to improve the things more and add additional definitions
in to the "1".


What is included:

- Remove all format definitions from camss video. The will be passed
  by the parent sub-device

- Make camss generic format definition mapping, containing mbus to
  v4l2 mapping, mbus bpp and other required fields used by the
  sub-device and video node.

- Add per sub-device type union in the resources, different
  sub-devices are using different resources, as an example: is_lite flag.

- Move camss link operation in to the resources. Currently one
  function supports different topologies depending of the number
  of devices. As hw version support increases this is not good
  way of supporting different topologies.

- Add parent device ops in to the resources. This resolves
  inter-dependencies of vfe and csid. Csid requests the clocks
  regulators etc from parent device instead calling directly vfe
  functions.

- Some cleanups in csid code for split the configuration of
  RX and testgen and RDI.

Atanas Filipov (1):
  media: qcom: camss: Decompose register and link operations

Milen Mitkov (3):
  media: qcom: camss: Designate lite subdevices in resources
  media: qcom: camss: Split testgen, RDI and RX for CSID 170
  media: qcom: camss: Decouple VFE from CSID

Radoslav Tsvetkov (5):
  media: qcom: camss: Add per sub-device type resources
  media: qcom: camss: Attach formats to VFE resources
  media: qcom: camss: Attach formats to CSID resources
  media: qcom: camss: Attach formats to CSIPHY resources
  media: qcom: camss: Move format related functions

 drivers/media/platform/qcom/camss/Makefile    |   1 +
 .../platform/qcom/camss/camss-csid-4-1.c      | 132 +---
 .../platform/qcom/camss/camss-csid-4-7.c      | 160 +----
 .../platform/qcom/camss/camss-csid-gen2.c     | 410 +++++--------
 .../media/platform/qcom/camss/camss-csid.c    | 512 +++++++++++++++-
 .../media/platform/qcom/camss/camss-csid.h    |  32 +-
 .../media/platform/qcom/camss/camss-csiphy.c  |  73 +--
 .../media/platform/qcom/camss/camss-csiphy.h  |  23 +-
 .../media/platform/qcom/camss/camss-format.c  |  98 +++
 .../media/platform/qcom/camss/camss-format.h  |  67 ++
 .../media/platform/qcom/camss/camss-vfe-170.c |  10 +-
 .../media/platform/qcom/camss/camss-vfe-4-1.c |   4 +-
 .../media/platform/qcom/camss/camss-vfe-4-7.c |   6 +-
 .../media/platform/qcom/camss/camss-vfe-4-8.c |   6 +-
 .../platform/qcom/camss/camss-vfe-gen1.c      |   8 +-
 drivers/media/platform/qcom/camss/camss-vfe.c | 483 +++++++++------
 drivers/media/platform/qcom/camss/camss-vfe.h |  22 +-
 .../media/platform/qcom/camss/camss-video.c   | 294 +--------
 .../media/platform/qcom/camss/camss-video.h   |   5 +-
 drivers/media/platform/qcom/camss/camss.c     | 577 +++++++++++++-----
 drivers/media/platform/qcom/camss/camss.h     |  28 +-
 21 files changed, 1656 insertions(+), 1295 deletions(-)
 create mode 100644 drivers/media/platform/qcom/camss/camss-format.c
 create mode 100644 drivers/media/platform/qcom/camss/camss-format.h

Comments

Bryan O'Donoghue March 11, 2024, 4:22 p.m. UTC | #1

On 27/02/2024 12:24, Gjorgji Rosikopulos wrote:
> The different resources required for different camss versions are
> split in to two groups:

Pardon me for not getting back to you on this earlier.

Would appreciate if you could post this series rebased on sc8280xp 
patches which are @ v6 and ready for merge already.

I will find time this week to test your patches on rb3, rb5 and x13s 
with the SoftISP patches on libcamera.

---
bod

Bryan O'Donoghue March 11, 2024, 4:23 p.m. UTC | #2

On 11/03/2024 16:22, Bryan O'Donoghue wrote:
> On 27/02/2024 12:24, Gjorgji Rosikopulos wrote:
>> The different resources required for different camss versions are
>> split in to two groups:
> 
> Pardon me for not getting back to you on this earlier.
> 
> Would appreciate if you could post this series rebased on sc8280xp 
> patches which are @ v6 and ready for merge already.
> 
> I will find time this week to test your patches on rb3, rb5 and x13s 
> with the SoftISP patches on libcamera.
> 
> ---
> bod
> 

These patches

https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/sc8280xp-v6.8-rc4-camss?ref_type=heads

---
bod

Gjorgji Rosikopulos (Consultant) March 12, 2024, 11:57 a.m. UTC | #3

Hi Bryan,

On 3/11/2024 6:23 PM, Bryan O'Donoghue wrote:
> On 11/03/2024 16:22, Bryan O'Donoghue wrote:
>> On 27/02/2024 12:24, Gjorgji Rosikopulos wrote:
>>> The different resources required for different camss versions are
>>> split in to two groups:
>>
>> Pardon me for not getting back to you on this earlier.
>>
>> Would appreciate if you could post this series rebased on sc8280xp
>> patches which are @ v6 and ready for merge already.
>>
>> I will find time this week to test your patches on rb3, rb5 and x13s
>> with the SoftISP patches on libcamera.
>>
>> ---
>> bod
>>
> 
> These patches
> 
> https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/sc8280xp-v6.8-rc4-camss?ref_type=heads

Thanks i will re-base and post the patches on top of sc8280xp.

~Gjorgji