| Message ID | 20240314065140.27468-1-yanjun.zhu@linux.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] RDMA/rxe: Fix the problem "mutex_destroy missing" | expand |
On Thu, March 14, 2024 3:52 PM Yanjun.Zhu wrote: > > When a mutex lock is not used any more, the function mutex_destroy > should be called to mark the mutex lock uninitialized. > > Fixes: 8700e3e7c485 ("Soft RoCE driver") > Signed-off-by: Yanjun.Zhu <yanjun.zhu@linux.dev> > --- > drivers/infiniband/sw/rxe/rxe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c > index 54c723a6edda..6f9ec8db014c 100644 > --- a/drivers/infiniband/sw/rxe/rxe.c > +++ b/drivers/infiniband/sw/rxe/rxe.c > @@ -33,6 +33,8 @@ void rxe_dealloc(struct ib_device *ib_dev) > > if (rxe->tfm) > crypto_free_shash(rxe->tfm); > + > + mutex_destroy(&rxe->usdev_lock); > } > > /* initialize rxe device parameters */ > -- > 2.34.1 > That's right. Reviewed-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com> Daisuke
On Thu, 14 Mar 2024 07:51:40 +0100, Yanjun.Zhu wrote: > When a mutex lock is not used any more, the function mutex_destroy > should be called to mark the mutex lock uninitialized. > > Applied, thanks! [1/1] RDMA/rxe: Fix the problem "mutex_destroy missing" https://git.kernel.org/rdma/rdma/c/481047d7e8391d Best regards,
diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c index 54c723a6edda..6f9ec8db014c 100644 --- a/drivers/infiniband/sw/rxe/rxe.c +++ b/drivers/infiniband/sw/rxe/rxe.c @@ -33,6 +33,8 @@ void rxe_dealloc(struct ib_device *ib_dev) if (rxe->tfm) crypto_free_shash(rxe->tfm); + + mutex_destroy(&rxe->usdev_lock); } /* initialize rxe device parameters */
When a mutex lock is not used any more, the function mutex_destroy should be called to mark the mutex lock uninitialized. Fixes: 8700e3e7c485 ("Soft RoCE driver") Signed-off-by: Yanjun.Zhu <yanjun.zhu@linux.dev> --- drivers/infiniband/sw/rxe/rxe.c | 2 ++ 1 file changed, 2 insertions(+)