mbox series

[0/2] afs: Miscellaneous fixes

Message ID 20240313081505.3060173-1-dhowells@redhat.com (mailing list archive)
Headers show
Series afs: Miscellaneous fixes | expand

Message

David Howells March 13, 2024, 8:15 a.m. UTC
Hi Marc,

Here are some fixes for afs, if you could look them over?

 (1) Fix the caching of preferred address of a fileserver.  By doing that, we
     stick with whatever address we get a response back from first rather then
     obeying any preferences set.

 (2) Fix an occasional FetchStatus-after-RemoveDir.  The FetchStatus then
     fails with VNOVNODE (equivalent to -ENOENT) that confuses parts of the
     driver that aren't expecting that.

The patches can be found here:

	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-fixes

Thanks,
David

David Howells (2):
  afs: Don't cache preferred address
  afs: Fix occasional rmdir-then-VNOVNODE with generic/011

 fs/afs/rotate.c     | 21 ++++-----------------
 fs/afs/validation.c | 16 +++++++++-------
 2 files changed, 13 insertions(+), 24 deletions(-)

Comments

Marc Dionne March 13, 2024, 12:55 p.m. UTC | #1
On Wed, Mar 13, 2024 at 5:15 AM David Howells <dhowells@redhat.com> wrote:
>
> Hi Marc,
>
> Here are some fixes for afs, if you could look them over?
>
>  (1) Fix the caching of preferred address of a fileserver.  By doing that, we
>      stick with whatever address we get a response back from first rather then
>      obeying any preferences set.
>
>  (2) Fix an occasional FetchStatus-after-RemoveDir.  The FetchStatus then
>      fails with VNOVNODE (equivalent to -ENOENT) that confuses parts of the
>      driver that aren't expecting that.
>
> The patches can be found here:
>
>         https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-fixes
>
> Thanks,
> David
>
> David Howells (2):
>   afs: Don't cache preferred address
>   afs: Fix occasional rmdir-then-VNOVNODE with generic/011
>
>  fs/afs/rotate.c     | 21 ++++-----------------
>  fs/afs/validation.c | 16 +++++++++-------
>  2 files changed, 13 insertions(+), 24 deletions(-)

Reviewed-by: Marc Dionne <marc.dionne@auristor.com>

Marc
Christian Brauner March 14, 2024, 11:13 a.m. UTC | #2
On Wed, 13 Mar 2024 08:15:01 +0000, David Howells wrote:
> Here are some fixes for afs, if you could look them over?
> 
>  (1) Fix the caching of preferred address of a fileserver.  By doing that, we
>      stick with whatever address we get a response back from first rather then
>      obeying any preferences set.
> 
>  (2) Fix an occasional FetchStatus-after-RemoveDir.  The FetchStatus then
>      fails with VNOVNODE (equivalent to -ENOENT) that confuses parts of the
>      driver that aren't expecting that.
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/2] afs: Don't cache preferred address
      https://git.kernel.org/vfs/vfs/c/b719dcc8b02d
[2/2] afs: Fix occasional rmdir-then-VNOVNODE with generic/011
      https://git.kernel.org/vfs/vfs/c/4eed8f8549f4