| Message ID | 20240306030649.60269-1-vignesh.raman@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/ci: Add support for GPU and display testing | expand |
On 06/03/2024 00:06, Vignesh Raman wrote: > Some ARM SOCs have a separate display controller and GPU, each with > different drivers. For mediatek mt8173, the GPU driver is powervr, > and the display driver is mediatek. In the case of mediatek mt8183, > the GPU driver is panfrost, and the display driver is mediatek. > With rockchip rk3288/rk3399, the GPU driver is panfrost, while the > display driver is rockchip. For amlogic meson, the GPU driver is > panfrost, and the display driver is meson. > > IGT tests run various tests with different xfails and can test both > GPU devices and KMS/display devices. Currently, in drm-ci for MediaTek, > Rockchip, and Amlogic Meson platforms, only the GPU driver is tested. > This leads to incomplete coverage since the display is never tested on > these platforms. This commit series adds support in drm-ci to run tests > for both GPU and display drivers for MediaTek, Rockchip, and Amlogic > Meson platforms. > > Uprev mesa and IGT in drm-ci and add amd, v3d, vc4 and vgem specific > tests to testlist. Have testlist.txt per driver and include a base > testlist so that the driver specific tests will run only on those hardware > and add testlists to the MAINTAINERS file. > > This series also includes patch to add vkms testing to drm-ci. > > Working pipeline link, > https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1119859 Hi Vignesh, thanks for this patchset. Just to confirm, the new convention is: stages are named per DRIVER_NAME jobs are named DRIVER_NAME:GPU_VERSION xfails files and testlist files are named DRIVER_NAME-<xfails-suffix>.txt Looks good. I just have some minor comments/questions in the series, please check. Regards, Helen > > Vignesh Raman (11): > drm/ci: arm64.config: Enable CONFIG_DRM_ANALOGIX_ANX7625 > drm/ci: uprev mesa version > drm/ci: uprev IGT and update testlist > drm/ci: amdgpu: update xfails > drm/ci: mediatek: Refactor existing mediatek jobs > drm/ci: mediatek: Add job to test panfrost and powervr GPU driver > drm/ci: meson: Refactor existing meson jobs > drm/ci: meson: Add job to test panfrost GPU driver > drm/ci: rockchip: Refactor existing rockchip jobs > drm/ci: rockchip: Add job to test panfrost GPU driver > drm/ci: add tests on vkms > > MAINTAINERS | 14 ++ > drivers/gpu/drm/ci/arm64.config | 1 + > drivers/gpu/drm/ci/build.sh | 1 - > drivers/gpu/drm/ci/container.yml | 6 +- > drivers/gpu/drm/ci/gitlab-ci.yml | 13 +- > drivers/gpu/drm/ci/igt_runner.sh | 28 ++-- > drivers/gpu/drm/ci/image-tags.yml | 5 +- > drivers/gpu/drm/ci/test.yml | 136 +++++++++++++--- > drivers/gpu/drm/ci/testlist-amdgpu.txt | 151 ++++++++++++++++++ > drivers/gpu/drm/ci/testlist-msm.txt | 50 ++++++ > drivers/gpu/drm/ci/testlist-panfrost.txt | 17 ++ > drivers/gpu/drm/ci/testlist-v3d.txt | 73 +++++++++ > drivers/gpu/drm/ci/testlist-vc4.txt | 49 ++++++ > drivers/gpu/drm/ci/testlist.txt | 84 ++++------ > drivers/gpu/drm/ci/x86_64.config | 1 + > .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 26 ++- > .../drm/ci/xfails/amdgpu-stoney-flakes.txt | 10 +- > .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 17 +- > .../drm/ci/xfails/mediatek-mt8173-fails.txt | 15 -- > .../drm/ci/xfails/mediatek-mt8173-flakes.txt | 13 ++ > .../drm/ci/xfails/mediatek-mt8183-fails.txt | 21 ++- > .../drm/ci/xfails/mediatek-mt8183-flakes.txt | 8 + > .../gpu/drm/ci/xfails/meson-g12b-fails.txt | 5 - > .../gpu/drm/ci/xfails/panfrost-g12b-fails.txt | 1 + > .../gpu/drm/ci/xfails/panfrost-g12b-skips.txt | 2 + > .../drm/ci/xfails/panfrost-mt8183-fails.txt | 1 + > .../drm/ci/xfails/panfrost-mt8183-skips.txt | 2 + > .../drm/ci/xfails/panfrost-rk3288-fails.txt | 1 + > .../drm/ci/xfails/panfrost-rk3288-skips.txt | 2 + > .../drm/ci/xfails/panfrost-rk3399-fails.txt | 1 + > .../drm/ci/xfails/panfrost-rk3399-skips.txt | 2 + > .../drm/ci/xfails/rockchip-rk3288-fails.txt | 58 ++----- > .../drm/ci/xfails/rockchip-rk3288-flakes.txt | 20 +++ > .../drm/ci/xfails/rockchip-rk3288-skips.txt | 54 +------ > .../drm/ci/xfails/rockchip-rk3399-fails.txt | 38 +++-- > .../drm/ci/xfails/rockchip-rk3399-flakes.txt | 28 +++- > .../drm/ci/xfails/rockchip-rk3399-skips.txt | 5 +- > .../drm/ci/xfails/virtio_gpu-none-fails.txt | 1 - > drivers/gpu/drm/ci/xfails/vkms-none-fails.txt | 33 ++++ > .../gpu/drm/ci/xfails/vkms-none-flakes.txt | 20 +++ > drivers/gpu/drm/ci/xfails/vkms-none-skips.txt | 16 ++ > 41 files changed, 784 insertions(+), 245 deletions(-) > create mode 100644 drivers/gpu/drm/ci/testlist-amdgpu.txt > create mode 100644 drivers/gpu/drm/ci/testlist-msm.txt > create mode 100644 drivers/gpu/drm/ci/testlist-panfrost.txt > create mode 100644 drivers/gpu/drm/ci/testlist-v3d.txt > create mode 100644 drivers/gpu/drm/ci/testlist-vc4.txt > create mode 100644 drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt > create mode 100644 drivers/gpu/drm/ci/xfails/mediatek-mt8183-flakes.txt > create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-g12b-fails.txt > create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-g12b-skips.txt > create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-mt8183-fails.txt > create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-mt8183-skips.txt > create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-rk3288-fails.txt > create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-rk3288-skips.txt > create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-rk3399-fails.txt > create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-rk3399-skips.txt > create mode 100644 drivers/gpu/drm/ci/xfails/rockchip-rk3288-flakes.txt > create mode 100644 drivers/gpu/drm/ci/xfails/vkms-none-fails.txt > create mode 100644 drivers/gpu/drm/ci/xfails/vkms-none-flakes.txt > create mode 100644 drivers/gpu/drm/ci/xfails/vkms-none-skips.txt >
Hi Helen, On 07/03/24 19:32, Helen Koike wrote: > > > On 06/03/2024 00:06, Vignesh Raman wrote: >> Some ARM SOCs have a separate display controller and GPU, each with >> different drivers. For mediatek mt8173, the GPU driver is powervr, >> and the display driver is mediatek. In the case of mediatek mt8183, >> the GPU driver is panfrost, and the display driver is mediatek. >> With rockchip rk3288/rk3399, the GPU driver is panfrost, while the >> display driver is rockchip. For amlogic meson, the GPU driver is >> panfrost, and the display driver is meson. >> >> IGT tests run various tests with different xfails and can test both >> GPU devices and KMS/display devices. Currently, in drm-ci for MediaTek, >> Rockchip, and Amlogic Meson platforms, only the GPU driver is tested. >> This leads to incomplete coverage since the display is never tested on >> these platforms. This commit series adds support in drm-ci to run tests >> for both GPU and display drivers for MediaTek, Rockchip, and Amlogic >> Meson platforms. >> >> Uprev mesa and IGT in drm-ci and add amd, v3d, vc4 and vgem specific >> tests to testlist. Have testlist.txt per driver and include a base >> testlist so that the driver specific tests will run only on those >> hardware >> and add testlists to the MAINTAINERS file. >> >> This series also includes patch to add vkms testing to drm-ci. >> >> Working pipeline link, >> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1119859 > > Hi Vignesh, thanks for this patchset. > > Just to confirm, the new convention is: > > stages are named per DRIVER_NAME Yes correct. > jobs are named DRIVER_NAME:GPU_VERSION Yes > xfails files and testlist files are named DRIVER_NAME-<xfails-suffix>.txt Base testlist is named as testlist.txt driver specific testlist is named as testlist-$DRIVER_NAME.txt xfails files are named as $DRIVER_NAME-$GPU_VERSION-<xfails-suffix>.txt (mediatek-mt8183-fails.txt) > > Looks good. > > I just have some minor comments/questions in the series, please check. Will address those and send v5. Regards, Vignesh