[v2,0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

Message

Jiawei Wang March 12, 2024, 4:32 p.m. UTC

I would like to revert two of my previous commits after
realizing they incorrectly enabled the Yellow Carp
(YC) driver for Pink Sardine (PS) platforms.

The first commit was reverted because it added a quirk entry
that incorrectly enabled the YC driver for the Lenovo 21J2
laptop, which is a PS platform.

The second commit was reverted because it incorrectly enabled
the YC driver for PS platforms.

Thanks to Mukunda Vijendar [1] for pointing this out.

Link: https://lore.kernel.org/linux-sound/[e-mail]/ [1]

On 2024-03-12 13:14 UTC, Mark Brown wrote:
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

The patches' subject lines have been changed to
ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

On 2024-03-12 13:56 UTC, Mark Brown wrote:
> > This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc.
> 
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.

I have added descriptions around commit hashes in the updated patch set, 
copied below for convenience:
1. This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc,
which added a quirk entry to enable the Yellow Carp (YC)
driver for the Lenovo 21J2 laptop.
2. This reverts commit 316a784839b21b122e1761cdca54677bb19a47fa,
that enabled Yellow Carp (YC) driver for PCI revision id 0x63.

> This doesn't apply against current code, please check and resend - there
> was another quirk went in yesterday which might also need to be
> reverted.

I have updated the explanation for the first patch for why
the quirk entry for Lenovo 21J2 should be removed.
Please find my updated explanation in [PATCH v2 1/2].

Thanks for the review.

Signed-off-by: Jiawei Wang <[e-mail]>

Jiawei Wang (2):
  ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
  ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 sound/soc/amd/yc/pci-acp6x.c  | 1 -
 2 files changed, 8 deletions(-)

Comments

Mark Brown March 15, 2024, 5:14 p.m. UTC | #1

On Wed, 13 Mar 2024 00:32:54 +0800, Jiawei Wang wrote:
> I would like to revert two of my previous commits after
> realizing they incorrectly enabled the Yellow Carp
> (YC) driver for Pink Sardine (PS) platforms.
> 
> The first commit was reverted because it added a quirk entry
> that incorrectly enabled the YC driver for the Lenovo 21J2
> laptop, which is a PS platform.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
      commit: 861b3415e4dee06cc00cd1754808a7827b9105bf
[2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
      commit: 37bee1855d0e3b6dbeb8de71895f6f68cad137be

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark