| Message ID | IA1PR20MB49536DED242092A49A69CEB6BB2D2@IA1PR20MB4953.namprd20.prod.outlook.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | riscv: sophgo: add dmamux support for Sophgo CV1800/SG2000 SoCs | expand |
On 18/03/2024 07:38, Inochi Amaoto wrote: > Add dma multiplexer support for the Sophgo CV1800/SG2000 SoCs. > > The patch include the following patch: > http://lore.kernel.org/linux-riscv/PH7PR20MB4962F822A64CB127911978AABB4E2@PH7PR20MB4962.namprd20.prod.outlook.com/ What does it mean? Did you include here some other commit, so when it get applied we end up with two same commits? No, that's not how to handle dependencies. Explain instead the dependency or combine patchsets. Best regards, Krzysztof
On Mon, Mar 18, 2024 at 09:06:19AM +0100, Krzysztof Kozlowski wrote: > On 18/03/2024 07:38, Inochi Amaoto wrote: > > Add dma multiplexer support for the Sophgo CV1800/SG2000 SoCs. > > > > The patch include the following patch: > > http://lore.kernel.org/linux-riscv/PH7PR20MB4962F822A64CB127911978AABB4E2@PH7PR20MB4962.namprd20.prod.outlook.com/ > > What does it mean? Did you include here some other commit, so when it > get applied we end up with two same commits? No, that's not how to > handle dependencies. Explain instead the dependency or combine patchsets. > Because the binding patch (patch 1) included is a must to describe syscon binding. And the driver code needs soc definition (patch 3). If these patch are maintained separately, patch 3 should go to series of syscon, which make dependency of these two patch setis too complex. So I tend to evolve them together. > Best regards, > Krzysztof >
On Mon, Mar 18, 2024 at 09:06:19AM +0100, Krzysztof Kozlowski wrote: > On 18/03/2024 07:38, Inochi Amaoto wrote: > > Add dma multiplexer support for the Sophgo CV1800/SG2000 SoCs. > > > > The patch include the following patch: > > http://lore.kernel.org/linux-riscv/PH7PR20MB4962F822A64CB127911978AABB4E2@PH7PR20MB4962.namprd20.prod.outlook.com/ > > What does it mean? Did you include here some other commit, so when it > get applied we end up with two same commits? No, that's not how to > handle dependencies. Explain instead the dependency or combine patchsets. > > Best regards, > Krzysztof > Hi Krzysztof, It seems that I missed an important point: Is it suitable to add an initital binding for the syscon, and add the dma-router property in this patch? If so, the dependency can be resolved and I will maintain the syscon change in the orignal patchset. Regards, Inochi
Add dma multiplexer support for the Sophgo CV1800/SG2000 SoCs. The patch include the following patch: http://lore.kernel.org/linux-riscv/PH7PR20MB4962F822A64CB127911978AABB4E2@PH7PR20MB4962.namprd20.prod.outlook.com/ Changed from v3: 1. fix dt-binding address issue. Changed from v2: 1. add reg property of dmamux node in the binding of patch 2 Changed from v1: 1. fix wrong title of patch 2. Inochi Amaoto (4): dt-bindings: dmaengine: Add dmamux for CV18XX/SG200X series SoC dt-bindings: soc: sophgo: Add top misc controller of CV18XX/SG200X series SoC soc/sophgo: add top sysctrl layout file for CV18XX/SG200X dmaengine: add driver for Sophgo CV18XX/SG200X dmamux .../bindings/dma/sophgo,cv1800-dmamux.yaml | 47 ++++ .../soc/sophgo/sophgo,cv1800-top-syscon.yaml | 57 +++++ drivers/dma/Kconfig | 9 + drivers/dma/Makefile | 1 + drivers/dma/cv1800-dmamux.c | 232 ++++++++++++++++++ include/dt-bindings/dma/cv1800-dma.h | 55 +++++ include/soc/sophgo/cv1800-sysctl.h | 30 +++ 7 files changed, 431 insertions(+) create mode 100644 Documentation/devicetree/bindings/dma/sophgo,cv1800-dmamux.yaml create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml create mode 100644 drivers/dma/cv1800-dmamux.c create mode 100644 include/dt-bindings/dma/cv1800-dma.h create mode 100644 include/soc/sophgo/cv1800-sysctl.h -- 2.44.0