| Message ID | 20240318023445.3192922-1-vt@altlinux.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8b65ef5ad4862904e476a8f3d4e4418c950ddb90 |
| Headers | show |
| Series | selftests/mm: Fix build with _FORTIFY_SOURCE | expand |
On 17 Mar 2024, at 22:34, Vitaly Chikunov wrote: > Add missing flags argument to open(2) call with O_CREAT. > > Some tests fail to compile if _FORTIFY_SOURCE is defined (to any valid > value) (together with -O), resulting in similar error messages such as: > > In file included from /usr/include/fcntl.h:342, > from gup_test.c:1: > In function 'open', > inlined from 'main' at gup_test.c:206:10: > /usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments > 50 | __open_missing_mode (); > | ^~~~~~~~~~~~~~~~~~~~~~ > > _FORTIFY_SOURCE is enabled by default in some distributions, so the > tests are not built by default and are skipped. > > open(2) man-page warns about missing flags argument: "if it is not > supplied, some arbitrary bytes from the stack will be applied as the > file mode." > > Fixes: aeb85ed4f41a ("tools/testing/selftests/vm/gup_benchmark.c: allow user specified file") > Fixes: fbe37501b252 ("mm: huge_memory: debugfs for file-backed THP split") > Fixes: c942f5bd17b3 ("selftests: soft-dirty: add test for mprotect") > Cc: Keith Busch <kbusch@kernel.org> > Cc: Zi Yan <ziy@nvidia.com> > Cc: Peter Xu <peterx@redhat.com> > Cc: Yang Shi <shy828301@gmail.com> > Cc: Andrea Arcangeli <aarcange@redhat.com> > Cc: Nadav Amit <nadav.amit@gmail.com> > Cc: David Hildenbrand <david@redhat.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Vitaly Chikunov <vt@altlinux.org> > --- > tools/testing/selftests/mm/gup_test.c | 2 +- > tools/testing/selftests/mm/soft-dirty.c | 2 +- > tools/testing/selftests/mm/split_huge_page_test.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) LGTM. Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com> -- Best Regards, Yan, Zi
On 18.03.24 03:34, Vitaly Chikunov wrote: > Add missing flags argument to open(2) call with O_CREAT. > > Some tests fail to compile if _FORTIFY_SOURCE is defined (to any valid > value) (together with -O), resulting in similar error messages such as: > > In file included from /usr/include/fcntl.h:342, > from gup_test.c:1: > In function 'open', > inlined from 'main' at gup_test.c:206:10: > /usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments > 50 | __open_missing_mode (); > | ^~~~~~~~~~~~~~~~~~~~~~ > > _FORTIFY_SOURCE is enabled by default in some distributions, so the > tests are not built by default and are skipped. > > open(2) man-page warns about missing flags argument: "if it is not > supplied, some arbitrary bytes from the stack will be applied as the > file mode." > > Fixes: aeb85ed4f41a ("tools/testing/selftests/vm/gup_benchmark.c: allow user specified file") > Fixes: fbe37501b252 ("mm: huge_memory: debugfs for file-backed THP split") > Fixes: c942f5bd17b3 ("selftests: soft-dirty: add test for mprotect") > Cc: Keith Busch <kbusch@kernel.org> > Cc: Zi Yan <ziy@nvidia.com> > Cc: Peter Xu <peterx@redhat.com> > Cc: Yang Shi <shy828301@gmail.com> > Cc: Andrea Arcangeli <aarcange@redhat.com> > Cc: Nadav Amit <nadav.amit@gmail.com> > Cc: David Hildenbrand <david@redhat.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Vitaly Chikunov <vt@altlinux.org> > --- Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c index cbe99594d319..18a49c70d4c6 100644 --- a/tools/testing/selftests/mm/gup_test.c +++ b/tools/testing/selftests/mm/gup_test.c @@ -203,7 +203,7 @@ int main(int argc, char **argv) ksft_print_header(); ksft_set_plan(nthreads); - filed = open(file, O_RDWR|O_CREAT); + filed = open(file, O_RDWR|O_CREAT, 0664); if (filed < 0) ksft_exit_fail_msg("Unable to open %s: %s\n", file, strerror(errno)); diff --git a/tools/testing/selftests/mm/soft-dirty.c b/tools/testing/selftests/mm/soft-dirty.c index cc5f144430d4..7dbfa53d93a0 100644 --- a/tools/testing/selftests/mm/soft-dirty.c +++ b/tools/testing/selftests/mm/soft-dirty.c @@ -137,7 +137,7 @@ static void test_mprotect(int pagemap_fd, int pagesize, bool anon) if (!map) ksft_exit_fail_msg("anon mmap failed\n"); } else { - test_fd = open(fname, O_RDWR | O_CREAT); + test_fd = open(fname, O_RDWR | O_CREAT, 0664); if (test_fd < 0) { ksft_test_result_skip("Test %s open() file failed\n", __func__); return; diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c index 856662d2f87a..6c988bd2f335 100644 --- a/tools/testing/selftests/mm/split_huge_page_test.c +++ b/tools/testing/selftests/mm/split_huge_page_test.c @@ -223,7 +223,7 @@ void split_file_backed_thp(void) ksft_exit_fail_msg("Fail to create file-backed THP split testing file\n"); } - fd = open(testfile, O_CREAT|O_WRONLY); + fd = open(testfile, O_CREAT|O_WRONLY, 0664); if (fd == -1) { ksft_perror("Cannot open testing file"); goto cleanup;
Add missing flags argument to open(2) call with O_CREAT. Some tests fail to compile if _FORTIFY_SOURCE is defined (to any valid value) (together with -O), resulting in similar error messages such as: In file included from /usr/include/fcntl.h:342, from gup_test.c:1: In function 'open', inlined from 'main' at gup_test.c:206:10: /usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments 50 | __open_missing_mode (); | ^~~~~~~~~~~~~~~~~~~~~~ _FORTIFY_SOURCE is enabled by default in some distributions, so the tests are not built by default and are skipped. open(2) man-page warns about missing flags argument: "if it is not supplied, some arbitrary bytes from the stack will be applied as the file mode." Fixes: aeb85ed4f41a ("tools/testing/selftests/vm/gup_benchmark.c: allow user specified file") Fixes: fbe37501b252 ("mm: huge_memory: debugfs for file-backed THP split") Fixes: c942f5bd17b3 ("selftests: soft-dirty: add test for mprotect") Cc: Keith Busch <kbusch@kernel.org> Cc: Zi Yan <ziy@nvidia.com> Cc: Peter Xu <peterx@redhat.com> Cc: Yang Shi <shy828301@gmail.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Cc: Nadav Amit <nadav.amit@gmail.com> Cc: David Hildenbrand <david@redhat.com> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Vitaly Chikunov <vt@altlinux.org> --- tools/testing/selftests/mm/gup_test.c | 2 +- tools/testing/selftests/mm/soft-dirty.c | 2 +- tools/testing/selftests/mm/split_huge_page_test.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)