| Message ID | 20240318-revert-select-drm_kms_helper-for-drm_panel_bridge-v1-1-52a42a116286@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE" | expand |
On Mon, Mar 18, 2024 at 03:16:21PM +0100, Neil Armstrong wrote: >This reverts commit e3f18b0dd1db242791afbc3bd173026163ce0ccc. > >Selecting DRM_KMS_HELPER for DRM_PANEL_BRIDGE leads to: >WARNING: unmet direct dependencies detected for DRM_KMS_HELPER > Depends on [m]: HAS_IOMEM [=y] && DRM [=m] > ... > >and builds with CONFIG_DRM=m will fail with the above kconfig >warns and then multiple linker error. > >Reported-by: Imre Deak <imre.deak@intel.com> >Reported-by: Jani Nikula <jani.nikula@linux.intel.com> >Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com> >Fixes: e3f18b0dd1db ("drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE") >Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Acked-by: Lucas De Marchi <lucas.demarchi@intel.com> Lucas De Marchi
On Mon, 18 Mar 2024, Neil Armstrong <neil.armstrong@linaro.org> wrote: > This reverts commit e3f18b0dd1db242791afbc3bd173026163ce0ccc. > > Selecting DRM_KMS_HELPER for DRM_PANEL_BRIDGE leads to: > WARNING: unmet direct dependencies detected for DRM_KMS_HELPER > Depends on [m]: HAS_IOMEM [=y] && DRM [=m] > ... > > and builds with CONFIG_DRM=m will fail with the above kconfig > warns and then multiple linker error. > > Reported-by: Imre Deak <imre.deak@intel.com> > Reported-by: Jani Nikula <jani.nikula@linux.intel.com> > Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Fixes: e3f18b0dd1db ("drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE") > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Acked-by: Jani Nikula <jani.nikula@intel.com> Tested-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/bridge/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 1d4f010af97b..efd996f6c138 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -8,7 +8,6 @@ config DRM_BRIDGE > config DRM_PANEL_BRIDGE > def_bool y > depends on DRM_BRIDGE > - select DRM_KMS_HELPER > select DRM_PANEL > help > DRM bridge wrapper of DRM panels > > --- > base-commit: e3f18b0dd1db242791afbc3bd173026163ce0ccc > change-id: 20240318-revert-select-drm_kms_helper-for-drm_panel_bridge-0e4ad7c73496 > > Best regards,
Hi, On Mon, 18 Mar 2024 15:16:21 +0100, Neil Armstrong wrote: > This reverts commit e3f18b0dd1db242791afbc3bd173026163ce0ccc. > > Selecting DRM_KMS_HELPER for DRM_PANEL_BRIDGE leads to: > WARNING: unmet direct dependencies detected for DRM_KMS_HELPER > Depends on [m]: HAS_IOMEM [=y] && DRM [=m] > ... > > [...] Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes) [1/1] Revert "drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE" https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/dbd9698830ebafcb6f3be6498fd4a6968dcbf89a
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 1d4f010af97b..efd996f6c138 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -8,7 +8,6 @@ config DRM_BRIDGE config DRM_PANEL_BRIDGE def_bool y depends on DRM_BRIDGE - select DRM_KMS_HELPER select DRM_PANEL help DRM bridge wrapper of DRM panels
This reverts commit e3f18b0dd1db242791afbc3bd173026163ce0ccc. Selecting DRM_KMS_HELPER for DRM_PANEL_BRIDGE leads to: WARNING: unmet direct dependencies detected for DRM_KMS_HELPER Depends on [m]: HAS_IOMEM [=y] && DRM [=m] ... and builds with CONFIG_DRM=m will fail with the above kconfig warns and then multiple linker error. Reported-by: Imre Deak <imre.deak@intel.com> Reported-by: Jani Nikula <jani.nikula@linux.intel.com> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Fixes: e3f18b0dd1db ("drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE") Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- drivers/gpu/drm/bridge/Kconfig | 1 - 1 file changed, 1 deletion(-) --- base-commit: e3f18b0dd1db242791afbc3bd173026163ce0ccc change-id: 20240318-revert-select-drm_kms_helper-for-drm_panel_bridge-0e4ad7c73496 Best regards,