| Message ID | mvmy1aegrhm.fsf@suse.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dd33e5dc7247041b565014f66286c9566b0e32b6 |
| Headers | show |
| Series | [v2] riscv: use KERN_INFO in do_trap | expand |
On 3/19/24 08:40, Andreas Schwab wrote: > Print the instruction dump with info instead of emergency level. The > unhandled signal message is only for informational purpose. > > Fixes: b8a03a634129 ("riscv: add userland instruction dump to RISC-V splats") > Signed-off-by: Andreas Schwab <schwab@suse.de> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > --- > v2: clarify commit message > --- > arch/riscv/kernel/traps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c > index a1b9be3c4332..142f5f5168fb 100644 > --- a/arch/riscv/kernel/traps.c > +++ b/arch/riscv/kernel/traps.c > @@ -121,7 +121,7 @@ void do_trap(struct pt_regs *regs, int signo, int code, unsigned long addr) > print_vma_addr(KERN_CONT " in ", instruction_pointer(regs)); > pr_cont("\n"); > __show_regs(regs); > - dump_instr(KERN_EMERG, regs); > + dump_instr(KERN_INFO, regs); > } > > force_sig_fault(signo, code, (void __user *)addr); Reviewed-by: Atish Patra <atishp@rivosinc.com>
Hi Andreas, On Tue, Mar 19, 2024 at 11:40 PM Andreas Schwab <schwab@suse.de> wrote: > > Print the instruction dump with info instead of emergency level. The > unhandled signal message is only for informational purpose. > > Fixes: b8a03a634129 ("riscv: add userland instruction dump to RISC-V splats") > Signed-off-by: Andreas Schwab <schwab@suse.de> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > --- > v2: clarify commit message > --- > arch/riscv/kernel/traps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c > index a1b9be3c4332..142f5f5168fb 100644 > --- a/arch/riscv/kernel/traps.c > +++ b/arch/riscv/kernel/traps.c > @@ -121,7 +121,7 @@ void do_trap(struct pt_regs *regs, int signo, int code, unsigned long addr) > print_vma_addr(KERN_CONT " in ", instruction_pointer(regs)); > pr_cont("\n"); > __show_regs(regs); > - dump_instr(KERN_EMERG, regs); > + dump_instr(KERN_INFO, regs); > } > > force_sig_fault(signo, code, (void __user *)addr); > -- > 2.44.0 > > > -- > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 > "And now for something completely different." Reviewed-by: Yunhui Cui <cuiyunhui@bytedance.com> Thanks, Yunhui
Ping!
On Thu, 04 Apr 2024 06:41:46 PDT (-0700), schwab@suse.de wrote:
> Ping!
Sorry I missed this, I just put it in the queue for the tester. Unless
something blows up it should show up soon.
Hello: This patch was applied to riscv/linux.git (fixes) by Palmer Dabbelt <palmer@rivosinc.com>: On Tue, 19 Mar 2024 16:40:05 +0100 you wrote: > Print the instruction dump with info instead of emergency level. The > unhandled signal message is only for informational purpose. > > Fixes: b8a03a634129 ("riscv: add userland instruction dump to RISC-V splats") > Signed-off-by: Andreas Schwab <schwab@suse.de> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > [...] Here is the summary with links: - [v2] riscv: use KERN_INFO in do_trap https://git.kernel.org/riscv/c/dd33e5dc7247 You are awesome, thank you!
diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c index a1b9be3c4332..142f5f5168fb 100644 --- a/arch/riscv/kernel/traps.c +++ b/arch/riscv/kernel/traps.c @@ -121,7 +121,7 @@ void do_trap(struct pt_regs *regs, int signo, int code, unsigned long addr) print_vma_addr(KERN_CONT " in ", instruction_pointer(regs)); pr_cont("\n"); __show_regs(regs); - dump_instr(KERN_EMERG, regs); + dump_instr(KERN_INFO, regs); } force_sig_fault(signo, code, (void __user *)addr);
Print the instruction dump with info instead of emergency level. The unhandled signal message is only for informational purpose. Fixes: b8a03a634129 ("riscv: add userland instruction dump to RISC-V splats") Signed-off-by: Andreas Schwab <schwab@suse.de> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> --- v2: clarify commit message --- arch/riscv/kernel/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)