| Message ID | 20240319151509.8937-1-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [XEN] docs/parse-support-md: Handle BulletList | expand |
Hi Anthony, On 19/03/2024 15:15, Anthony PERARD wrote: > Commit d638e304f13a introduced a bullet list, but parse-support-md > choke on it as it doesn't know what to do about it. > > Introduce ri_BulletList() so that r_content() will find this new > function and call it instead of calling process_unknown(). > > Reported-by: Julien Grall <julien@xen.org> > Fixes: d638e304f13a ("SUPPORT.MD: Fix matrix generation after 43c416d0d819 and 77c39a53cf5b") > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> My Perl knowledge is rubbish. But I tested the fix. So: Tested-by: Julien Grall <jgrall@amazon.com> Acked-by: Julien Grall <jgrall@amazon.com> Cheers, > --- > docs/parse-support-md | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/docs/parse-support-md b/docs/parse-support-md > index a397637639..b04f62da37 100755 > --- a/docs/parse-support-md > +++ b/docs/parse-support-md > @@ -218,6 +218,13 @@ sub ri_DefinitionList { > } > } > > +sub ri_BulletList { > + # Assume a paragraph introduce this bullet list, which would mean that > + # ri_Para() has already been called, and there's nothing else to do about > + # the caveat. > + return; > +} > + > sub process_unknown { > my ($c, $e) = @_; > $had_unknown = Dumper($e);
On 19/03/2024 17:45, Julien Grall wrote: > Hi Anthony, > > On 19/03/2024 15:15, Anthony PERARD wrote: >> Commit d638e304f13a introduced a bullet list, but parse-support-md >> choke on it as it doesn't know what to do about it. >> >> Introduce ri_BulletList() so that r_content() will find this new >> function and call it instead of calling process_unknown(). >> >> Reported-by: Julien Grall <julien@xen.org> >> Fixes: d638e304f13a ("SUPPORT.MD: Fix matrix generation after >> 43c416d0d819 and 77c39a53cf5b") >> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> > > My Perl knowledge is rubbish. But I tested the fix. So: > > Tested-by: Julien Grall <jgrall@amazon.com> > Acked-by: Julien Grall <jgrall@amazon.com> And committed. Cheers, > > Cheers, > >> --- >> docs/parse-support-md | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/docs/parse-support-md b/docs/parse-support-md >> index a397637639..b04f62da37 100755 >> --- a/docs/parse-support-md >> +++ b/docs/parse-support-md >> @@ -218,6 +218,13 @@ sub ri_DefinitionList { >> } >> } >> +sub ri_BulletList { >> + # Assume a paragraph introduce this bullet list, which would mean >> that >> + # ri_Para() has already been called, and there's nothing else to >> do about >> + # the caveat. >> + return; >> +} >> + >> sub process_unknown { >> my ($c, $e) = @_; >> $had_unknown = Dumper($e); >
diff --git a/docs/parse-support-md b/docs/parse-support-md index a397637639..b04f62da37 100755 --- a/docs/parse-support-md +++ b/docs/parse-support-md @@ -218,6 +218,13 @@ sub ri_DefinitionList { } } +sub ri_BulletList { + # Assume a paragraph introduce this bullet list, which would mean that + # ri_Para() has already been called, and there's nothing else to do about + # the caveat. + return; +} + sub process_unknown { my ($c, $e) = @_; $had_unknown = Dumper($e);
Commit d638e304f13a introduced a bullet list, but parse-support-md choke on it as it doesn't know what to do about it. Introduce ri_BulletList() so that r_content() will find this new function and call it instead of calling process_unknown(). Reported-by: Julien Grall <julien@xen.org> Fixes: d638e304f13a ("SUPPORT.MD: Fix matrix generation after 43c416d0d819 and 77c39a53cf5b") Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- docs/parse-support-md | 7 +++++++ 1 file changed, 7 insertions(+)