| Message ID | 20240320072709.1043227-3-max.chou@sifive.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/riscv: rvv: Check single width operator for vector fp widen instructions | expand |
On 3/20/24 04:25, Max Chou wrote: > The require_scale_rvf function only checks the double width operator for > the vector floating point widen instructions, so most of the widen > checking functions need to add require_rvf for single width operator. > > The vfwcvt.f.x.v and vfwcvt.f.xu.v instructions convert single width > integer to double width float, so the opfxv_widen_check function doesn’t > need require_rvf for the single width operator(integer). > > Signed-off-by: Max Chou <max.chou@sifive.com> > --- Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > target/riscv/insn_trans/trans_rvv.c.inc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/target/riscv/insn_trans/trans_rvv.c.inc > index ef568e263d..6cb9bc9fde 100644 > --- a/target/riscv/insn_trans/trans_rvv.c.inc > +++ b/target/riscv/insn_trans/trans_rvv.c.inc > @@ -2331,6 +2331,7 @@ GEN_OPFVF_TRANS(vfrsub_vf, opfvf_check) > static bool opfvv_widen_check(DisasContext *s, arg_rmrr *a) > { > return require_rvv(s) && > + require_rvf(s) && > require_scale_rvf(s) && > (s->sew != MO_8) && > vext_check_isa_ill(s) && > @@ -2370,6 +2371,7 @@ GEN_OPFVV_WIDEN_TRANS(vfwsub_vv, opfvv_widen_check) > static bool opfvf_widen_check(DisasContext *s, arg_rmrr *a) > { > return require_rvv(s) && > + require_rvf(s) && > require_scale_rvf(s) && > (s->sew != MO_8) && > vext_check_isa_ill(s) && > @@ -2402,6 +2404,7 @@ GEN_OPFVF_WIDEN_TRANS(vfwsub_vf) > static bool opfwv_widen_check(DisasContext *s, arg_rmrr *a) > { > return require_rvv(s) && > + require_rvf(s) && > require_scale_rvf(s) && > (s->sew != MO_8) && > vext_check_isa_ill(s) && > @@ -2441,6 +2444,7 @@ GEN_OPFWV_WIDEN_TRANS(vfwsub_wv) > static bool opfwf_widen_check(DisasContext *s, arg_rmrr *a) > { > return require_rvv(s) && > + require_rvf(s) && > require_scale_rvf(s) && > (s->sew != MO_8) && > vext_check_isa_ill(s) && > @@ -2941,6 +2945,7 @@ GEN_OPFVV_TRANS(vfredmin_vs, freduction_check) > static bool freduction_widen_check(DisasContext *s, arg_rmrr *a) > { > return reduction_widen_check(s, a) && > + require_rvf(s) && > require_scale_rvf(s) && > (s->sew != MO_8); > }
diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/target/riscv/insn_trans/trans_rvv.c.inc index ef568e263d..6cb9bc9fde 100644 --- a/target/riscv/insn_trans/trans_rvv.c.inc +++ b/target/riscv/insn_trans/trans_rvv.c.inc @@ -2331,6 +2331,7 @@ GEN_OPFVF_TRANS(vfrsub_vf, opfvf_check) static bool opfvv_widen_check(DisasContext *s, arg_rmrr *a) { return require_rvv(s) && + require_rvf(s) && require_scale_rvf(s) && (s->sew != MO_8) && vext_check_isa_ill(s) && @@ -2370,6 +2371,7 @@ GEN_OPFVV_WIDEN_TRANS(vfwsub_vv, opfvv_widen_check) static bool opfvf_widen_check(DisasContext *s, arg_rmrr *a) { return require_rvv(s) && + require_rvf(s) && require_scale_rvf(s) && (s->sew != MO_8) && vext_check_isa_ill(s) && @@ -2402,6 +2404,7 @@ GEN_OPFVF_WIDEN_TRANS(vfwsub_vf) static bool opfwv_widen_check(DisasContext *s, arg_rmrr *a) { return require_rvv(s) && + require_rvf(s) && require_scale_rvf(s) && (s->sew != MO_8) && vext_check_isa_ill(s) && @@ -2441,6 +2444,7 @@ GEN_OPFWV_WIDEN_TRANS(vfwsub_wv) static bool opfwf_widen_check(DisasContext *s, arg_rmrr *a) { return require_rvv(s) && + require_rvf(s) && require_scale_rvf(s) && (s->sew != MO_8) && vext_check_isa_ill(s) && @@ -2941,6 +2945,7 @@ GEN_OPFVV_TRANS(vfredmin_vs, freduction_check) static bool freduction_widen_check(DisasContext *s, arg_rmrr *a) { return reduction_widen_check(s, a) && + require_rvf(s) && require_scale_rvf(s) && (s->sew != MO_8); }
The require_scale_rvf function only checks the double width operator for the vector floating point widen instructions, so most of the widen checking functions need to add require_rvf for single width operator. The vfwcvt.f.x.v and vfwcvt.f.xu.v instructions convert single width integer to double width float, so the opfxv_widen_check function doesn’t need require_rvf for the single width operator(integer). Signed-off-by: Max Chou <max.chou@sifive.com> --- target/riscv/insn_trans/trans_rvv.c.inc | 5 +++++ 1 file changed, 5 insertions(+)