mbox series

[v4,0/4] Fix a bug in configuration parsing, and improve tests and documentation

Message ID cover.1710994548.git.dsimic@manjaro.org (mailing list archive)
Headers show
Series Fix a bug in configuration parsing, and improve tests and documentation | expand

Message

Dragan Simic March 21, 2024, 4:17 a.m. UTC 
This series is an evolvement from another recent series, [1] as a result
of a decision to fix a longstanding bug in the parsing of configuration
option values, instead of documenting the status quo. [2][3]

The bufgix introduced in this series _should_ have no hidden negative
effects.  All of the configuration-related tests, both the old and the
new ones, pass with the patches applied.

In v2, this series had five patches in total, out of which the third patch
(i.e. patch 3/5) was dropped in v3. [4]  Other changes in each version are
described in each patch.

There will most probably be follow-up patches, to address the remaining
points raised during the review of this series. [5]

Link to v2: https://lore.kernel.org/git/cover.1710646998.git.dsimic@manjaro.org/T/#u
Link to v3: https://lore.kernel.org/git/cover.1710800549.git.dsimic@manjaro.org/T/#u

[1] https://lore.kernel.org/git/cover.1710258538.git.dsimic@manjaro.org/T/#u
[2] https://lore.kernel.org/git/ff7b0a2ead90ad9a9456141da5e4df4a@manjaro.org/
[3] https://lore.kernel.org/git/11be11f231f3bf41d0245c780c20693f@manjaro.org/
[4] https://lore.kernel.org/git/514d832b0399ccdbc354675068477fea@manjaro.org/
[5] https://lore.kernel.org/git/f37d753485094a3ba66fde5e85d0e2dc@manjaro.org/

Dragan Simic (4):
  config: minor addition of whitespace
  config: really keep value-internal whitespace verbatim
  t1300: add more tests for whitespace and inline comments
  config.txt: describe handling of whitespace further

 Documentation/config.txt |  21 ++++----
 config.c                 |  15 ++++--
 t/t1300-config.sh        | 114 +++++++++++++++++++++++++++++++++++++--
 3 files changed, 133 insertions(+), 17 deletions(-)

Comments

Eric Sunshine March 21, 2024, 4:50 a.m. UTC | #1 
On Thu, Mar 21, 2024 at 12:17 AM Dragan Simic <dsimic@manjaro.org> wrote:
> In v2, this series had five patches in total, out of which the third patch
> (i.e. patch 3/5) was dropped in v3. [4]  Other changes in each version are
> described in each patch.

In addition to a written description of the changes since the previous
version, reviewers also greatly appreciate seeing a range-diff which
you can generate automatically in the cover-letter via:

   git format-patch --cover-letter --range-diff=<...> ...

or less frequently, an interdiff via:

    git format-patch --cover-letter --interdiff=<...> ...

Both options (--range-diff & --interdiff) also work for single-patch
series which lack a cover-letter.
Dragan Simic March 21, 2024, 4:58 a.m. UTC | #2 
On 2024-03-21 05:50, Eric Sunshine wrote:
> On Thu, Mar 21, 2024 at 12:17 AM Dragan Simic <dsimic@manjaro.org> 
> wrote:
>> In v2, this series had five patches in total, out of which the third 
>> patch
>> (i.e. patch 3/5) was dropped in v3. [4]  Other changes in each version 
>> are
>> described in each patch.
> 
> In addition to a written description of the changes since the previous
> version, reviewers also greatly appreciate seeing a range-diff which
> you can generate automatically in the cover-letter via:
> 
>    git format-patch --cover-letter --range-diff=<...> ...
> 
> or less frequently, an interdiff via:
> 
>     git format-patch --cover-letter --interdiff=<...> ...
> 
> Both options (--range-diff & --interdiff) also work for single-patch
> series which lack a cover-letter.

I'll keep that in mind for future patches.