[v2,0/2] t9803-git-p4-shell-metachars.sh: update to use test_path_* functions

Message

Philippe Blain via GitGitGadget March 21, 2024, 8:29 p.m. UTC

Correct Typo in Branch name

Sanchit Jindal (1):
  t9803: update commit messages and description

sanchit1053 (1):
  t9803-git-p4-shell-metachars.sh: update to use test_path_* functions

 t/t9803-git-p4-shell-metachars.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)


base-commit: 3bd955d26919e149552f34aacf8a4e6368c26cec
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1691%2Fsanchit1053%2Fsj%2Ft9803_use_path_helper_fn-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1691/sanchit1053/sj/t9803_use_path_helper_fn-v2
Pull-Request: https://github.com/git/git/pull/1691

Range-diff vs v1:

 1:  b541ce7a49c = 1:  b541ce7a49c t9803-git-p4-shell-metachars.sh: update to use test_path_* functions
 2:  b8d0620d410 < -:  ----------- t9803: update commit messages and description
 -:  ----------- > 2:  e25b5f928a9 t9803: update commit messages and description

Comments

Sanchit Jindal March 21, 2024, 8:29 p.m. UTC | #1

From: Sanchit Jindal <[e-mail]>

Using the `test` function directly does not provide any
diagnostic information to the user, in case of a failure.

This patch replace the `test` function with the helper functions
defined that will call the corresponding test function and log an
error message if the assert fails

Making the replacements
- `test -e` -> test_path_exists,
- `test ! -e` -> test_path_is_missing
- `test -f` -> test_path_is_file

Signed-off-by: Sanchit Jindal <[e-mail]>