| Message ID | 0ee190df1d882d826faeeee28a000b06eacf6034.1710836407.git.perry.yuan@amd.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | AMD Pstate Fixes And Enhancements | expand |
[AMD Official Use Only - General] > -----Original Message----- > From: Yuan, Perry <Perry.Yuan@amd.com> > Sent: Tuesday, March 19, 2024 4:29 PM > To: rafael.j.wysocki@intel.com; Limonciello, Mario > <Mario.Limonciello@amd.com>; viresh.kumar@linaro.org; Shenoy, Gautham > Ranjal <gautham.shenoy@amd.com>; Petkov, Borislav > <Borislav.Petkov@amd.com>; Huang, Ray <Ray.Huang@amd.com> > Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Shimmer > <Shimmer.Huang@amd.com>; oleksandr@natalenko.name; Du, Xiaojian > <Xiaojian.Du@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; linux- > pm@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH v9 2/8] cpufreq: amd-pstate: Document the units for freq > variables in amd_cpudata > > From: "Gautham R. Shenoy" <gautham.shenoy@amd.com> > > The min_limit_freq, max_limit_freq, min_freq, max_freq, nominal_freq and > the lowest_nominal_freq members of struct cpudata store the frequency > value in khz to be consistent with the cpufreq core. Update the comment to > document this. > > Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com> > Signed-off-by: Perry Yuan <perry.yuan@amd.com> > --- > include/linux/amd-pstate.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index > 212f377d615b..ab7e82533718 100644 > --- a/include/linux/amd-pstate.h > +++ b/include/linux/amd-pstate.h > @@ -51,15 +51,15 @@ struct amd_aperf_mperf { > * priority. > * @min_limit_perf: Cached value of the perf corresponding to policy->min > * @max_limit_perf: Cached value of the perf corresponding to policy->max > - * @min_limit_freq: Cached value of policy->min > - * @max_limit_freq: Cached value of policy->max > - * @max_freq: the frequency that mapped to highest_perf > - * @min_freq: the frequency that mapped to lowest_perf > - * @nominal_freq: the frequency that mapped to nominal_perf > - * @lowest_nonlinear_freq: the frequency that mapped to > lowest_nonlinear_perf > + * @min_limit_freq: Cached value of policy->min (in khz) > + * @max_limit_freq: Cached value of policy->max (in khz) > + * @max_freq: the frequency (in khz) that mapped to highest_perf > + * @min_freq: the frequency (in khz) that mapped to lowest_perf > + * @nominal_freq: the frequency (in khz) that mapped to nominal_perf > + * @lowest_nonlinear_freq: the frequency (in khz) that mapped to > + lowest_nonlinear_perf > * @cur: Difference of Aperf/Mperf/tsc count between last and current > sample > * @prev: Last Aperf/Mperf/tsc count value read from register > - * @freq: current cpu frequency value > + * @freq: current cpu frequency value (in khz) > * @boost_supported: check whether the Processor or SBIOS supports > boost mode > * @hw_prefcore: check whether HW supports preferred core featue. > * Only when hw_prefcore and early prefcore param are true, > -- > 2.34.1 [Meng, Li (Jassmine)] Reviewed-by: Li Meng < li.meng@amd.com>
diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index 212f377d615b..ab7e82533718 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -51,15 +51,15 @@ struct amd_aperf_mperf { * priority. * @min_limit_perf: Cached value of the perf corresponding to policy->min * @max_limit_perf: Cached value of the perf corresponding to policy->max - * @min_limit_freq: Cached value of policy->min - * @max_limit_freq: Cached value of policy->max - * @max_freq: the frequency that mapped to highest_perf - * @min_freq: the frequency that mapped to lowest_perf - * @nominal_freq: the frequency that mapped to nominal_perf - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf + * @min_limit_freq: Cached value of policy->min (in khz) + * @max_limit_freq: Cached value of policy->max (in khz) + * @max_freq: the frequency (in khz) that mapped to highest_perf + * @min_freq: the frequency (in khz) that mapped to lowest_perf + * @nominal_freq: the frequency (in khz) that mapped to nominal_perf + * @lowest_nonlinear_freq: the frequency (in khz) that mapped to lowest_nonlinear_perf * @cur: Difference of Aperf/Mperf/tsc count between last and current sample * @prev: Last Aperf/Mperf/tsc count value read from register - * @freq: current cpu frequency value + * @freq: current cpu frequency value (in khz) * @boost_supported: check whether the Processor or SBIOS supports boost mode * @hw_prefcore: check whether HW supports preferred core featue. * Only when hw_prefcore and early prefcore param are true,