diff mbox series

[v4,3/5] dt-bindings: serial: renesas,scif: Make 'interrupt-names' property as required

Message ID 20240322144355.878930-4-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series Add SCIF support for Renesas RZ/V2H(P) SoC | expand

Commit Message

Lad, Prabhakar March 22, 2024, 2:43 p.m. UTC 
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

As all the SoCs having multiple interrupts have 'interrupt-names' property
in their respective DTSIs, make 'interrupt-names' property as required
so that we can validate them using dtbs_check.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v3->v4
- New patch

Note, we need patch [0] to be applied or else we might see
dtbs_check warning.

[0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240318174345.46824-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
---
 Documentation/devicetree/bindings/serial/renesas,scif.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Conor Dooley March 22, 2024, 6:40 p.m. UTC | #1 
On Fri, Mar 22, 2024 at 02:43:53PM +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> As all the SoCs having multiple interrupts have 'interrupt-names' property
> in their respective DTSIs, make 'interrupt-names' property as required
> so that we can validate them using dtbs_check.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Provided drivers will still work with the old devicetrees that
didn't have names for everything:
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
> v3->v4
> - New patch
> 
> Note, we need patch [0] to be applied or else we might see
> dtbs_check warning.
> 
> [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240318174345.46824-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
> ---
>  Documentation/devicetree/bindings/serial/renesas,scif.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> index eb2aa5e75e02..c13b31c28049 100644
> --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> @@ -179,6 +179,9 @@ allOf:
>            maxItems: 1
>  
>          interrupt-names: false
> +    else:
> +      required:
> +        - interrupt-names
>  
>    - if:
>        properties:
> -- 
> 2.34.1
>
Geert Uytterhoeven April 17, 2024, 2:51 p.m. UTC | #2 
On Fri, Mar 22, 2024 at 3:45 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> As all the SoCs having multiple interrupts have 'interrupt-names' property
> in their respective DTSIs, make 'interrupt-names' property as required
> so that we can validate them using dtbs_check.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v3->v4
> - New patch

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> Note, we need patch [0] to be applied or else we might see
> dtbs_check warning.
>
> [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240318174345.46824-1-prabhakar.mahadev-lad.rj@bp.renesas.com/

That is commit 7db74b65a93bac5a ("ARM: dts: renesas: r7s72100:
Add interrupt-names to SCIF nodes") in renesas-dts-for-v6.10
(next-20240327 and later).

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
index eb2aa5e75e02..c13b31c28049 100644
--- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
@@ -179,6 +179,9 @@  allOf:
           maxItems: 1
 
         interrupt-names: false
+    else:
+      required:
+        - interrupt-names
 
   - if:
       properties: