| Message ID | 20240322144355.878930-3-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add SCIF support for Renesas RZ/V2H(P) SoC | expand |
On Fri, Mar 22, 2024 at 02:43:52PM +0000, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > This commit adds support to validate the 'interrupts' and 'interrupt-names' > properties for every supported SoC. This ensures proper handling and > configuration of interrupt-related properties across supported platforms. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v3->v4 > - Reverted back to v2 version of the patch. > - Used suggestion from Krzysztof for interrupts It seems fine to me, but maybe Krzysztof wants to take another look. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
Hi Prabhakar, > -----Original Message----- > From: Prabhakar <prabhakar.csengg@gmail.com> > Sent: Friday, March 22, 2024 2:44 PM > Subject: [PATCH v4 2/5] dt-bindings: serial: renesas,scif: Validate 'interrupts' and 'interrupt- > names' > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > This commit adds support to validate the 'interrupts' and 'interrupt-names' > properties for every supported SoC. This ensures proper handling and configuration of interrupt- > related properties across supported platforms. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v3->v4 > - Reverted back to v2 version of the patch. > - Used suggestion from Krzysztof for interrupts > - Restored RB tag from Geert > > v2->v3 > - Listed interrupts and interrupt-names for every SoC in if check > --- > .../bindings/serial/renesas,scif.yaml | 73 ++++++++++++++----- > 1 file changed, 55 insertions(+), 18 deletions(-) > > diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > index af72c3420453..eb2aa5e75e02 100644 > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > @@ -86,11 +86,6 @@ properties: > oneOf: > - items: > - description: A combined interrupt > - - items: > - - description: Error interrupt > - - description: Receive buffer full interrupt > - - description: Transmit buffer empty interrupt > - - description: Break interrupt > - items: > - description: Error interrupt > - description: Receive buffer full interrupt @@ -98,21 +93,17 @@ properties: > - description: Break interrupt > - description: Data Ready interrupt > - description: Transmit End interrupt > + minItems: 4 I think here minItems is 1 as it is either 1 or 4 or 6 Cheers, Biju > > interrupt-names: > - oneOf: > - - items: > - - const: eri > - - const: rxi > - - const: txi > - - const: bri > - - items: > - - const: eri > - - const: rxi > - - const: txi > - - const: bri > - - const: dri > - - const: tei > + minItems: 4 > + items: > + - const: eri > + - const: rxi > + - const: txi > + - const: bri > + - const: dri > + - const: tei > > clocks: > minItems: 1 > @@ -173,6 +164,52 @@ allOf: > required: > - resets > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,rcar-gen1-scif > + - renesas,rcar-gen2-scif > + - renesas,rcar-gen3-scif > + - renesas,rcar-gen4-scif > + then: > + properties: > + interrupts: > + maxItems: 1 > + > + interrupt-names: false > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,scif-r7s72100 > + then: > + properties: > + interrupts: > + minItems: 4 > + maxItems: 4 > + > + interrupt-names: > + maxItems: 4 > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,scif-r7s9210 > + - renesas,scif-r9a07g044 > + then: > + properties: > + interrupts: > + minItems: 6 > + > + interrupt-names: > + minItems: 6 > + > unevaluatedProperties: false > > examples: > -- > 2.34.1 >
Hi Biju, On Mon, Mar 25, 2024 at 5:21 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > -----Original Message----- > > From: Prabhakar <prabhakar.csengg@gmail.com> > > Sent: Friday, March 22, 2024 2:44 PM > > Subject: [PATCH v4 2/5] dt-bindings: serial: renesas,scif: Validate 'interrupts' and 'interrupt- > > names' > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > This commit adds support to validate the 'interrupts' and 'interrupt-names' > > properties for every supported SoC. This ensures proper handling and configuration of interrupt- > > related properties across supported platforms. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > v3->v4 > > - Reverted back to v2 version of the patch. > > - Used suggestion from Krzysztof for interrupts > > - Restored RB tag from Geert > > > > v2->v3 > > - Listed interrupts and interrupt-names for every SoC in if check > > --- > > .../bindings/serial/renesas,scif.yaml | 73 ++++++++++++++----- > > 1 file changed, 55 insertions(+), 18 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > index af72c3420453..eb2aa5e75e02 100644 > > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > @@ -86,11 +86,6 @@ properties: > > oneOf: > > - items: > > - description: A combined interrupt > > - - items: > > - - description: Error interrupt > > - - description: Receive buffer full interrupt > > - - description: Transmit buffer empty interrupt > > - - description: Break interrupt > > - items: > > - description: Error interrupt > > - description: Receive buffer full interrupt @@ -98,21 +93,17 @@ properties: > > - description: Break interrupt > > - description: Data Ready interrupt > > - description: Transmit End interrupt > > + minItems: 4 > > I think here minItems is 1 as it is either 1 or 4 or 6 The single interrupt is handled by the first case in the oneOf (which can probably be simplified by dropping the "items"?). Gr{oetje,eeting}s, Geert
Hi Geert, > -----Original Message----- > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: Tuesday, March 26, 2024 8:02 AM > Subject: Re: [PATCH v4 2/5] dt-bindings: serial: renesas,scif: Validate 'interrupts' and > 'interrupt-names' > > Hi Biju, > > On Mon, Mar 25, 2024 at 5:21 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > > -----Original Message----- > > > From: Prabhakar <prabhakar.csengg@gmail.com> > > > Sent: Friday, March 22, 2024 2:44 PM > > > Subject: [PATCH v4 2/5] dt-bindings: serial: renesas,scif: Validate > > > 'interrupts' and 'interrupt- names' > > > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > This commit adds support to validate the 'interrupts' and 'interrupt-names' > > > properties for every supported SoC. This ensures proper handling and > > > configuration of interrupt- related properties across supported platforms. > > > > > > Signed-off-by: Lad Prabhakar > > > <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- > > > v3->v4 > > > - Reverted back to v2 version of the patch. > > > - Used suggestion from Krzysztof for interrupts > > > - Restored RB tag from Geert > > > > > > v2->v3 > > > - Listed interrupts and interrupt-names for every SoC in if check > > > --- > > > .../bindings/serial/renesas,scif.yaml | 73 ++++++++++++++----- > > > 1 file changed, 55 insertions(+), 18 deletions(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > index af72c3420453..eb2aa5e75e02 100644 > > > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > @@ -86,11 +86,6 @@ properties: > > > oneOf: > > > - items: > > > - description: A combined interrupt > > > - - items: > > > - - description: Error interrupt > > > - - description: Receive buffer full interrupt > > > - - description: Transmit buffer empty interrupt > > > - - description: Break interrupt > > > - items: > > > - description: Error interrupt > > > - description: Receive buffer full interrupt @@ -98,21 +93,17 @@ properties: > > > - description: Break interrupt > > > - description: Data Ready interrupt > > > - description: Transmit End interrupt > > > + minItems: 4 > > > > I think here minItems is 1 as it is either 1 or 4 or 6 > > The single interrupt is handled by the first case in the oneOf (which can probably be simplified by > dropping the "items"?). Good point, it is not items, so it can be dropped. Cheers, Biju
Hi Biju, On Mon, Mar 25, 2024 at 4:21 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Hi Prabhakar, > > > -----Original Message----- > > From: Prabhakar <prabhakar.csengg@gmail.com> > > Sent: Friday, March 22, 2024 2:44 PM > > Subject: [PATCH v4 2/5] dt-bindings: serial: renesas,scif: Validate 'interrupts' and 'interrupt- > > names' > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > This commit adds support to validate the 'interrupts' and 'interrupt-names' > > properties for every supported SoC. This ensures proper handling and configuration of interrupt- > > related properties across supported platforms. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > v3->v4 > > - Reverted back to v2 version of the patch. > > - Used suggestion from Krzysztof for interrupts > > - Restored RB tag from Geert > > > > v2->v3 > > - Listed interrupts and interrupt-names for every SoC in if check > > --- > > .../bindings/serial/renesas,scif.yaml | 73 ++++++++++++++----- > > 1 file changed, 55 insertions(+), 18 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > index af72c3420453..eb2aa5e75e02 100644 > > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > @@ -86,11 +86,6 @@ properties: > > oneOf: > > - items: > > - description: A combined interrupt > > - - items: > > - - description: Error interrupt > > - - description: Receive buffer full interrupt > > - - description: Transmit buffer empty interrupt > > - - description: Break interrupt > > - items: > > - description: Error interrupt > > - description: Receive buffer full interrupt @@ -98,21 +93,17 @@ properties: > > - description: Break interrupt > > - description: Data Ready interrupt > > - description: Transmit End interrupt > > + minItems: 4 > > I think here minItems is 1 as it is either 1 or 4 or 6 > minItems 1 case is already handled above. Cheers, Prabhakar
Hi Geert, On Tue, Mar 26, 2024 at 8:02 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Biju, > > On Mon, Mar 25, 2024 at 5:21 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > > -----Original Message----- > > > From: Prabhakar <prabhakar.csengg@gmail.com> > > > Sent: Friday, March 22, 2024 2:44 PM > > > Subject: [PATCH v4 2/5] dt-bindings: serial: renesas,scif: Validate 'interrupts' and 'interrupt- > > > names' > > > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > This commit adds support to validate the 'interrupts' and 'interrupt-names' > > > properties for every supported SoC. This ensures proper handling and configuration of interrupt- > > > related properties across supported platforms. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- > > > v3->v4 > > > - Reverted back to v2 version of the patch. > > > - Used suggestion from Krzysztof for interrupts > > > - Restored RB tag from Geert > > > > > > v2->v3 > > > - Listed interrupts and interrupt-names for every SoC in if check > > > --- > > > .../bindings/serial/renesas,scif.yaml | 73 ++++++++++++++----- > > > 1 file changed, 55 insertions(+), 18 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > index af72c3420453..eb2aa5e75e02 100644 > > > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > @@ -86,11 +86,6 @@ properties: > > > oneOf: > > > - items: > > > - description: A combined interrupt > > > - - items: > > > - - description: Error interrupt > > > - - description: Receive buffer full interrupt > > > - - description: Transmit buffer empty interrupt > > > - - description: Break interrupt > > > - items: > > > - description: Error interrupt > > > - description: Receive buffer full interrupt @@ -98,21 +93,17 @@ properties: > > > - description: Break interrupt > > > - description: Data Ready interrupt > > > - description: Transmit End interrupt > > > + minItems: 4 > > > > I think here minItems is 1 as it is either 1 or 4 or 6 > > The single interrupt is handled by the first case in the oneOf (which > can probably be simplified by dropping the "items"?). > Agreed, I'll make this change as a separate patch or squash it here if I have to re-spin the series. Cheers, Prabhakar
Hi Prabhakar, > -----Original Message----- > From: Lad, Prabhakar <prabhakar.csengg@gmail.com> > Sent: Tuesday, March 26, 2024 8:29 AM > Subject: Re: [PATCH v4 2/5] dt-bindings: serial: renesas,scif: Validate 'interrupts' and > 'interrupt-names' > > Hi Biju, > > On Mon, Mar 25, 2024 at 4:21 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > > > Hi Prabhakar, > > > > > -----Original Message----- > > > From: Prabhakar <prabhakar.csengg@gmail.com> > > > Sent: Friday, March 22, 2024 2:44 PM > > > Subject: [PATCH v4 2/5] dt-bindings: serial: renesas,scif: Validate > > > 'interrupts' and 'interrupt- names' > > > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > This commit adds support to validate the 'interrupts' and 'interrupt-names' > > > properties for every supported SoC. This ensures proper handling and > > > configuration of interrupt- related properties across supported platforms. > > > > > > Signed-off-by: Lad Prabhakar > > > <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- > > > v3->v4 > > > - Reverted back to v2 version of the patch. > > > - Used suggestion from Krzysztof for interrupts > > > - Restored RB tag from Geert > > > > > > v2->v3 > > > - Listed interrupts and interrupt-names for every SoC in if check > > > --- > > > .../bindings/serial/renesas,scif.yaml | 73 ++++++++++++++----- > > > 1 file changed, 55 insertions(+), 18 deletions(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > index af72c3420453..eb2aa5e75e02 100644 > > > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > > @@ -86,11 +86,6 @@ properties: > > > oneOf: > > > - items: > > > - description: A combined interrupt > > > - - items: > > > - - description: Error interrupt > > > - - description: Receive buffer full interrupt > > > - - description: Transmit buffer empty interrupt > > > - - description: Break interrupt > > > - items: > > > - description: Error interrupt > > > - description: Receive buffer full interrupt @@ -98,21 +93,17 @@ properties: > > > - description: Break interrupt > > > - description: Data Ready interrupt > > > - description: Transmit End interrupt > > > + minItems: 4 > > > > I think here minItems is 1 as it is either 1 or 4 or 6 > > > minItems 1 case is already handled above. IIC, As per the above oneOf list, items{1, 4, 6} for minItems is 1. Cheers, Biju
diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml index af72c3420453..eb2aa5e75e02 100644 --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml @@ -86,11 +86,6 @@ properties: oneOf: - items: - description: A combined interrupt - - items: - - description: Error interrupt - - description: Receive buffer full interrupt - - description: Transmit buffer empty interrupt - - description: Break interrupt - items: - description: Error interrupt - description: Receive buffer full interrupt @@ -98,21 +93,17 @@ properties: - description: Break interrupt - description: Data Ready interrupt - description: Transmit End interrupt + minItems: 4 interrupt-names: - oneOf: - - items: - - const: eri - - const: rxi - - const: txi - - const: bri - - items: - - const: eri - - const: rxi - - const: txi - - const: bri - - const: dri - - const: tei + minItems: 4 + items: + - const: eri + - const: rxi + - const: txi + - const: bri + - const: dri + - const: tei clocks: minItems: 1 @@ -173,6 +164,52 @@ allOf: required: - resets + - if: + properties: + compatible: + contains: + enum: + - renesas,rcar-gen1-scif + - renesas,rcar-gen2-scif + - renesas,rcar-gen3-scif + - renesas,rcar-gen4-scif + then: + properties: + interrupts: + maxItems: 1 + + interrupt-names: false + + - if: + properties: + compatible: + contains: + enum: + - renesas,scif-r7s72100 + then: + properties: + interrupts: + minItems: 4 + maxItems: 4 + + interrupt-names: + maxItems: 4 + + - if: + properties: + compatible: + contains: + enum: + - renesas,scif-r7s9210 + - renesas,scif-r9a07g044 + then: + properties: + interrupts: + minItems: 6 + + interrupt-names: + minItems: 6 + unevaluatedProperties: false examples: