| Message ID | 20240326162305.303598-2-ericwouds@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2434ba2bc8518eafdb04852e70f5a2ba2ba1feee |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add en8811h phy driver and devicetree binding doc | expand |
On Tue, Mar 26, 2024 at 05:23:04PM +0100, Eric Woudstra wrote: > Add the Airoha EN8811H 2.5 Gigabit PHY. > > The en8811h phy can be set with serdes polarity reversed on rx and/or tx. > > Signed-off-by: Eric Woudstra <ericwouds@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Tue, Mar 26, 2024 at 05:23:04PM +0100, Eric Woudstra wrote: > Add the Airoha EN8811H 2.5 Gigabit PHY. > > The en8811h phy can be set with serdes polarity reversed on rx and/or tx. > > Signed-off-by: Eric Woudstra <ericwouds@gmail.com> Did you change something or forget to add Krzysztof's Reviewed-by? > --- > .../bindings/net/airoha,en8811h.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml
Hi Rob, On 3/26/24 20:29, Rob Herring wrote: > On Tue, Mar 26, 2024 at 05:23:04PM +0100, Eric Woudstra wrote: >> Add the Airoha EN8811H 2.5 Gigabit PHY. >> >> The en8811h phy can be set with serdes polarity reversed on rx and/or tx. >> >> Signed-off-by: Eric Woudstra <ericwouds@gmail.com> > > Did you change something or forget to add Krzysztof's Reviewed-by? Nothing has changed in this commit. I was wondering if I should do this, so I should have added the Reviewed-by Krzysztof. Best regards, Eric Woudstra
On 26/03/2024 21:41, Eric Woudstra wrote: > Hi Rob, > > On 3/26/24 20:29, Rob Herring wrote: >> On Tue, Mar 26, 2024 at 05:23:04PM +0100, Eric Woudstra wrote: >>> Add the Airoha EN8811H 2.5 Gigabit PHY. >>> >>> The en8811h phy can be set with serdes polarity reversed on rx and/or tx. >>> >>> Signed-off-by: Eric Woudstra <ericwouds@gmail.com> >> >> Did you change something or forget to add Krzysztof's Reviewed-by? > > Nothing has changed in this commit. I was wondering if I should do this, > so I should have added the Reviewed-by Krzysztof. > Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Please carefully read above guideline. Entire. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml new file mode 100644 index 000000000000..ecb5149ec6b0 --- /dev/null +++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Airoha EN8811H PHY + +maintainers: + - Eric Woudstra <ericwouds@gmail.com> + +description: + The Airoha EN8811H PHY has the ability to reverse polarity + on the lines to and/or from the MAC. It is reversed by + the booleans in the devicetree node of the phy. + +allOf: + - $ref: ethernet-phy.yaml# + +properties: + compatible: + enum: + - ethernet-phy-id03a2.a411 + + reg: + maxItems: 1 + + airoha,pnswap-rx: + type: boolean + description: + Reverse rx polarity of the SERDES. This is the receiving + side of the lines from the MAC towards the EN881H. + + airoha,pnswap-tx: + type: boolean + description: + Reverse tx polarity of SERDES. This is the transmitting + side of the lines from EN8811H towards the MAC. + +required: + - reg + +unevaluatedProperties: false + +examples: + - | + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethernet-phy@1 { + compatible = "ethernet-phy-id03a2.a411"; + reg = <1>; + airoha,pnswap-rx; + }; + };
Add the Airoha EN8811H 2.5 Gigabit PHY. The en8811h phy can be set with serdes polarity reversed on rx and/or tx. Signed-off-by: Eric Woudstra <ericwouds@gmail.com> --- .../bindings/net/airoha,en8811h.yaml | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml