Message ID | 20240326-ep93xx-v9-0-156e2ae5dfc8@maquefel.me (mailing list archive) |
---|---|
Headers | show |
Series | ep93xx device tree conversion | expand |
On Tue, Mar 26, 2024, at 10:18, Nikita Shubin via B4 Relay wrote: > The goal is to recieve ACKs for all patches in series to merge it via > Arnd branch. Thank you for the continued updates, I really hope we can merge it all for 6.10. I've looked through it again and I'm pretty much ready to just merge it, though I admit that the process is not working out that great, and it would probably have been quicker to add DT support to drivers individually through the subsystem trees. > Stephen Boyd, Vinod Koul PLEASE! give some comments on following, couse > i hadn't one for a couple of iterations already: > > Following patches require attention from Stephen Boyd, as they were > converted to aux_dev as suggested: > > - ARM: ep93xx: add regmap aux_dev > - clk: ep93xx: add DT support for Cirrus EP93xx > > Following patches require attention from Vinod Koul: > > - dma: cirrus: Convert to DT for Cirrus EP93xx > - dma: cirrus: remove platform code I suspect that Stephen and Vinod may be missing this, as reviewing a 38 patch series tends to be a lot of work, and they may have missed that they are on the critical path here. I certainly tend to just ignore an entire thread when it looks like I'm not immediately going to be reviewing it all and other people are likely to have more comments first, so I'm not blaming them. To better catch their attention, I would suggest you repost the two smaller sets of patches as a separate series, with only the relevant people on Cc. Please also include the respective bindings when you send send these patches to Stephen and Vinod. Arnd
On 26/03/2024 10:18, Nikita Shubin via B4 Relay wrote: > The goal is to recieve ACKs for all patches in series to merge it via Arnd branch. > > Some changes since last version (v8): > > - Most important, fixed bug in Device Tree resulting in CS4271 not working by Alexander Sverdlin. > - added #interrupt-cells to gpio nodes with interrupts-controller > - fixed some EOF in dtsi files > - fixed identation and type in ep93xx-keypad thanks to Andy Shevchenko > > Stephen Boyd, Vinod Koul PLEASE! give some comments on following, couse i hadn't one for a couple of iterations already: > > Following patches require attention from Stephen Boyd, as they were converted to aux_dev as suggested: > > - ARM: ep93xx: add regmap aux_dev > - clk: ep93xx: add DT support for Cirrus EP93xx > > Following patches require attention from Vinod Koul: > > - dma: cirrus: Convert to DT for Cirrus EP93xx > - dma: cirrus: remove platform code A lot of this could have been already merged if you split it... Just saying... Best regards, Krzysztof
On Tue, Mar 26, 2024 at 11:19:54AM +0100, Krzysztof Kozlowski wrote: > On 26/03/2024 10:18, Nikita Shubin via B4 Relay wrote: > > The goal is to recieve ACKs for all patches in series to merge it via Arnd branch. > > > > Some changes since last version (v8): > > > > - Most important, fixed bug in Device Tree resulting in CS4271 not working by Alexander Sverdlin. > > - added #interrupt-cells to gpio nodes with interrupts-controller > > - fixed some EOF in dtsi files > > - fixed identation and type in ep93xx-keypad thanks to Andy Shevchenko > > > > Stephen Boyd, Vinod Koul PLEASE! give some comments on following, couse i hadn't one for a couple of iterations already: > > > > Following patches require attention from Stephen Boyd, as they were converted to aux_dev as suggested: > > > > - ARM: ep93xx: add regmap aux_dev > > - clk: ep93xx: add DT support for Cirrus EP93xx > > > > Following patches require attention from Vinod Koul: > > > > - dma: cirrus: Convert to DT for Cirrus EP93xx > > - dma: cirrus: remove platform code > > A lot of this could have been already merged if you split it... Just > saying... But you able to apply DT schema patches if you wish. Just doing? :-)
On 26/03/2024 15:49, Andy Shevchenko wrote: > On Tue, Mar 26, 2024 at 11:19:54AM +0100, Krzysztof Kozlowski wrote: >> On 26/03/2024 10:18, Nikita Shubin via B4 Relay wrote: >>> The goal is to recieve ACKs for all patches in series to merge it via Arnd branch. >>> >>> Some changes since last version (v8): >>> >>> - Most important, fixed bug in Device Tree resulting in CS4271 not working by Alexander Sverdlin. >>> - added #interrupt-cells to gpio nodes with interrupts-controller >>> - fixed some EOF in dtsi files >>> - fixed identation and type in ep93xx-keypad thanks to Andy Shevchenko >>> >>> Stephen Boyd, Vinod Koul PLEASE! give some comments on following, couse i hadn't one for a couple of iterations already: >>> >>> Following patches require attention from Stephen Boyd, as they were converted to aux_dev as suggested: >>> >>> - ARM: ep93xx: add regmap aux_dev >>> - clk: ep93xx: add DT support for Cirrus EP93xx >>> >>> Following patches require attention from Vinod Koul: >>> >>> - dma: cirrus: Convert to DT for Cirrus EP93xx >>> - dma: cirrus: remove platform code >> >> A lot of this could have been already merged if you split it... Just >> saying... > > But you able to apply DT schema patches if you wish. > Just doing? :-) Me? Why? DT bindings are supposed to go via subsystem maintainers, not DT tree. Plus, I do not apply any bindings patches, except for managed subsystems and none of them are touched here. Best regards, Krzysztof
On Wed, Mar 27, 2024 at 7:07 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 26/03/2024 15:49, Andy Shevchenko wrote: > > On Tue, Mar 26, 2024 at 11:19:54AM +0100, Krzysztof Kozlowski wrote: > >> On 26/03/2024 10:18, Nikita Shubin via B4 Relay wrote: ... > >> A lot of this could have been already merged if you split it... Just > >> saying... > > > > But you able to apply DT schema patches if you wish. > > Just doing? :-) > > Me? Why? DT bindings are supposed to go via subsystem maintainers, not > DT tree. Okay, I never remembered this rule, thank you for clarifying. > Plus, I do not apply any bindings patches, except for managed > subsystems and none of them are touched here. Good to know!
Hello Arnd, On Tue, Mar 26, 2024 at 11:07:06AM +0100, Arnd Bergmann wrote: > On Tue, Mar 26, 2024, at 10:18, Nikita Shubin via B4 Relay wrote: > > The goal is to recieve ACKs for all patches in series to merge it via > > Arnd branch. > > Thank you for the continued updates, I really hope we can merge > it all for 6.10. I've looked through it again and I'm pretty much > ready to just merge it, though I admit that the process is not > working out that great, and it would probably have been quicker > to add DT support to drivers individually through the subsystem > trees. > > > Stephen Boyd, Vinod Koul PLEASE! give some comments on following, couse > > i hadn't one for a couple of iterations already: > > > > Following patches require attention from Stephen Boyd, as they were > > converted to aux_dev as suggested: > > > > - ARM: ep93xx: add regmap aux_dev > > - clk: ep93xx: add DT support for Cirrus EP93xx > > > > Following patches require attention from Vinod Koul: > > > > - dma: cirrus: Convert to DT for Cirrus EP93xx > > - dma: cirrus: remove platform code > > I suspect that Stephen and Vinod may be missing this, as reviewing > a 38 patch series tends to be a lot of work, and they may have > missed that they are on the critical path here. I certainly > tend to just ignore an entire thread when it looks like I'm not > immediately going to be reviewing it all and other people are > likely to have more comments first, so I'm not blaming them. > > To better catch their attention, I would suggest you repost the > two smaller sets of patches as a separate series, with only the > relevant people on Cc. Please also include the respective > bindings when you send send these patches to Stephen and > Vinod. It seems this happend for the clock series; it's at https://lore.kernel.org/all/20240408-ep93xx-clk-v1-0-1d0f4c324647@maquefel.me/ and received an ack by Stephen. Vinod gave some feedback in this thread with some remarks that need addressing. With the latter I wonder if the plan to get this as a whole into v6.10 is screwed and if I should pick up the PWM bits (patches #12, #13 and maybe #38) via my tree. Patch #38 touches arch/arm and include/linux/soc, so I wouldn't pick that one up without an explicit ack by (I guess) Arnd. Best regards Uwe