| Message ID | 20240326195807.15163-1-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes | expand |
Hi, [add Peter and Ivan] Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > Hello, > > This small series includes a few drive-by fixes for DT validation > errors. > > The first patch has been posted previously in v1 ([1], and now addresses > a small review comment. I think it's good to go. > > The next two patches address the same issue as "[PATCH 1/2] dt-bindings: > arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" ([2]), > but this time with a (hopefully) correct approach. Patch 2/3 starts by > fixing the raspberrypi-bcm2835-firmware driver, removing the need for DT > properties that are specified in bcm2835-rpi.dtsi but not documented in > the corresponding bindings. Patch 3/3 can then drop those properties, > getting rid of the warnings. since this series drops properties from the device tree, does anyone have the chance to test it with a recent U-Boot? > > [1] https://lore.kernel.org/linux-arm-kernel/20240326004902.17054-3-laurent.pinchart@ideasonboard.com/ > [2] https://lore.kernel.org/linux-arm-kernel/20240326004902.17054-2-laurent.pinchart@ideasonboard.com/ > > Laurent Pinchart (3): > dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Add gpio child > node > firmware: raspberrypi: Use correct device for DMA mappings > ARM: dts: bcm283x: Drop unneeded properties in the bcm2835-firmware > node > > .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 30 +++++++++++++++++++ > .../gpio/raspberrypi,firmware-gpio.txt | 30 ------------------- > arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi | 4 --- > drivers/firmware/raspberrypi.c | 7 +++-- > 4 files changed, 34 insertions(+), 37 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt >
On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: > Hi, > > [add Peter and Ivan] > > Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > > Hello, > > > > This small series includes a few drive-by fixes for DT validation > > errors. > > > > The first patch has been posted previously in v1 ([1], and now addresses > > a small review comment. I think it's good to go. > > > > The next two patches address the same issue as "[PATCH 1/2] dt-bindings: > > arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" ([2]), > > but this time with a (hopefully) correct approach. Patch 2/3 starts by > > fixing the raspberrypi-bcm2835-firmware driver, removing the need for DT > > properties that are specified in bcm2835-rpi.dtsi but not documented in > > the corresponding bindings. Patch 3/3 can then drop those properties, > > getting rid of the warnings. > > since this series drops properties from the device tree, does anyone > have the chance to test it with a recent U-Boot? I don't have U-Boot running with my RPi, so I would appreciate if someone could help :-) > > [1] https://lore.kernel.org/linux-arm-kernel/20240326004902.17054-3-laurent.pinchart@ideasonboard.com/ > > [2] https://lore.kernel.org/linux-arm-kernel/20240326004902.17054-2-laurent.pinchart@ideasonboard.com/ > > > > Laurent Pinchart (3): > > dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Add gpio child > > node > > firmware: raspberrypi: Use correct device for DMA mappings > > ARM: dts: bcm283x: Drop unneeded properties in the bcm2835-firmware > > node > > > > .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 30 +++++++++++++++++++ > > .../gpio/raspberrypi,firmware-gpio.txt | 30 ------------------- > > arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi | 4 --- > > drivers/firmware/raspberrypi.c | 7 +++-- > > 4 files changed, 34 insertions(+), 37 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt > >
Hi, On 2024-03-28 01:37, Laurent Pinchart wrote: > On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: >> Hi, >> >> [add Peter and Ivan] >> >> Am 26.03.24 um 20:58 schrieb Laurent Pinchart: >> > Hello, >> > >> > This small series includes a few drive-by fixes for DT validation >> > errors. >> > >> > The first patch has been posted previously in v1 ([1], and now addresses >> > a small review comment. I think it's good to go. >> > >> > The next two patches address the same issue as "[PATCH 1/2] dt-bindings: >> > arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" ([2]), >> > but this time with a (hopefully) correct approach. Patch 2/3 starts by >> > fixing the raspberrypi-bcm2835-firmware driver, removing the need for DT >> > properties that are specified in bcm2835-rpi.dtsi but not documented in >> > the corresponding bindings. Patch 3/3 can then drop those properties, >> > getting rid of the warnings. >> >> since this series drops properties from the device tree, does anyone >> have the chance to test it with a recent U-Boot? > > I don't have U-Boot running with my RPi, so I would appreciate if > someone could help :-) Sorry for taking me so long to verify this. I think on RPi U-Boot side we are fine. API used when accessing Mbox device do not follow DM model and do not use DMA, but just access device directly using this nice macros phys_to_bus/bus_to_phys. I build new DTB files with this patch included and U-Boot build from the latest sources. No obvious issues on RPi3 and RPi4. Devices boot fine. Regards, Ivan
Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: > > Hi, > > On 2024-03-28 01:37, Laurent Pinchart wrote: >> On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: >>> Hi, >>> >>> [add Peter and Ivan] >>> >>> Am 26.03.24 um 20:58 schrieb Laurent Pinchart: >>> > Hello, >>> > >>> > This small series includes a few drive-by fixes for DT validation >>> > errors. >>> > >>> > The first patch has been posted previously in v1 ([1], and now >>> addresses >>> > a small review comment. I think it's good to go. >>> > >>> > The next two patches address the same issue as "[PATCH 1/2] >>> dt-bindings: >>> > arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" >>> ([2]), >>> > but this time with a (hopefully) correct approach. Patch 2/3 >>> starts by >>> > fixing the raspberrypi-bcm2835-firmware driver, removing the need >>> for DT >>> > properties that are specified in bcm2835-rpi.dtsi but not >>> documented in >>> > the corresponding bindings. Patch 3/3 can then drop those properties, >>> > getting rid of the warnings. >>> >>> since this series drops properties from the device tree, does anyone >>> have the chance to test it with a recent U-Boot? >> >> I don't have U-Boot running with my RPi, so I would appreciate if >> someone could help :-) > > Sorry for taking me so long to verify this. > > I think on RPi U-Boot side we are fine. API used when accessing Mbox > device do not follow DM model and do not use DMA, but just access > device directly using this nice macros phys_to_bus/bus_to_phys. > > I build new DTB files with this patch included and U-Boot build > from the latest sources. No obvious issues on RPi3 and RPi4. > Devices boot fine. Thanks you, Laurent and Ivan Reviewed-by: Stefan Wahren <wahrenst@gmx.net> > > Regards, > Ivan
Hello, On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: > Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: > > On 2024-03-28 01:37, Laurent Pinchart wrote: > >> On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: > >>> Hi, > >>> > >>> [add Peter and Ivan] > >>> > >>> Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > >>> > Hello, > >>> > > >>> > This small series includes a few drive-by fixes for DT validation > >>> > errors. > >>> > > >>> > The first patch has been posted previously in v1 ([1], and now addresses > >>> > a small review comment. I think it's good to go. > >>> > > >>> > The next two patches address the same issue as "[PATCH 1/2] dt-bindings: > >>> > arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" ([2]), > >>> > but this time with a (hopefully) correct approach. Patch 2/3 starts by > >>> > fixing the raspberrypi-bcm2835-firmware driver, removing the need for DT > >>> > properties that are specified in bcm2835-rpi.dtsi but not documented in > >>> > the corresponding bindings. Patch 3/3 can then drop those properties, > >>> > getting rid of the warnings. > >>> > >>> since this series drops properties from the device tree, does anyone > >>> have the chance to test it with a recent U-Boot? > >> > >> I don't have U-Boot running with my RPi, so I would appreciate if > >> someone could help :-) > > > > Sorry for taking me so long to verify this. > > > > I think on RPi U-Boot side we are fine. API used when accessing Mbox > > device do not follow DM model and do not use DMA, but just access > > device directly using this nice macros phys_to_bus/bus_to_phys. > > > > I build new DTB files with this patch included and U-Boot build > > from the latest sources. No obvious issues on RPi3 and RPi4. > > Devices boot fine. Thank you for testing Ivan. > Thanks you, Laurent and Ivan > > Reviewed-by: Stefan Wahren <wahrenst@gmx.net> Stefan, I'm quite unfamiliar with the Raspberry Pi upstreaming process (despite having sent patches for ages :-)), do I understand correctly that this patch will go through your tree, or do I need to work with someone else to get it merged upstream ?
On 4/2/24 13:08, Laurent Pinchart wrote: > Hello, > > On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: >> Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: >>> On 2024-03-28 01:37, Laurent Pinchart wrote: >>>> On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: >>>>> Hi, >>>>> >>>>> [add Peter and Ivan] >>>>> >>>>> Am 26.03.24 um 20:58 schrieb Laurent Pinchart: >>>>>> Hello, >>>>>> >>>>>> This small series includes a few drive-by fixes for DT validation >>>>>> errors. >>>>>> >>>>>> The first patch has been posted previously in v1 ([1], and now addresses >>>>>> a small review comment. I think it's good to go. >>>>>> >>>>>> The next two patches address the same issue as "[PATCH 1/2] dt-bindings: >>>>>> arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" ([2]), >>>>>> but this time with a (hopefully) correct approach. Patch 2/3 starts by >>>>>> fixing the raspberrypi-bcm2835-firmware driver, removing the need for DT >>>>>> properties that are specified in bcm2835-rpi.dtsi but not documented in >>>>>> the corresponding bindings. Patch 3/3 can then drop those properties, >>>>>> getting rid of the warnings. >>>>> >>>>> since this series drops properties from the device tree, does anyone >>>>> have the chance to test it with a recent U-Boot? >>>> >>>> I don't have U-Boot running with my RPi, so I would appreciate if >>>> someone could help :-) >>> >>> Sorry for taking me so long to verify this. >>> >>> I think on RPi U-Boot side we are fine. API used when accessing Mbox >>> device do not follow DM model and do not use DMA, but just access >>> device directly using this nice macros phys_to_bus/bus_to_phys. >>> >>> I build new DTB files with this patch included and U-Boot build >>> from the latest sources. No obvious issues on RPi3 and RPi4. >>> Devices boot fine. > > Thank you for testing Ivan. > >> Thanks you, Laurent and Ivan >> >> Reviewed-by: Stefan Wahren <wahrenst@gmx.net> > > Stefan, I'm quite unfamiliar with the Raspberry Pi upstreaming process > (despite having sent patches for ages :-)), do I understand correctly > that this patch will go through your tree, or do I need to work with > someone else to get it merged upstream ? I will be taking those via the Broadcom SoC tree.
Hi Laurent, Am 02.04.24 um 22:08 schrieb Laurent Pinchart: > Hello, > ... > Stefan, I'm quite unfamiliar with the Raspberry Pi upstreaming process > (despite having sent patches for ages :-)), do I understand correctly > that this patch will go through your tree, or do I need to work with > someone else to get it merged upstream ? > i'm not the maintainer, but i'm trying to help. Florian is the maintainer, so i would expect this series goes through his tree. So MAINTAINERS file is correct here.
On 4/2/24 01:58, Ivan T. Ivanov wrote: > > Hi, > > On 2024-03-28 01:37, Laurent Pinchart wrote: >> On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: >>> Hi, >>> >>> [add Peter and Ivan] >>> >>> Am 26.03.24 um 20:58 schrieb Laurent Pinchart: >>> > Hello, >>> > >>> > This small series includes a few drive-by fixes for DT validation >>> > errors. >>> > >>> > The first patch has been posted previously in v1 ([1], and now >>> addresses >>> > a small review comment. I think it's good to go. >>> > >>> > The next two patches address the same issue as "[PATCH 1/2] >>> dt-bindings: >>> > arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" ([2]), >>> > but this time with a (hopefully) correct approach. Patch 2/3 starts by >>> > fixing the raspberrypi-bcm2835-firmware driver, removing the need >>> for DT >>> > properties that are specified in bcm2835-rpi.dtsi but not >>> documented in >>> > the corresponding bindings. Patch 3/3 can then drop those properties, >>> > getting rid of the warnings. >>> >>> since this series drops properties from the device tree, does anyone >>> have the chance to test it with a recent U-Boot? >> >> I don't have U-Boot running with my RPi, so I would appreciate if >> someone could help :-) > > Sorry for taking me so long to verify this. > > I think on RPi U-Boot side we are fine. API used when accessing Mbox > device do not follow DM model and do not use DMA, but just access > device directly using this nice macros phys_to_bus/bus_to_phys. > > I build new DTB files with this patch included and U-Boot build > from the latest sources. No obvious issues on RPi3 and RPi4. > Devices boot fine. Can I add this as a Tested-by tag from you while applying then?
Hi Florian, On Tue, Apr 02, 2024 at 01:18:35PM -0700, Florian Fainelli wrote: > On 4/2/24 13:08, Laurent Pinchart wrote: > > On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: > >> Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: > >>> On 2024-03-28 01:37, Laurent Pinchart wrote: > >>>> On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: > >>>>> Hi, > >>>>> > >>>>> [add Peter and Ivan] > >>>>> > >>>>> Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > >>>>>> Hello, > >>>>>> > >>>>>> This small series includes a few drive-by fixes for DT validation > >>>>>> errors. > >>>>>> > >>>>>> The first patch has been posted previously in v1 ([1], and now addresses > >>>>>> a small review comment. I think it's good to go. > >>>>>> > >>>>>> The next two patches address the same issue as "[PATCH 1/2] dt-bindings: > >>>>>> arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" ([2]), > >>>>>> but this time with a (hopefully) correct approach. Patch 2/3 starts by > >>>>>> fixing the raspberrypi-bcm2835-firmware driver, removing the need for DT > >>>>>> properties that are specified in bcm2835-rpi.dtsi but not documented in > >>>>>> the corresponding bindings. Patch 3/3 can then drop those properties, > >>>>>> getting rid of the warnings. > >>>>> > >>>>> since this series drops properties from the device tree, does anyone > >>>>> have the chance to test it with a recent U-Boot? > >>>> > >>>> I don't have U-Boot running with my RPi, so I would appreciate if > >>>> someone could help :-) > >>> > >>> Sorry for taking me so long to verify this. > >>> > >>> I think on RPi U-Boot side we are fine. API used when accessing Mbox > >>> device do not follow DM model and do not use DMA, but just access > >>> device directly using this nice macros phys_to_bus/bus_to_phys. > >>> > >>> I build new DTB files with this patch included and U-Boot build > >>> from the latest sources. No obvious issues on RPi3 and RPi4. > >>> Devices boot fine. > > > > Thank you for testing Ivan. > > > >> Thanks you, Laurent and Ivan > >> > >> Reviewed-by: Stefan Wahren <wahrenst@gmx.net> > > > > Stefan, I'm quite unfamiliar with the Raspberry Pi upstreaming process > > (despite having sent patches for ages :-)), do I understand correctly > > that this patch will go through your tree, or do I need to work with > > someone else to get it merged upstream ? > > I will be taking those via the Broadcom SoC tree. Thank you. If there's a chance to include patches 05/10, 07/10, 08/10 and 09/10 from [1] at the same time, that would be great :-) [1] https://lore.kernel.org/linux-media/20240402000424.4650-1-laurent.pinchart@ideasonboard.com
On 4/2/24 13:32, Laurent Pinchart wrote: > Hi Florian, > > On Tue, Apr 02, 2024 at 01:18:35PM -0700, Florian Fainelli wrote: >> On 4/2/24 13:08, Laurent Pinchart wrote: >>> On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: >>>> Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: >>>>> On 2024-03-28 01:37, Laurent Pinchart wrote: >>>>>> On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: >>>>>>> Hi, >>>>>>> >>>>>>> [add Peter and Ivan] >>>>>>> >>>>>>> Am 26.03.24 um 20:58 schrieb Laurent Pinchart: >>>>>>>> Hello, >>>>>>>> >>>>>>>> This small series includes a few drive-by fixes for DT validation >>>>>>>> errors. >>>>>>>> >>>>>>>> The first patch has been posted previously in v1 ([1], and now addresses >>>>>>>> a small review comment. I think it's good to go. >>>>>>>> >>>>>>>> The next two patches address the same issue as "[PATCH 1/2] dt-bindings: >>>>>>>> arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" ([2]), >>>>>>>> but this time with a (hopefully) correct approach. Patch 2/3 starts by >>>>>>>> fixing the raspberrypi-bcm2835-firmware driver, removing the need for DT >>>>>>>> properties that are specified in bcm2835-rpi.dtsi but not documented in >>>>>>>> the corresponding bindings. Patch 3/3 can then drop those properties, >>>>>>>> getting rid of the warnings. >>>>>>> >>>>>>> since this series drops properties from the device tree, does anyone >>>>>>> have the chance to test it with a recent U-Boot? >>>>>> >>>>>> I don't have U-Boot running with my RPi, so I would appreciate if >>>>>> someone could help :-) >>>>> >>>>> Sorry for taking me so long to verify this. >>>>> >>>>> I think on RPi U-Boot side we are fine. API used when accessing Mbox >>>>> device do not follow DM model and do not use DMA, but just access >>>>> device directly using this nice macros phys_to_bus/bus_to_phys. >>>>> >>>>> I build new DTB files with this patch included and U-Boot build >>>>> from the latest sources. No obvious issues on RPi3 and RPi4. >>>>> Devices boot fine. >>> >>> Thank you for testing Ivan. >>> >>>> Thanks you, Laurent and Ivan >>>> >>>> Reviewed-by: Stefan Wahren <wahrenst@gmx.net> >>> >>> Stefan, I'm quite unfamiliar with the Raspberry Pi upstreaming process >>> (despite having sent patches for ages :-)), do I understand correctly >>> that this patch will go through your tree, or do I need to work with >>> someone else to get it merged upstream ? >> >> I will be taking those via the Broadcom SoC tree. > > Thank you. > > If there's a chance to include patches 05/10, 07/10, 08/10 and 09/10 > from [1] at the same time, that would be great :-) > > [1] https://lore.kernel.org/linux-media/20240402000424.4650-1-laurent.pinchart@ideasonboard.com > Yes, now done, thanks!
Hello, This small series includes a few drive-by fixes for DT validation errors. The first patch has been posted previously in v1 ([1], and now addresses a small review comment. I think it's good to go. The next two patches address the same issue as "[PATCH 1/2] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" ([2]), but this time with a (hopefully) correct approach. Patch 2/3 starts by fixing the raspberrypi-bcm2835-firmware driver, removing the need for DT properties that are specified in bcm2835-rpi.dtsi but not documented in the corresponding bindings. Patch 3/3 can then drop those properties, getting rid of the warnings. [1] https://lore.kernel.org/linux-arm-kernel/20240326004902.17054-3-laurent.pinchart@ideasonboard.com/ [2] https://lore.kernel.org/linux-arm-kernel/20240326004902.17054-2-laurent.pinchart@ideasonboard.com/ Laurent Pinchart (3): dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Add gpio child node firmware: raspberrypi: Use correct device for DMA mappings ARM: dts: bcm283x: Drop unneeded properties in the bcm2835-firmware node .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 30 +++++++++++++++++++ .../gpio/raspberrypi,firmware-gpio.txt | 30 ------------------- arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi | 4 --- drivers/firmware/raspberrypi.c | 7 +++-- 4 files changed, 34 insertions(+), 37 deletions(-) delete mode 100644 Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt