| Message ID | 20240327113228.1706975-2-quic_mohs@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | ASoC: qcom: add support for qcm6490 machine | expand |
On 27/03/2024 12:32, Mohammad Rafi Shaik wrote: > Document bindings for the Qualcomm qcm6490 and qcs6490 SoC sound card. > The bindings are the same as for other newer Qualcomm ADSP sound cards, > thus keep them in existing qcom,sm8250.yaml file, even though Linux driver > is separate. > > Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> > --- > Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > index 2ab6871e89e5..247ad3d10933 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > @@ -29,6 +29,8 @@ properties: > - enum: > - qcom,apq8016-sbc-sndcard > - qcom,msm8916-qdsp6-sndcard > + - qcom,qcm6490-sndcard > + - qcom,qcs6490-sndcard What are the differences between these sound cards? I know that we ask for specific compatibles per each SoC block, but for similar SoCs sound cards might be an exception. It's more of a software construct anyway. Best regards, Krzysztof
On 27/03/2024 12:32, Mohammad Rafi Shaik wrote: > Document bindings for the Qualcomm qcm6490 and qcs6490 SoC sound card. > The bindings are the same as for other newer Qualcomm ADSP sound cards, > thus keep them in existing qcom,sm8250.yaml file, even though Linux driver > is separate. > > Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> > --- Patch is trivial, yet people make whitespace mistakes also in trivial stuff. Therefore please be sure the patch is being tested by CC-ing appropriate mailing lists. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline), work on fork of kernel (don't, instead use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index 2ab6871e89e5..247ad3d10933 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -29,6 +29,8 @@ properties: - enum: - qcom,apq8016-sbc-sndcard - qcom,msm8916-qdsp6-sndcard + - qcom,qcm6490-sndcard + - qcom,qcs6490-sndcard - qcom,qrb5165-rb5-sndcard - qcom,sc7180-qdsp6-sndcard - qcom,sc8280xp-sndcard
Document bindings for the Qualcomm qcm6490 and qcs6490 SoC sound card. The bindings are the same as for other newer Qualcomm ADSP sound cards, thus keep them in existing qcom,sm8250.yaml file, even though Linux driver is separate. Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> --- Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++ 1 file changed, 2 insertions(+)