| Message ID | 2024032732-thigh-smite-f5dd@gregkh (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v3] platform/x86/amd/hsmp: switch to use device_add_groups() | expand |
On Wed, 27 Mar 2024, Greg Kroah-Hartman wrote: > devm_device_add_groups() is being removed from the kernel, so move the > hsmp driver to use device_add_groups() instead. The logic is identical, > when the device is removed the driver core will properly clean up and > remove the groups, and the memory used by the attribute groups will be > freed because it was created with dev_* calls, so this is functionally > identical overall. > > Cc: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com> > Cc: Carlos Bilbao <carlos.bilbao@amd.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> > Cc: platform-driver-x86@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > v3: change the changelog text to reflect that this change is identical > to the current code. Rebase against 6.9-rc1 > v2: rebased against platform/for-next > > drivers/platform/x86/amd/hsmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c > index 1927be901108..d84ea66eecc6 100644 > --- a/drivers/platform/x86/amd/hsmp.c > +++ b/drivers/platform/x86/amd/hsmp.c > @@ -693,7 +693,7 @@ static int hsmp_create_non_acpi_sysfs_if(struct device *dev) > hsmp_create_attr_list(attr_grp, dev, i); > } > > - return devm_device_add_groups(dev, hsmp_attr_grps); > + return device_add_groups(dev, hsmp_attr_grps); > } > > static int hsmp_create_acpi_sysfs_if(struct device *dev) Thanks for the update. Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Hi, On 3/27/24 9:08 AM, Greg Kroah-Hartman wrote: > devm_device_add_groups() is being removed from the kernel, so move the > hsmp driver to use device_add_groups() instead. The logic is identical, > when the device is removed the driver core will properly clean up and > remove the groups, and the memory used by the attribute groups will be > freed because it was created with dev_* calls, so this is functionally > identical overall. > > Cc: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com> > Cc: Carlos Bilbao <carlos.bilbao@amd.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> > Cc: platform-driver-x86@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > v3: change the changelog text to reflect that this change is identical > to the current code. Rebase against 6.9-rc1 > v2: rebased against platform/for-next > > drivers/platform/x86/amd/hsmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c > index 1927be901108..d84ea66eecc6 100644 > --- a/drivers/platform/x86/amd/hsmp.c > +++ b/drivers/platform/x86/amd/hsmp.c > @@ -693,7 +693,7 @@ static int hsmp_create_non_acpi_sysfs_if(struct device *dev) > hsmp_create_attr_list(attr_grp, dev, i); > } > > - return devm_device_add_groups(dev, hsmp_attr_grps); > + return device_add_groups(dev, hsmp_attr_grps); > } > > static int hsmp_create_acpi_sysfs_if(struct device *dev)
diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c index 1927be901108..d84ea66eecc6 100644 --- a/drivers/platform/x86/amd/hsmp.c +++ b/drivers/platform/x86/amd/hsmp.c @@ -693,7 +693,7 @@ static int hsmp_create_non_acpi_sysfs_if(struct device *dev) hsmp_create_attr_list(attr_grp, dev, i); } - return devm_device_add_groups(dev, hsmp_attr_grps); + return device_add_groups(dev, hsmp_attr_grps); } static int hsmp_create_acpi_sysfs_if(struct device *dev)
devm_device_add_groups() is being removed from the kernel, so move the hsmp driver to use device_add_groups() instead. The logic is identical, when the device is removed the driver core will properly clean up and remove the groups, and the memory used by the attribute groups will be freed because it was created with dev_* calls, so this is functionally identical overall. Cc: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com> Cc: Carlos Bilbao <carlos.bilbao@amd.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> Cc: platform-driver-x86@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- v3: change the changelog text to reflect that this change is identical to the current code. Rebase against 6.9-rc1 v2: rebased against platform/for-next drivers/platform/x86/amd/hsmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)