| Message ID | 20240325155838.1558680-1-kvalo@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b68b2beadfd30907faae944358de3a17acf6fdb6 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2] wifi: mt76: mt7915: workaround dubious x | !y warning | expand |
Kalle Valo <kvalo@kernel.org> writes: > Sparse warns: > > drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning: dubious: x | !y > > Workaround it by using the '?' operator. Compile tested only. > > Signed-off-by: Kalle Valo <kvalo@kernel.org> > --- > v2: > > * use parenthesis Felix&Lorenzo, if this looks ok to you I would like to take this directly to wireless-next. I'm aiming that the next wireless-next pull request is sparse warning free :)
> Sparse warns: > > drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning: dubious: x | !y > > Workaround it by using the '?' operator. Compile tested only. Acked-by: Lorenzo Bianconi <lorenzo@kernel.org> > > Signed-off-by: Kalle Valo <kvalo@kernel.org> > --- > v2: > > * use parenthesis > > drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c > index 450f4d221184..578013884e43 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c > @@ -523,7 +523,8 @@ mt7915_fw_debug_wm_set(void *data, u64 val) > > /* WM CPU info record control */ > mt76_clear(dev, MT_CPU_UTIL_CTRL, BIT(0)); > - mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | !dev->fw.debug_wm); > + mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | > + (dev->fw.debug_wm ? 0 : BIT(0))); > mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_MASK_CLR_ADDR, BIT(5)); > mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_SOFT_ADDR, BIT(5)); > > -- > 2.39.2 > >
Kalle Valo <kvalo@kernel.org> wrote: > Sparse warns: > > drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning: dubious: x | !y > > Workaround it by using the '?' operator. Compile tested only. > > Signed-off-by: Kalle Valo <kvalo@kernel.org> > Acked-by: Lorenzo Bianconi <lorenzo@kernel.org> Patch applied to wireless-next.git, thanks. b68b2beadfd3 wifi: mt76: mt7915: workaround dubious x | !y warning
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c index 450f4d221184..578013884e43 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c @@ -523,7 +523,8 @@ mt7915_fw_debug_wm_set(void *data, u64 val) /* WM CPU info record control */ mt76_clear(dev, MT_CPU_UTIL_CTRL, BIT(0)); - mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | !dev->fw.debug_wm); + mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | + (dev->fw.debug_wm ? 0 : BIT(0))); mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_MASK_CLR_ADDR, BIT(5)); mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_SOFT_ADDR, BIT(5));
Sparse warns: drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning: dubious: x | !y Workaround it by using the '?' operator. Compile tested only. Signed-off-by: Kalle Valo <kvalo@kernel.org> --- v2: * use parenthesis drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)