| Message ID | 20240327231710.53188-19-git@luigi311.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | v2: imx258 improvement series | expand |
On Wed, 27 Mar 2024 17:17:04 -0600, git@luigi311.com wrote: > From: Dave Stevenson <dave.stevenson@raspberrypi.com> > > There are a number of variants of the imx258 modules that can not > be differentiated at runtime, so add compatible strings for them. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Signed-off-by: Luigi311 <git@luigi311.com> > --- > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: properties:compatible: [{'enum': ['sony,imx258', 'sony,imx258-pdaf']}] is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: properties:compatible: [{'enum': ['sony,imx258', 'sony,imx258-pdaf']}] is not of type 'object', 'boolean' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: ignoring, error in schema: properties: compatible Documentation/devicetree/bindings/media/i2c/sony,imx258.example.dtb: /example-0/i2c/sensor@6c: failed to match any schema with compatible: ['sony,imx258'] Documentation/devicetree/bindings/media/i2c/sony,imx258.example.dtb: /example-1/i2c/sensor@6c: failed to match any schema with compatible: ['sony,imx258'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240327231710.53188-19-git@luigi311.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 28/03/2024 00:17, git@luigi311.com wrote: > From: Dave Stevenson <dave.stevenson@raspberrypi.com> > > There are a number of variants of the imx258 modules that can not > be differentiated at runtime, so add compatible strings for them. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Signed-off-by: Luigi311 <git@luigi311.com> > --- > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > index bee61a443b23..c7856de15ba3 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > @@ -14,10 +14,14 @@ description: |- > type stacked image sensor with a square pixel array of size 4208 x 3120. It > is programmable through I2C interface. Image data is sent through MIPI > CSI-2. > + There are a number of variants of the sensor which cannot be detected at > + runtime, so multiple compatible strings are required to differentiate these. > > properties: > compatible: > - const: sony,imx258 > + - enum: > + - sony,imx258 Two people working on patch but no one tested it before sending. Do not send untested code. It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
On 3/28/24 01:47, Krzysztof Kozlowski wrote: > On 28/03/2024 00:17, git@luigi311.com wrote: >> From: Dave Stevenson <dave.stevenson@raspberrypi.com> >> >> There are a number of variants of the imx258 modules that can not >> be differentiated at runtime, so add compatible strings for them. >> >> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> >> Signed-off-by: Luigi311 <git@luigi311.com> >> --- >> .../devicetree/bindings/media/i2c/sony,imx258.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> index bee61a443b23..c7856de15ba3 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> @@ -14,10 +14,14 @@ description: |- >> type stacked image sensor with a square pixel array of size 4208 x 3120. It >> is programmable through I2C interface. Image data is sent through MIPI >> CSI-2. >> + There are a number of variants of the sensor which cannot be detected at >> + runtime, so multiple compatible strings are required to differentiate these. >> >> properties: >> compatible: >> - const: sony,imx258 >> + - enum: >> + - sony,imx258 > > Two people working on patch but no one tested it before sending. Do not > send untested code. > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. Hello, looks like I messed this up during my v2 (sorry missed the v in my format patch) when I took this off Dave's hands. This is all new to me so thank you for the command used to check, I was only compiling the kernel and testing that so I didn't realize this needed separate testing. Looks like it no longer complains when i run make dt_binding_check DT_SCHEMA_FILES=media/i2c/sony,imx258 with the following properties: compatible: enum: - sony,imx258 - sony,imx258-pdaf If that looks good I can go ahead and include that in the v3 > > Best regards, > Krzysztof >
On 28/03/2024 18:05, Luigi311 wrote: > > Looks like it no longer complains when i run > make dt_binding_check DT_SCHEMA_FILES=media/i2c/sony,imx258 > > with the following > > properties: > compatible: > enum: > - sony,imx258 > - sony,imx258-pdaf > > If that looks good I can go ahead and include that in the v3 > Looks good, thanks. Best regards, Krzysztof
On Wed, Mar 27, 2024 at 05:17:04PM -0600, git@luigi311.com wrote: > From: Dave Stevenson <dave.stevenson@raspberrypi.com> > > There are a number of variants of the imx258 modules that can not > be differentiated at runtime, so add compatible strings for them. But you are only adding 1 variant. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Signed-off-by: Luigi311 <git@luigi311.com> > --- > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > index bee61a443b23..c7856de15ba3 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > @@ -14,10 +14,14 @@ description: |- > type stacked image sensor with a square pixel array of size 4208 x 3120. It > is programmable through I2C interface. Image data is sent through MIPI > CSI-2. > + There are a number of variants of the sensor which cannot be detected at > + runtime, so multiple compatible strings are required to differentiate these. That's more reasoning/why for the patch than description of the h/w. > properties: > compatible: > - const: sony,imx258 > + - enum: > + - sony,imx258 > + - sony,imx258-pdaf How do I know which one to use? Please define what PDAF means somewhere as well as perhaps what the original/default variant is or isn't. > > assigned-clocks: true > assigned-clock-parents: true > -- > 2.42.0 >
On 3/28/24 12:55, Rob Herring wrote: > On Wed, Mar 27, 2024 at 05:17:04PM -0600, git@luigi311.com wrote: >> From: Dave Stevenson <dave.stevenson@raspberrypi.com> >> >> There are a number of variants of the imx258 modules that can not >> be differentiated at runtime, so add compatible strings for them. >> But you are only adding 1 variant. I can not speak for Dave but as to why this was added here but looking at the imx296 yaml that has something similar where there are multiple variants that may not be detectable at run time but does not include similar verbiage in the main description. Should I drop this from the description so it matches the imx296? > >> >> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> >> Signed-off-by: Luigi311 <git@luigi311.com> >> --- >> .../devicetree/bindings/media/i2c/sony,imx258.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> index bee61a443b23..c7856de15ba3 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> @@ -14,10 +14,14 @@ description: |- >> type stacked image sensor with a square pixel array of size 4208 x 3120. It >> is programmable through I2C interface. Image data is sent through MIPI >> CSI-2. >> + There are a number of variants of the sensor which cannot be detected at >> + runtime, so multiple compatible strings are required to differentiate these. > > That's more reasoning/why for the patch than description of the h/w. > >> properties: >> compatible: >> - const: sony,imx258 >> + - enum: >> + - sony,imx258 >> + - sony,imx258-pdaf > > How do I know which one to use? Please define what PDAF means somewhere > as well as perhaps what the original/default variant is or isn't. Would it make sense to change the properties to include a description like so properties: compatible: enum: - sony,imx258 - sony,imx258-pdaf description: The IMX258 sensor exists in two different models, a standard variant (IMX258) and a variant with phase detection autofocus (IMX258-PDAF). The camera module does not expose the model through registers, so the exact model needs to be specified. > >> >> assigned-clocks: true >> assigned-clock-parents: true >> -- >> 2.42.0 >>
Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on media-tree/master] [also build test WARNING on linuxtv-media-stage/master linus/master v6.9-rc1 next-20240328] [cannot apply to sailus-media-tree/streams] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/git-luigi311-com/media-i2c-imx258-Remove-unused-defines/20240328-072629 base: git://linuxtv.org/media_tree.git master patch link: https://lore.kernel.org/r/20240327231710.53188-19-git%40luigi311.com patch subject: [PATCH 18/23] dt-bindings: media: imx258: Add alternate compatible strings compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20240329/202403290352.sV38QfhQ-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202403290352.sV38QfhQ-lkp@intel.com/ dtcheck warnings: (new ones prefixed by >>) >> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: properties:compatible: [{'enum': ['sony,imx258', 'sony,imx258-pdaf']}] is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# >> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: properties:compatible: [{'enum': ['sony,imx258', 'sony,imx258-pdaf']}] is not of type 'object', 'boolean' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# -- >> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: ignoring, error in schema: properties: compatible
On Thu, Mar 28, 2024 at 01:16:22PM -0600, Luigi311 wrote: > On 3/28/24 12:55, Rob Herring wrote: > > On Wed, Mar 27, 2024 at 05:17:04PM -0600, git@luigi311.com wrote: > >> From: Dave Stevenson <dave.stevenson@raspberrypi.com> > >> > >> There are a number of variants of the imx258 modules that can not > >> be differentiated at runtime, so add compatible strings for them. > >> But you are only adding 1 variant. > > I can not speak for Dave but as to why this was added here but looking > at the imx296 yaml that has something similar where there are multiple > variants that may not be detectable at run time but does not include > similar verbiage in the main description. Should I drop this from the > description so it matches the imx296? Just change "add compatible strings for them" to "add compatible string for the PDAF variant" or something. > > > > >> > >> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > >> Signed-off-by: Luigi311 <git@luigi311.com> > >> --- > >> .../devicetree/bindings/media/i2c/sony,imx258.yaml | 6 +++++- > >> 1 file changed, 5 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > >> index bee61a443b23..c7856de15ba3 100644 > >> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > >> @@ -14,10 +14,14 @@ description: |- > >> type stacked image sensor with a square pixel array of size 4208 x 3120. It > >> is programmable through I2C interface. Image data is sent through MIPI > >> CSI-2. > >> + There are a number of variants of the sensor which cannot be detected at > >> + runtime, so multiple compatible strings are required to differentiate these. > > > > That's more reasoning/why for the patch than description of the h/w. > > > >> properties: > >> compatible: > >> - const: sony,imx258 > >> + - enum: > >> + - sony,imx258 > >> + - sony,imx258-pdaf > > > > How do I know which one to use? Please define what PDAF means somewhere > > as well as perhaps what the original/default variant is or isn't. > > Would it make sense to change the properties to include a description like so > > properties: > compatible: > enum: > - sony,imx258 > - sony,imx258-pdaf > description: > The IMX258 sensor exists in two different models, a standard variant > (IMX258) and a variant with phase detection autofocus (IMX258-PDAF). > The camera module does not expose the model through registers, so the > exact model needs to be specified. Looks fine, but I'd move this to the top-level 'description'. Rob
On 3/28/24 14:46, Rob Herring wrote: > On Thu, Mar 28, 2024 at 01:16:22PM -0600, Luigi311 wrote: >> On 3/28/24 12:55, Rob Herring wrote: >>> On Wed, Mar 27, 2024 at 05:17:04PM -0600, git@luigi311.com wrote: >>>> From: Dave Stevenson <dave.stevenson@raspberrypi.com> >>>> >>>> There are a number of variants of the imx258 modules that can not >>>> be differentiated at runtime, so add compatible strings for them. >>>> But you are only adding 1 variant. >> >> I can not speak for Dave but as to why this was added here but looking >> at the imx296 yaml that has something similar where there are multiple >> variants that may not be detectable at run time but does not include >> similar verbiage in the main description. Should I drop this from the >> description so it matches the imx296? > > Just change "add compatible strings for them" to "add compatible string > for the PDAF variant" or something. > Ohh i see what you mean now, this is in reference to the commit message, it was throwing me off because the imx258 description had almost the exact same wording. Yes that makes sense, ill change the commit message to specify PDAF. >> >>> >>>> >>>> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> >>>> Signed-off-by: Luigi311 <git@luigi311.com> >>>> --- >>>> .../devicetree/bindings/media/i2c/sony,imx258.yaml | 6 +++++- >>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >>>> index bee61a443b23..c7856de15ba3 100644 >>>> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >>>> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >>>> @@ -14,10 +14,14 @@ description: |- >>>> type stacked image sensor with a square pixel array of size 4208 x 3120. It >>>> is programmable through I2C interface. Image data is sent through MIPI >>>> CSI-2. >>>> + There are a number of variants of the sensor which cannot be detected at >>>> + runtime, so multiple compatible strings are required to differentiate these. >>> >>> That's more reasoning/why for the patch than description of the h/w. >>> >>>> properties: >>>> compatible: >>>> - const: sony,imx258 >>>> + - enum: >>>> + - sony,imx258 >>>> + - sony,imx258-pdaf >>> >>> How do I know which one to use? Please define what PDAF means somewhere >>> as well as perhaps what the original/default variant is or isn't. >> >> Would it make sense to change the properties to include a description like so >> >> properties: >> compatible: >> enum: >> - sony,imx258 >> - sony,imx258-pdaf >> description: >> The IMX258 sensor exists in two different models, a standard variant >> (IMX258) and a variant with phase detection autofocus (IMX258-PDAF). >> The camera module does not expose the model through registers, so the >> exact model needs to be specified. > > Looks fine, but I'd move this to the top-level 'description'. > > Rob Perfect ill move this to the top level description and remove that small section that Dave added
Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on media-tree/master] [also build test WARNING on linuxtv-media-stage/master linus/master v6.9-rc1 next-20240328] [cannot apply to sailus-media-tree/streams] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/git-luigi311-com/media-i2c-imx258-Remove-unused-defines/20240328-072629 base: git://linuxtv.org/media_tree.git master patch link: https://lore.kernel.org/r/20240327231710.53188-19-git%40luigi311.com patch subject: [PATCH 18/23] dt-bindings: media: imx258: Add alternate compatible strings compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20240330/202403300820.NEs0EOr7-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202403300820.NEs0EOr7-lkp@intel.com/ dtcheck warnings: (new ones prefixed by >>) >> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: properties:compatible: [{'enum': ['sony,imx258', 'sony,imx258-pdaf']}] is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# >> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: properties:compatible: [{'enum': ['sony,imx258', 'sony,imx258-pdaf']}] is not of type 'object', 'boolean' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# -- >> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: ignoring, error in schema: properties: compatible
Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on media-tree/master] [also build test WARNING on linuxtv-media-stage/master linus/master v6.9-rc1 next-20240328] [cannot apply to sailus-media-tree/streams] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/git-luigi311-com/media-i2c-imx258-Remove-unused-defines/20240328-072629 base: git://linuxtv.org/media_tree.git master patch link: https://lore.kernel.org/r/20240327231710.53188-19-git%40luigi311.com patch subject: [PATCH 18/23] dt-bindings: media: imx258: Add alternate compatible strings compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20240331/202403310442.vdZu7Yh6-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202403310442.vdZu7Yh6-lkp@intel.com/ dtcheck warnings: (new ones prefixed by >>) >> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: properties:compatible: [{'enum': ['sony,imx258', 'sony,imx258-pdaf']}] is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# >> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: properties:compatible: [{'enum': ['sony,imx258', 'sony,imx258-pdaf']}] is not of type 'object', 'boolean' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# -- >> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml: ignoring, error in schema: properties: compatible
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml index bee61a443b23..c7856de15ba3 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml @@ -14,10 +14,14 @@ description: |- type stacked image sensor with a square pixel array of size 4208 x 3120. It is programmable through I2C interface. Image data is sent through MIPI CSI-2. + There are a number of variants of the sensor which cannot be detected at + runtime, so multiple compatible strings are required to differentiate these. properties: compatible: - const: sony,imx258 + - enum: + - sony,imx258 + - sony,imx258-pdaf assigned-clocks: true assigned-clock-parents: true