| Message ID | 20240401043505.40972-1-agarwala.kartik@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: dt-bindings: mt2701-wm8960: Convert to dtschema | expand |
On 4/1/24 10:05 AM, Kartik Agarwala wrote:
> Convert mt2701-wm890 bindings from text to dtschema. This is used by MediaTek mt77623a/n SoC.
Apologies for the typo, it should be mt7623a/n instead of mt77623a/n.
Regards,
Kartik Agarwala
On Mon, Apr 01, 2024 at 10:05:05AM +0530, Kartik Agarwala wrote: > Convert mt2701-wm890 bindings from text to dtschema. This is used by MediaTek mt77623a/n SoC. Wrap lines at 75. > > Signed-off-by: Kartik Agarwala <agarwala.kartik@gmail.com> > --- > .../sound/mediatek,mt2701-wm8960.yaml | 59 +++++++++++++++++++ > .../bindings/sound/mt2701-wm8960.txt | 24 -------- > 2 files changed, 59 insertions(+), 24 deletions(-) > create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml > delete mode 100644 Documentation/devicetree/bindings/sound/mt2701-wm8960.txt > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml > new file mode 100644 > index 000000000..771f14a59 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mediatek,mt2701-wm8960.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT2701 with WM8960 CODEC > + > +maintainers: > + - Kartik Agarwala <agarwala.kartik@gmail.com> > + > +properties: > + compatible: > + const: mediatek,mt2701-wm8960-machine > + > + mediatek,platform: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of MT2701 ASoC platform. > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: | Don't need '|'. > + A list of the connections between audio components. Each entry is a > + pair of strings, the first being the connection's sink, the second > + being the connection's source. > + > + mediatek,audio-codec: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of the WM8960 audio codec. > + > + pinctrl-names: > + const: default > + > + pinctrl-0: true You can drop pinctrl properties. Those are implicitly supported. > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - mediatek,platform > + - audio-routing > + - mediatek,audio-codec > + - pinctrl-names > + - pinctrl-0 > + > +examples: > + - | > + sound { > + compatible = "mediatek,mt2701-wm8960-machine"; > + mediatek,platform = <&afe>; > + audio-routing = > + "Headphone", "HP_L", > + "Headphone", "HP_R", > + "LINPUT1", "AMIC", > + "RINPUT1", "AMIC"; > + mediatek,audio-codec = <&wm8960>; > + pinctrl-names = "default"; > + pinctrl-0 = <&aud_pins_default>; > + };
On 4/1/24 8:44 PM, Rob Herring wrote: > On Mon, Apr 01, 2024 at 10:05:05AM +0530, Kartik Agarwala wrote: >> + A list of the connections between audio components. Each entry is a >> + pair of strings, the first being the connection's sink, the second >> + being the connection's source. >> + >> + mediatek,audio-codec: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: The phandle of the WM8960 audio codec. >> + >> + pinctrl-names: >> + const: default >> + >> + pinctrl-0: true > > You can drop pinctrl properties. Those are implicitly supported. Hi, Thanks for the review! Just to clarify, the removal of pinctrl properties should only apply to this section and not to the required properties or the example, is that correct? Regards, Kartik Agarwala
diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml new file mode 100644 index 000000000..771f14a59 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/mediatek,mt2701-wm8960.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek MT2701 with WM8960 CODEC + +maintainers: + - Kartik Agarwala <agarwala.kartik@gmail.com> + +properties: + compatible: + const: mediatek,mt2701-wm8960-machine + + mediatek,platform: + $ref: /schemas/types.yaml#/definitions/phandle + description: The phandle of MT2701 ASoC platform. + + audio-routing: + $ref: /schemas/types.yaml#/definitions/non-unique-string-array + description: | + A list of the connections between audio components. Each entry is a + pair of strings, the first being the connection's sink, the second + being the connection's source. + + mediatek,audio-codec: + $ref: /schemas/types.yaml#/definitions/phandle + description: The phandle of the WM8960 audio codec. + + pinctrl-names: + const: default + + pinctrl-0: true + +unevaluatedProperties: false + +required: + - compatible + - mediatek,platform + - audio-routing + - mediatek,audio-codec + - pinctrl-names + - pinctrl-0 + +examples: + - | + sound { + compatible = "mediatek,mt2701-wm8960-machine"; + mediatek,platform = <&afe>; + audio-routing = + "Headphone", "HP_L", + "Headphone", "HP_R", + "LINPUT1", "AMIC", + "RINPUT1", "AMIC"; + mediatek,audio-codec = <&wm8960>; + pinctrl-names = "default"; + pinctrl-0 = <&aud_pins_default>; + }; diff --git a/Documentation/devicetree/bindings/sound/mt2701-wm8960.txt b/Documentation/devicetree/bindings/sound/mt2701-wm8960.txt deleted file mode 100644 index 809b609ea..000000000 --- a/Documentation/devicetree/bindings/sound/mt2701-wm8960.txt +++ /dev/null @@ -1,24 +0,0 @@ -MT2701 with WM8960 CODEC - -Required properties: -- compatible: "mediatek,mt2701-wm8960-machine" -- mediatek,platform: the phandle of MT2701 ASoC platform -- audio-routing: a list of the connections between audio -- mediatek,audio-codec: the phandles of wm8960 codec -- pinctrl-names: Should contain only one value - "default" -- pinctrl-0: Should specify pin control groups used for this controller. - -Example: - - sound:sound { - compatible = "mediatek,mt2701-wm8960-machine"; - mediatek,platform = <&afe>; - audio-routing = - "Headphone", "HP_L", - "Headphone", "HP_R", - "LINPUT1", "AMIC", - "RINPUT1", "AMIC"; - mediatek,audio-codec = <&wm8960>; - pinctrl-names = "default"; - pinctrl-0 = <&aud_pins_default>; - };
Convert mt2701-wm890 bindings from text to dtschema. This is used by MediaTek mt77623a/n SoC. Signed-off-by: Kartik Agarwala <agarwala.kartik@gmail.com> --- .../sound/mediatek,mt2701-wm8960.yaml | 59 +++++++++++++++++++ .../bindings/sound/mt2701-wm8960.txt | 24 -------- 2 files changed, 59 insertions(+), 24 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml delete mode 100644 Documentation/devicetree/bindings/sound/mt2701-wm8960.txt