| Message ID | c8b86184d9e6d078e9b9949d4837bc6e392c3f52.1709780590.git.haibo1.xu@intel.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add ACPI NUMA support for RISC-V | expand |
On Thu, Mar 07, 2024 at 04:47:56PM +0800, Haibo Xu wrote: > The acpi_numa_slit_init(), acpi_numa_memory_affinity_init() > and acpi_parse_cfmws() functions are common enough to be used > on platforms that support ACPI_NUMA(x86/arm64/loongarch). > Remove the condition to avoid long defined(CONFIG_ARCH) check > when new platform(riscv) support was enabled. > > Suggested-by: Sunil V L <sunilvl@ventanamicro.com> > Signed-off-by: Haibo Xu <haibo1.xu@intel.com> > --- > drivers/acpi/numa/srat.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 1946431c0eef..938c4adb7ec4 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -219,7 +219,6 @@ int __init srat_disabled(void) > return acpi_numa < 0; > } > > -#if defined(CONFIG_X86) || defined(CONFIG_ARM64) || defined(CONFIG_LOONGARCH) > /* > * Callback for SLIT parsing. pxm_to_node() returns NUMA_NO_NODE for > * I/O localities since SRAT does not list them. I/O localities are > @@ -351,13 +350,6 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > (*fake_pxm)++; > return 0; > } > -#else > -static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > - void *arg, const unsigned long table_end) > -{ > - return 0; > -} > -#endif /* defined(CONFIG_X86) || defined (CONFIG_ARM64) */ > > static int __init acpi_parse_slit(struct acpi_table_header *table) > { LGTM. Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c index 1946431c0eef..938c4adb7ec4 100644 --- a/drivers/acpi/numa/srat.c +++ b/drivers/acpi/numa/srat.c @@ -219,7 +219,6 @@ int __init srat_disabled(void) return acpi_numa < 0; } -#if defined(CONFIG_X86) || defined(CONFIG_ARM64) || defined(CONFIG_LOONGARCH) /* * Callback for SLIT parsing. pxm_to_node() returns NUMA_NO_NODE for * I/O localities since SRAT does not list them. I/O localities are @@ -351,13 +350,6 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, (*fake_pxm)++; return 0; } -#else -static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, - void *arg, const unsigned long table_end) -{ - return 0; -} -#endif /* defined(CONFIG_X86) || defined (CONFIG_ARM64) */ static int __init acpi_parse_slit(struct acpi_table_header *table) {
The acpi_numa_slit_init(), acpi_numa_memory_affinity_init() and acpi_parse_cfmws() functions are common enough to be used on platforms that support ACPI_NUMA(x86/arm64/loongarch). Remove the condition to avoid long defined(CONFIG_ARCH) check when new platform(riscv) support was enabled. Suggested-by: Sunil V L <sunilvl@ventanamicro.com> Signed-off-by: Haibo Xu <haibo1.xu@intel.com> --- drivers/acpi/numa/srat.c | 8 -------- 1 file changed, 8 deletions(-)