[v2,0/3] ASoC: Use snd_ctl_find_id_mixer() instead of open-coding

Message

Richard Fitzgerald April 1, 2024, 10:02 a.m. UTC

The first two patches change snd_soc_card_get_kcontrol() to use the
core snd_ctl_find_id_mixer() functionality instead of open-coding its
own list walk.

The last patch adds a KUnit test for this, which was tested on the
original and modified code.

Changes in V2:
Only change is in the KUnit test (patch #3) to make the const strings
more consty.

Richard Fitzgerald (3):
  ALSA: control: Introduce snd_ctl_find_id_mixer_locked()
  ASoC: soc-card: Use snd_ctl_find_id_mixer() instead of open-coding
  ASoC: soc-card: Add KUnit test case for snd_soc_card_get_kcontrol

 include/sound/control.h   |  23 +++++
 sound/soc/Kconfig         |   8 ++
 sound/soc/Makefile        |   4 +
 sound/soc/soc-card-test.c | 184 ++++++++++++++++++++++++++++++++++++++
 sound/soc/soc-card.c      |  21 +----
 5 files changed, 223 insertions(+), 17 deletions(-)
 create mode 100644 sound/soc/soc-card-test.c

Comments

Takashi Iwai April 2, 2024, 6:41 a.m. UTC | #1

On Mon, 01 Apr 2024 12:02:07 +0200,
Richard Fitzgerald wrote:
> 
> The first two patches change snd_soc_card_get_kcontrol() to use the
> core snd_ctl_find_id_mixer() functionality instead of open-coding its
> own list walk.
> 
> The last patch adds a KUnit test for this, which was tested on the
> original and modified code.
> 
> Changes in V2:
> Only change is in the KUnit test (patch #3) to make the const strings
> more consty.
> 
> Richard Fitzgerald (3):
>   ALSA: control: Introduce snd_ctl_find_id_mixer_locked()
>   ASoC: soc-card: Use snd_ctl_find_id_mixer() instead of open-coding
>   ASoC: soc-card: Add KUnit test case for snd_soc_card_get_kcontrol

I suppose this goes via Mark's tree.  Feel free to take my ack:

Reviewed-by: Takashi Iwai <[e-mail]>


thanks,

Takashi

Mark Brown April 2, 2024, 11:29 p.m. UTC | #2

On Mon, 01 Apr 2024 10:02:07 +0000, Richard Fitzgerald wrote:
> The first two patches change snd_soc_card_get_kcontrol() to use the
> core snd_ctl_find_id_mixer() functionality instead of open-coding its
> own list walk.
> 
> The last patch adds a KUnit test for this, which was tested on the
> original and modified code.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ALSA: control: Introduce snd_ctl_find_id_mixer_locked()
      commit: 08ea486a61451189b190c7b89e406b889cf693fa
[2/3] ASoC: soc-card: Use snd_ctl_find_id_mixer() instead of open-coding
      commit: 897cc72b08374c1224a9ded03c82dfc8e41f80c2
[3/3] ASoC: soc-card: Add KUnit test case for snd_soc_card_get_kcontrol
      commit: ef7784e41db73f3d31ce545227ebba4483479a26

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark