| Message ID | 20240402090349.30172-3-quic_kbajaj@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable various remoteprocs for qcm6490-idp and qcs6490-rb3gen2 | expand |
On Tue, 2 Apr 2024 at 12:04, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: > > Enable the ADSP, CDSP and WPSS that are found on qcs6490-rb3gen2. No MPSS even for GPS? Anyway, Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > index 97824c769ba3..a25431ddf922 100644 > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > @@ -434,6 +434,21 @@ &qupv3_id_0 { > status = "okay"; > }; > > +&remoteproc_adsp { > + firmware-name = "qcom/qcm6490/adsp.mbn"; > + status = "okay"; > +}; > + > +&remoteproc_cdsp { > + firmware-name = "qcom/qcm6490/cdsp.mbn"; > + status = "okay"; > +}; > + > +&remoteproc_wpss { > + firmware-name = "qcom/qcm6490/wpss.mbn"; > + status = "okay"; > +}; > + > &tlmm { > gpio-reserved-ranges = <32 2>, /* ADSP */ > <48 4>; /* NFC */ > -- > 2.42.0 > >
On Tue, Apr 02, 2024 at 02:33:49PM +0530, Komal Bajaj wrote: > Enable the ADSP, CDSP and WPSS that are found on qcs6490-rb3gen2. > > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > index 97824c769ba3..a25431ddf922 100644 > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > @@ -434,6 +434,21 @@ &qupv3_id_0 { > status = "okay"; > }; > > +&remoteproc_adsp { > + firmware-name = "qcom/qcm6490/adsp.mbn"; Should this be qcm6490? I already proposed a patch to add adsp and cdsp, using qcs6490, and this was merged earlier this week. Please pay attention and review patches posted on the public list. Either way, this will now have to be rebased on linux-next. Thanks, Bjorn > + status = "okay"; > +}; > + > +&remoteproc_cdsp { > + firmware-name = "qcom/qcm6490/cdsp.mbn"; > + status = "okay"; > +}; > + > +&remoteproc_wpss { > + firmware-name = "qcom/qcm6490/wpss.mbn"; > + status = "okay"; > +}; > + > &tlmm { > gpio-reserved-ranges = <32 2>, /* ADSP */ > <48 4>; /* NFC */ > -- > 2.42.0 >
On 4/2/2024 2:47 PM, Dmitry Baryshkov wrote: > On Tue, 2 Apr 2024 at 12:04, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: >> >> Enable the ADSP, CDSP and WPSS that are found on qcs6490-rb3gen2. > > No MPSS even for GPS? Earlier was thinking of sending a separate patch for that. Anyway, will add MPSS too in the next series. Thanks Komal > > Anyway, > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >> >> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> index 97824c769ba3..a25431ddf922 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> @@ -434,6 +434,21 @@ &qupv3_id_0 { >> status = "okay"; >> }; >> >> +&remoteproc_adsp { >> + firmware-name = "qcom/qcm6490/adsp.mbn"; >> + status = "okay"; >> +}; >> + >> +&remoteproc_cdsp { >> + firmware-name = "qcom/qcm6490/cdsp.mbn"; >> + status = "okay"; >> +}; >> + >> +&remoteproc_wpss { >> + firmware-name = "qcom/qcm6490/wpss.mbn"; >> + status = "okay"; >> +}; >> + >> &tlmm { >> gpio-reserved-ranges = <32 2>, /* ADSP */ >> <48 4>; /* NFC */ >> -- >> 2.42.0 >> >> > >
On 4/5/2024 8:23 AM, Bjorn Andersson wrote: > On Tue, Apr 02, 2024 at 02:33:49PM +0530, Komal Bajaj wrote: >> Enable the ADSP, CDSP and WPSS that are found on qcs6490-rb3gen2. >> >> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> index 97824c769ba3..a25431ddf922 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> @@ -434,6 +434,21 @@ &qupv3_id_0 { >> status = "okay"; >> }; >> >> +&remoteproc_adsp { >> + firmware-name = "qcom/qcm6490/adsp.mbn"; > > Should this be qcm6490? > > > I already proposed a patch to add adsp and cdsp, using qcs6490, and this > was merged earlier this week. Please pay attention and review patches > posted on the public list. Apologies, I missed that. Will drop adsp and cdsp firmware path update in the next series. Rebase this change on top of your change, also will add the firmware path update for modem for GPS usecase. Thanks Komal > > Either way, this will now have to be rebased on linux-next. > > Thanks, > Bjorn > >> + status = "okay"; >> +}; >> + >> +&remoteproc_cdsp { >> + firmware-name = "qcom/qcm6490/cdsp.mbn"; >> + status = "okay"; >> +}; >> + >> +&remoteproc_wpss { >> + firmware-name = "qcom/qcm6490/wpss.mbn"; >> + status = "okay"; >> +}; >> + >> &tlmm { >> gpio-reserved-ranges = <32 2>, /* ADSP */ >> <48 4>; /* NFC */ >> -- >> 2.42.0 >>
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts index 97824c769ba3..a25431ddf922 100644 --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts @@ -434,6 +434,21 @@ &qupv3_id_0 { status = "okay"; }; +&remoteproc_adsp { + firmware-name = "qcom/qcm6490/adsp.mbn"; + status = "okay"; +}; + +&remoteproc_cdsp { + firmware-name = "qcom/qcm6490/cdsp.mbn"; + status = "okay"; +}; + +&remoteproc_wpss { + firmware-name = "qcom/qcm6490/wpss.mbn"; + status = "okay"; +}; + &tlmm { gpio-reserved-ranges = <32 2>, /* ADSP */ <48 4>; /* NFC */
Enable the ADSP, CDSP and WPSS that are found on qcs6490-rb3gen2. Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+) -- 2.42.0