| Message ID | 20240402091228.110362-2-andrei.simion@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix the regulator-state-standby definition | expand |
On 02/04/2024 11:12, Andrei Simion wrote: > Replace regulator-suspend-voltage with regulator-suspend-microvolt. Why? Please explain what is the bug and how it manifests itself. Is one property incorrect and other correct? Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Hint: there is no "boot" > Best regards, Krzysztof
On 02.04.2024 13:39, Krzysztof Kozlowski wrote: > [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 02/04/2024 11:12, Andrei Simion wrote: >> Replace regulator-suspend-voltage with regulator-suspend-microvolt. > > Why? > at91-sama7g5ek.dtb: mcp16502@5b: regulators:VDD_(CORE|OTHER)|LDO[1-2]: regulator-state-standby 'regulator-suspend-voltage' does not match any of the regexes 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/regulator/microchip,mcp16502.yaml# no property named regulator-suspend-voltage in https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/regulator/regulator.yaml so if it is using this property there will be no effect as it was expected in https://github.com/torvalds/linux/commit/85b1304b9daa06367139b471789c7ddb76250b9f > Please explain what is the bug and how it manifests itself. Is one > property incorrect and other correct? > The main reason is explained in the cover-letter but if you ask me to explain in each commit I will do it in next version. > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. > Hint: there is no "boot" > Yes, in hurry I slipped that "boot" in subject. >> > > Best regards, > Krzysztof >
On 02/04/2024 13:27, Andrei.Simion@microchip.com wrote: > On 02.04.2024 13:39, Krzysztof Kozlowski wrote: >> [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] >> >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 02/04/2024 11:12, Andrei Simion wrote: >>> Replace regulator-suspend-voltage with regulator-suspend-microvolt. >> >> Why? >> > > at91-sama7g5ek.dtb: mcp16502@5b: regulators:VDD_(CORE|OTHER)|LDO[1-2]: > regulator-state-standby 'regulator-suspend-voltage' does not match any of > the regexes 'pinctrl-[0-9]+' from schema > $id: http://devicetree.org/schemas/regulator/microchip,mcp16502.yaml# > > no property named regulator-suspend-voltage in > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/regulator/regulator.yaml > so if it is using this property there will be no effect as it was expected in > https://github.com/torvalds/linux/commit/85b1304b9daa06367139b471789c7ddb76250b9f > >> Please explain what is the bug and how it manifests itself. Is one >> property incorrect and other correct? >> > The main reason is explained in the cover-letter but if you ask me to explain in each commit I will do it in next version. Cover letter does not go to commit history. Each commit should explain why you are doing it. Usually piece of the warning is quite self-explanatory, thus one easy way to achieve the point - answer why. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts b/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts index 217e9b96c61e..20b2497657ae 100644 --- a/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts +++ b/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts @@ -293,7 +293,7 @@ vddcore: VDD_CORE { regulator-state-standby { regulator-on-in-suspend; - regulator-suspend-voltage = <1150000>; + regulator-suspend-microvolt = <1150000>; regulator-mode = <4>; }; @@ -314,7 +314,7 @@ vddcpu: VDD_OTHER { regulator-state-standby { regulator-on-in-suspend; - regulator-suspend-voltage = <1050000>; + regulator-suspend-microvolt = <1050000>; regulator-mode = <4>; }; @@ -331,7 +331,7 @@ vldo1: LDO1 { regulator-always-on; regulator-state-standby { - regulator-suspend-voltage = <1800000>; + regulator-suspend-microvolt = <1800000>; regulator-on-in-suspend; }; @@ -346,7 +346,7 @@ vldo2: LDO2 { regulator-max-microvolt = <3700000>; regulator-state-standby { - regulator-suspend-voltage = <1800000>; + regulator-suspend-microvolt = <1800000>; regulator-on-in-suspend; };
Replace regulator-suspend-voltage with regulator-suspend-microvolt. Fixes: 85b1304b9daa ("ARM: dts: at91: sama7g5ek: set regulator voltages for standby state") Signed-off-by: Andrei Simion <andrei.simion@microchip.com> --- arch/arm/boot/dts/microchip/at91-sama7g5ek.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)