| Message ID | 20240328151954.2517368-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: imx7s-warp: Pass OV2680 link-frequencies | expand |
On Thu, 28 Mar 2024 12:19:54 -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Since commit 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint > property verification") the ov2680 no longer probes on a imx7s-warp7: > > ov2680 1-0036: error -EINVAL: supported link freq 330000000 not found > ov2680 1-0036: probe with driver ov2680 failed with error -22 > > Fix it by passing the required 'link-frequencies' property as > recommended by: > > https://www.kernel.org/doc/html/v6.9-rc1/driver-api/media/camera-sensor.html#handling-clocks > > Cc: stable@vger.kernel.org > Fixes: 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint property verification") > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > arch/arm/boot/dts/nxp/imx/imx7s-warp.dts | 1 + > 1 file changed, 1 insertion(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y nxp/imx/imx7s-warp.dtb' for 20240328151954.2517368-1-festevam@gmail.com: arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36: port:endpoint: Unevaluated properties are not allowed ('clock-lanes', 'data-lanes', 'link-frequencies' were unexpected) from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml#
On Thu, Mar 28, 2024 at 12:19:54PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Since commit 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint > property verification") the ov2680 no longer probes on a imx7s-warp7: > > ov2680 1-0036: error -EINVAL: supported link freq 330000000 not found > ov2680 1-0036: probe with driver ov2680 failed with error -22 > > Fix it by passing the required 'link-frequencies' property as > recommended by: > > https://www.kernel.org/doc/html/v6.9-rc1/driver-api/media/camera-sensor.html#handling-clocks > > Cc: stable@vger.kernel.org > Fixes: 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint property verification") > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied, thanks!
On Thu, Mar 28, 2024 at 04:01:02PM -0500, Rob Herring wrote: > > On Thu, 28 Mar 2024 12:19:54 -0300, Fabio Estevam wrote: > > From: Fabio Estevam <festevam@denx.de> > > > > Since commit 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint > > property verification") the ov2680 no longer probes on a imx7s-warp7: > > > > ov2680 1-0036: error -EINVAL: supported link freq 330000000 not found > > ov2680 1-0036: probe with driver ov2680 failed with error -22 > > > > Fix it by passing the required 'link-frequencies' property as > > recommended by: > > > > https://www.kernel.org/doc/html/v6.9-rc1/driver-api/media/camera-sensor.html#handling-clocks > > > > Cc: stable@vger.kernel.org > > Fixes: 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint property verification") > > Signed-off-by: Fabio Estevam <festevam@denx.de> > > --- > > arch/arm/boot/dts/nxp/imx/imx7s-warp.dts | 1 + > > 1 file changed, 1 insertion(+) > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y nxp/imx/imx7s-warp.dtb' for 20240328151954.2517368-1-festevam@gmail.com: > > arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36: port:endpoint: Unevaluated properties are not allowed ('clock-lanes', 'data-lanes', 'link-frequencies' were unexpected) > from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml# So it sounds like that the bindings doc needs an update to include 'link-frequencies'? Shawn
Hi Shawn, On Tue, Apr 2, 2024 at 9:53 PM Shawn Guo <shawnguo2@yeah.net> wrote: > So it sounds like that the bindings doc needs an update to include > 'link-frequencies'? Correct. I have already submitted the binding patch: https://lore.kernel.org/linux-devicetree/20240402174028.205434-2-festevam@gmail.com/
diff --git a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts index ba7231b364bb..7bab113ca6da 100644 --- a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts +++ b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts @@ -210,6 +210,7 @@ ov2680_to_mipi: endpoint { remote-endpoint = <&mipi_from_sensor>; clock-lanes = <0>; data-lanes = <1>; + link-frequencies = /bits/ 64 <330000000>; }; }; };