mbox series

[v2,0/2,RESEND] wifi: ath12k: refactor the link capable flag

Message ID 20240403042056.1504209-1-quic_periyasa@quicinc.com (mailing list archive)
Headers show
Series wifi: ath12k: refactor the link capable flag | expand

Message

Karthikeyan Periyasamy April 3, 2024, 4:20 a.m. UTC 
extend the link capable flag to accommodate inter-device capability.

v2:
 - Rename the terminology from chip to device

Karthikeyan Periyasamy (2):
  wifi: ath12k: extend the link capable flag
  wifi: ath12k: fix link capable flags

 drivers/net/wireless/ath/ath12k/core.c |  2 +-
 drivers/net/wireless/ath/ath12k/core.h | 23 ++++++++++++++++++++---
 drivers/net/wireless/ath/ath12k/mhi.c  |  2 +-
 drivers/net/wireless/ath/ath12k/qmi.c  |  4 +++-
 4 files changed, 25 insertions(+), 6 deletions(-)


base-commit: fe7e1b830cf3c0272aa4eaf367c4c7b29c169c3d

Comments

Kalle Valo April 3, 2024, 10:38 a.m. UTC | #1 
Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:

> extend the link capable flag to accommodate inter-device capability.
>
> v2:
>  - Rename the terminology from chip to device
>
> Karthikeyan Periyasamy (2):
>   wifi: ath12k: extend the link capable flag
>   wifi: ath12k: fix link capable flags

Why the resend? I'm not really a fan of these "RESEND" versions. If you
need to resend something simply just increase the version number (in
this case to v3) and explain in the change log why you sent v3. That's a
lot more clear for everyone than having "v2", "v2 RESEND", "v2 RESEND
RESEND" and what not. It's not like we are running out of version
numbers ;)

But no need to resend because of this :)
Karthikeyan Periyasamy April 3, 2024, 11:21 a.m. UTC | #2 
On 4/3/2024 4:08 PM, Kalle Valo wrote:
> Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:
> 
>> extend the link capable flag to accommodate inter-device capability.
>>
>> v2:
>>   - Rename the terminology from chip to device
>>
>> Karthikeyan Periyasamy (2):
>>    wifi: ath12k: extend the link capable flag
>>    wifi: ath12k: fix link capable flags
> 
> Why the resend? 

I missed the version log in the commit message.

I'm not really a fan of these "RESEND" versions. If you
> need to resend something simply just increase the version number (in
> this case to v3) and explain in the change log why you sent v3. That's a
> lot more clear for everyone than having "v2", "v2 RESEND", "v2 RESEND
> RESEND" and what not. It's not like we are running out of version
> numbers ;)
> 
> But no need to resend because of this :)
> 

Sure, i got it.
Jeff Johnson April 3, 2024, 3 p.m. UTC | #3 
On 4/3/2024 4:21 AM, Karthikeyan Periyasamy wrote:
> On 4/3/2024 4:08 PM, Kalle Valo wrote:
>> Why the resend? 
> 
> I missed the version log in the commit message.

In that case in the future, just reply to your cover letter and say you missed
including the versioning info, and put it in the reply.