| Message ID | 20240307135109.3778316-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | gpiolib: Get rid of gpio_free_array()/gpio_request_array() | expand |
On Thu, Mar 7, 2024 at 2:51 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > There are only two users left of the gpio_free_array()/gpio_request_array(). > Convert them to very basic legacy APIs (it requires much less work for > now) and drop no more used gpio_free_array()/gpio_request_array(). That's reasonable and makes the kernel a better place. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Thu, Mar 07, 2024 at 03:36:18PM +0100, Linus Walleij wrote: > On Thu, Mar 7, 2024 at 2:51 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > There are only two users left of the gpio_free_array()/gpio_request_array(). > > Convert them to very basic legacy APIs (it requires much less work for > > now) and drop no more used gpio_free_array()/gpio_request_array(). > > That's reasonable and makes the kernel a better place. > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Thank you! Bart, do you want me to take it via my tree or you want to take directly?
On Wed, Mar 13, 2024 at 12:14 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Mar 07, 2024 at 03:36:18PM +0100, Linus Walleij wrote: > > On Thu, Mar 7, 2024 at 2:51 PM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > There are only two users left of the gpio_free_array()/gpio_request_array(). > > > Convert them to very basic legacy APIs (it requires much less work for > > > now) and drop no more used gpio_free_array()/gpio_request_array(). > > > > That's reasonable and makes the kernel a better place. > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Thank you! > > Bart, do you want me to take it via my tree or you want to take directly? > We don't have Acks from the relevant arch maintainers yet. I can pick it up but I won't do it before the end of the merge window anyway. Bart
On Wed, Mar 13, 2024 at 12:47:58PM +0100, Bartosz Golaszewski wrote: > On Wed, Mar 13, 2024 at 12:14 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Mar 07, 2024 at 03:36:18PM +0100, Linus Walleij wrote: > > > On Thu, Mar 7, 2024 at 2:51 PM Andy Shevchenko > > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > > There are only two users left of the gpio_free_array()/gpio_request_array(). > > > > Convert them to very basic legacy APIs (it requires much less work for > > > > now) and drop no more used gpio_free_array()/gpio_request_array(). > > > > > > That's reasonable and makes the kernel a better place. > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > > > Thank you! > > > > Bart, do you want me to take it via my tree or you want to take directly? > > We don't have Acks from the relevant arch maintainers yet. True. But I haven't noticed much maintainer's activity WRT PXA code. I dunno who can be the best to Ack these. Arnd? > I can pick it up but I won't do it before the end of the merge window anyway. Sure.
On Thu, Mar 07, 2024 at 03:49:02PM +0200, Andy Shevchenko wrote: > There are only two users left of the gpio_free_array()/gpio_request_array(). > Convert them to very basic legacy APIs (it requires much less work for > now) and drop no more used gpio_free_array()/gpio_request_array(). Any comments on this? We really want to get rid of the legacy APIs. While at here, would be also good to have a comment/tag for https://lore.kernel.org/r/20240327193138.2385910-7-andriy.shevchenko@linux.intel.com
On Tue, Apr 2, 2024 at 8:43 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Mar 07, 2024 at 03:49:02PM +0200, Andy Shevchenko wrote: > > There are only two users left of the gpio_free_array()/gpio_request_array(). > > Convert them to very basic legacy APIs (it requires much less work for > > now) and drop no more used gpio_free_array()/gpio_request_array(). > > Any comments on this? We really want to get rid of the legacy APIs. > I applied the patches, they only touch the GPIO part in legacy platform code. It's not very controversial IMO. Bart
On Wed, Apr 03, 2024 at 01:09:13PM +0200, Bartosz Golaszewski wrote: > On Tue, Apr 2, 2024 at 8:43 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Thu, Mar 07, 2024 at 03:49:02PM +0200, Andy Shevchenko wrote: > > > There are only two users left of the gpio_free_array()/gpio_request_array(). > > > Convert them to very basic legacy APIs (it requires much less work for > > > now) and drop no more used gpio_free_array()/gpio_request_array(). > > > > Any comments on this? We really want to get rid of the legacy APIs. > > I applied the patches, they only touch the GPIO part in legacy > platform code. It's not very controversial IMO. Thank you! FWIW, In case of issue(s) I would like to help to fix, but I don't think it will be even one.
There are only two users left of the gpio_free_array()/gpio_request_array(). Convert them to very basic legacy APIs (it requires much less work for now) and drop no more used gpio_free_array()/gpio_request_array(). (Not tested) Andy Shevchenko (3): ARM: pxa: spitz: Open code gpio_request_array() ARM: sa1100: Open code gpio_request_array() gpiolib: legacy: Remove unused gpio_request_array() and gpio_free_array() Documentation/driver-api/gpio/legacy.rst | 16 ------- .../zh_CN/driver-api/gpio/legacy.rst | 16 ------- Documentation/translations/zh_TW/gpio.txt | 17 ------- arch/arm/mach-pxa/spitz_pm.c | 22 +++++---- arch/arm/mach-sa1100/h3600.c | 47 ++++++++++++++----- drivers/gpio/gpiolib-legacy.c | 39 --------------- include/linux/gpio.h | 15 ------ 7 files changed, 48 insertions(+), 124 deletions(-)