Message ID | 6cfb0e5251c3a59a156e70bcf6a0cc74aa764faa.1711985490.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
---|---|
State | Accepted, archived |
Headers | show |
Series | clk: nxp: Remove an unused field in struct lpc18xx_pll | expand |
On 4/1/24 18:31, Christophe JAILLET wrote: > In "struct lpc18xx_pll", the 'lock' field is unused. > Remove it. > > Found with cppcheck, unusedStructMember. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Thank you for the change! Acked-by: Vladimir Zapolskiy <vz@mleia.com> -- Best wishes, Vladimir
Quoting Christophe JAILLET (2024-04-01 08:31:53) > In "struct lpc18xx_pll", the 'lock' field is unused. > Remove it. > > Found with cppcheck, unusedStructMember. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- Applied to clk-next
diff --git a/drivers/clk/nxp/clk-lpc18xx-cgu.c b/drivers/clk/nxp/clk-lpc18xx-cgu.c index 69ebf65081b8..81efa885069b 100644 --- a/drivers/clk/nxp/clk-lpc18xx-cgu.c +++ b/drivers/clk/nxp/clk-lpc18xx-cgu.c @@ -250,7 +250,6 @@ static struct lpc18xx_cgu_base_clk lpc18xx_cgu_base_clks[] = { struct lpc18xx_pll { struct clk_hw hw; void __iomem *reg; - spinlock_t *lock; u8 flags; };
In "struct lpc18xx_pll", the 'lock' field is unused. Remove it. Found with cppcheck, unusedStructMember. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile tested only. --- drivers/clk/nxp/clk-lpc18xx-cgu.c | 1 - 1 file changed, 1 deletion(-)