| Message ID | cover.1712205900.git.ysato@users.sourceforge.jp (mailing list archive) |
|---|---|
| Headers | show |
| Series | Device Tree support for SH7751 based board | expand |
On Thu, Apr 04, 2024 at 01:59:25PM +0900, Yoshinori Sato wrote: > This is an updated version of something I wrote about 7 years ago. > Minimum support for R2D-plus and LANDISK. > I think R2D-1 will work if you add AX88796 to dts. > And board-specific functions and SCI's SPI functions are not supported. > > You can get it working with qemu found here. > https://gitlab.com/yoshinori.sato/qemu/-/tree/landisk Why send this as one huge series? These are the mailing lists that you have on CC: linux-ide, devicetree, linux-kernel, linux-renesas-soc, linux-clk, dri-devel, linux-pci, linux-serial, linux-fbdev I really think that you will be able to get all these changes accepted much faster if you split this series in to one series per subsystem/mailing list. Kind regards, Niklas
On Thu, Apr 04, 2024 at 01:59:25PM +0900, Yoshinori Sato wrote: > This is an updated version of something I wrote about 7 years ago. > Minimum support for R2D-plus and LANDISK. > I think R2D-1 will work if you add AX88796 to dts. > And board-specific functions and SCI's SPI functions are not supported. My comments/questions from https://lore.kernel.org/r/20231120181600.GA205977@bhelgaas https://lore.kernel.org/r/20231016172742.GA1215127@bhelgaas still apply.
On 4/4/24 00:14, Yoshinori Sato wrote: > Sorry. previus mail is thread broken. > > This is an updated version of something I wrote about 7 years ago. > Minimum support for R2D-plus and LANDISK. > I think R2D-1 will work if you add AX88796 to dts. > And board-specific functions and SCI's SPI functions are not supported. > > You can get it working with qemu found here. > https://gitlab.com/yoshinori.sato/qemu/-/tree/landisk I was hoping to get a device tree kernel to boot with static device tree on the existing linux-sh qemu. (The main new features I want from an updated sh4 qemu are a working battery backed up clock and more physical memory...) Is there somewhere I can get the kernel patch list in git or something? I haven't got tooling set up to conveniently fish 37 patches out of an mbox file, and would like to test this. (I moved last month and my physical sh7751 hardware is in a storage container.) Thanks, Rob
Hi Rob, On Fri, Apr 5, 2024 at 2:09 PM Rob Landley <rob@landley.net> wrote: > On 4/4/24 00:14, Yoshinori Sato wrote: > > This is an updated version of something I wrote about 7 years ago. > > Minimum support for R2D-plus and LANDISK. > > I think R2D-1 will work if you add AX88796 to dts. > > And board-specific functions and SCI's SPI functions are not supported. > > > > You can get it working with qemu found here. > > https://gitlab.com/yoshinori.sato/qemu/-/tree/landisk > > I was hoping to get a device tree kernel to boot with static device tree on the > existing linux-sh qemu. (The main new features I want from an updated sh4 qemu > are a working battery backed up clock and more physical memory...) > > Is there somewhere I can get the kernel patch list in git or something? I > haven't got tooling set up to conveniently fish 37 patches out of an mbox file, > and would like to test this. (I moved last month and my physical sh7751 hardware > is in a storage container.) b4 am fe69e328ec617f91a09fa2d00506ba1a664085d8.1712207606.git.ysato@users.sourceforge.jp git am ./v7_20240404_ysato_sh_passing_fdt_address_to_kernel_startup.mbx Gr{oetje,eeting}s, Geert
On 4/5/24 07:21, Geert Uytterhoeven wrote: > Hi Rob, > > On Fri, Apr 5, 2024 at 2:09 PM Rob Landley <rob@landley.net> wrote: >> On 4/4/24 00:14, Yoshinori Sato wrote: >> > This is an updated version of something I wrote about 7 years ago. >> > Minimum support for R2D-plus and LANDISK. >> > I think R2D-1 will work if you add AX88796 to dts. >> > And board-specific functions and SCI's SPI functions are not supported. >> > >> > You can get it working with qemu found here. >> > https://gitlab.com/yoshinori.sato/qemu/-/tree/landisk >> >> I was hoping to get a device tree kernel to boot with static device tree on the >> existing linux-sh qemu. (The main new features I want from an updated sh4 qemu >> are a working battery backed up clock and more physical memory...) >> >> Is there somewhere I can get the kernel patch list in git or something? I >> haven't got tooling set up to conveniently fish 37 patches out of an mbox file, >> and would like to test this. (I moved last month and my physical sh7751 hardware >> is in a storage container.) > > b4 am fe69e328ec617f91a09fa2d00506ba1a664085d8.1712207606.git.ysato@users.sourceforge.jp > git am ./v7_20240404_ysato_sh_passing_fdt_address_to_kernel_startup.mbx $ b4 bash: b4: command not found $ aptitude show b4 E: Unable to locate package b4 $ aptitude search b4 p b43-fwcutter - utility for extracting Broadcom 43xx firmw ... Let's see, google says it's a random python3 tool, probably wants a newer python3 version than I've got because everything that uses python3 does, it says "you can run it directly from the git repository"... $ ./b4.sh Traceback (most recent call last): File "/home/landley/b4/src/b4/command.py", line 10, in <module> import b4 File "/home/landley/b4/src/b4/__init__.py", line 37, in <module> from typing import Optional, Tuple, Set, List, BinaryIO, Union, Sequence, Literal, Iterator, Dict ImportError: cannot import name 'Literal' from 'typing' (/usr/lib/python3.7/typing.py) Oh well. Good luck with your patches, hope it works out. Rob
On Fri, 2024-04-05 at 07:17 -0500, Rob Landley wrote: > Is there somewhere I can get the kernel patch list in git or something? I > haven't got tooling set up to conveniently fish 37 patches out of an mbox file, > and would like to test this. (I moved last month and my physical sh7751 hardware > is in a storage container.) Try the tool "b4" which allows you to download the patch set as an mbox file. The mbox file can be applied with "git am <mbox file>". Adrian
On Fri, 2024-04-05 at 13:57 -0500, Rob Landley wrote: > $ b4 > bash: b4: command not found > $ aptitude show b4 > E: Unable to locate package b4 > $ aptitude search b4 > p b43-fwcutter - utility for extracting Broadcom 43xx firmw > ... glaubitz@z6:~> dpkg -S `which b4` b4: /usr/bin/b4 glaubitz@z6:~> apt show b4 Package: b4 Version: 0.12.0-2 Priority: optional Section: python Maintainer: Héctor Orón Martínez <zumbi@debian.org> Installed-Size: 373 kB Depends: python3-dkim (>= 1.0.5), python3-dnspython (>= 2.1.0), python3-requests (>= 2.24.0), python3-patatt (>= 0.6.3), git-filter-repo (>= 2.30), python3:any Homepage: https://git.kernel.org/pub/scm/utils/b4/b4.git Download-Size: 76.6 kB APT-Manual-Installed: yes APT-Sources: http://ftp.debian.org/debian bookworm/main amd64 Packages Description: helper utility to work with patches made available via a public-inbox archive This is a helper utility to work with patches made available via a public-inbox archive like lore.kernel.org. It is written to make it easier to participate in a patch-based workflows, like those used in the Linux kernel development. . This package installs the application and library for Python 3. glaubitz@z6:~> Alternatively, install it via pip: glaubitz@z6:~> pip install --user --break-system-packages b4 Adrian
Hi Rob, On Fri, Apr 5, 2024 at 8:48 PM Rob Landley <rob@landley.net> wrote: > On 4/5/24 07:21, Geert Uytterhoeven wrote: > > On Fri, Apr 5, 2024 at 2:09 PM Rob Landley <rob@landley.net> wrote: > >> On 4/4/24 00:14, Yoshinori Sato wrote: > >> > This is an updated version of something I wrote about 7 years ago. > >> > Minimum support for R2D-plus and LANDISK. > >> > I think R2D-1 will work if you add AX88796 to dts. > >> > And board-specific functions and SCI's SPI functions are not supported. > >> > > >> > You can get it working with qemu found here. > >> > https://gitlab.com/yoshinori.sato/qemu/-/tree/landisk > >> > >> I was hoping to get a device tree kernel to boot with static device tree on the > >> existing linux-sh qemu. (The main new features I want from an updated sh4 qemu > >> are a working battery backed up clock and more physical memory...) > >> > >> Is there somewhere I can get the kernel patch list in git or something? I > >> haven't got tooling set up to conveniently fish 37 patches out of an mbox file, > >> and would like to test this. (I moved last month and my physical sh7751 hardware > >> is in a storage container.) > > > > b4 am fe69e328ec617f91a09fa2d00506ba1a664085d8.1712207606.git.ysato@users.sourceforge.jp > > git am ./v7_20240404_ysato_sh_passing_fdt_address_to_kernel_startup.mbx > > $ b4 > bash: b4: command not found [...] > Oh well. Good luck with your patches, hope it works out. If you cannot/do not want to install b4, you can stick the Message-Id into lore, and download the mbox from https://lore.kernel.org/all/fe69e328ec617f91a09fa2d00506ba1a664085d8.1712207606.git.ysato@users.sourceforge.jp Gr{oetje,eeting}s, Geert
On Fri, Apr 05, 2024 at 01:57:32PM -0500, Rob Landley wrote: > Let's see, google says it's a random python3 tool, probably wants a newer > python3 version than I've got because everything that uses python3 does, it says > "you can run it directly from the git repository"... > > $ ./b4.sh > Traceback (most recent call last): > File "/home/landley/b4/src/b4/command.py", line 10, in <module> > import b4 > File "/home/landley/b4/src/b4/__init__.py", line 37, in <module> > from typing import Optional, Tuple, Set, List, BinaryIO, Union, Sequence, > Literal, Iterator, Dict > ImportError: cannot import name 'Literal' from 'typing' > (/usr/lib/python3.7/typing.py) Python 3.7 is EOL as of last June, which is why you're seeing this error trying to run the latest master branch. To be able to use a EOL version of Python, you will need to run a contemporary release of b4, which is 0.11. To do so, you may check out the stable-0.11.y branch and repeat this operation. -K
Hi Yoshinori, On Thu, 2024-04-04 at 14:14 +0900, Yoshinori Sato wrote: > Sorry. previus mail is thread broken. > > This is an updated version of something I wrote about 7 years ago. > Minimum support for R2D-plus and LANDISK. > I think R2D-1 will work if you add AX88796 to dts. > And board-specific functions and SCI's SPI functions are not supported. > > You can get it working with qemu found here. > https://gitlab.com/yoshinori.sato/qemu/-/tree/landisk > > v7 changes. > - sh/kernel/setup.c: fix kernel parameter handling. > - clk-sh7750.c: cleanup. > - sh_tmu.c: cleanup. > - irq-renesas-sh7751.c: IPR definition move to code. > - irq-renesas-sh7751irl.c: update register definition. > - pci-sh7751.c: Register initialization fix. > - sm501 and sm501fb: Re-design Device Tree properties. Could you push your v7 version to your Gitlab [1] repository so I can fetch it from there? Thanks, Adrian > [1] https://gitlab.com/yoshinori.sato/linux
On Sat, 18 May 2024 18:08:30 +0900, John Paul Adrian Glaubitz wrote: > > Hi Yoshinori, > > On Thu, 2024-04-04 at 14:14 +0900, Yoshinori Sato wrote: > > Sorry. previus mail is thread broken. > > > > This is an updated version of something I wrote about 7 years ago. > > Minimum support for R2D-plus and LANDISK. > > I think R2D-1 will work if you add AX88796 to dts. > > And board-specific functions and SCI's SPI functions are not supported. > > > > You can get it working with qemu found here. > > https://gitlab.com/yoshinori.sato/qemu/-/tree/landisk > > > > v7 changes. > > - sh/kernel/setup.c: fix kernel parameter handling. > > - clk-sh7750.c: cleanup. > > - sh_tmu.c: cleanup. > > - irq-renesas-sh7751.c: IPR definition move to code. > > - irq-renesas-sh7751irl.c: update register definition. > > - pci-sh7751.c: Register initialization fix. > > - sm501 and sm501fb: Re-design Device Tree properties. > > Could you push your v7 version to your Gitlab [1] repository so I can fetch > it from there? updated it. I'll be posting v8 soon. > Thanks, > Adrian > > > [1] https://gitlab.com/yoshinori.sato/linux > > -- > .''`. John Paul Adrian Glaubitz > : :' : Debian Developer > `. `' Physicist > `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 >
Hi Yoshinori, On Mon, 2024-05-20 at 22:06 +0900, Yoshinori Sato wrote: > On Sat, 18 May 2024 18:08:30 +0900, > John Paul Adrian Glaubitz wrote: > > > > Hi Yoshinori, > > > > On Thu, 2024-04-04 at 14:14 +0900, Yoshinori Sato wrote: > > > Sorry. previus mail is thread broken. > > > > > > This is an updated version of something I wrote about 7 years ago. > > > Minimum support for R2D-plus and LANDISK. > > > I think R2D-1 will work if you add AX88796 to dts. > > > And board-specific functions and SCI's SPI functions are not supported. > > > > > > You can get it working with qemu found here. > > > https://gitlab.com/yoshinori.sato/qemu/-/tree/landisk > > > > > > v7 changes. > > > - sh/kernel/setup.c: fix kernel parameter handling. > > > - clk-sh7750.c: cleanup. > > > - sh_tmu.c: cleanup. > > > - irq-renesas-sh7751.c: IPR definition move to code. > > > - irq-renesas-sh7751irl.c: update register definition. > > > - pci-sh7751.c: Register initialization fix. > > > - sm501 and sm501fb: Re-design Device Tree properties. > > > > Could you push your v7 version to your Gitlab [1] repository so I can fetch > > it from there? > > updated it. Thanks! > I'll be posting v8 soon. Sounds good! Maybe we can start merging the patches that contain fixes only and that have already been reviewed. This way, we can reduce the overall size of the series a bit. Adrian
On Mon, May 20, 2024 at 5:25 PM John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > On Mon, 2024-05-20 at 22:06 +0900, Yoshinori Sato wrote: > > I'll be posting v8 soon. > > Sounds good! Maybe we can start merging the patches that contain fixes only > and that have already been reviewed. This way, we can reduce the overall size > of the series a bit. +1 Gr{oetje,eeting}s, Geert
This is an updated version of something I wrote about 7 years ago. Minimum support for R2D-plus and LANDISK. I think R2D-1 will work if you add AX88796 to dts. And board-specific functions and SCI's SPI functions are not supported. You can get it working with qemu found here. https://gitlab.com/yoshinori.sato/qemu/-/tree/landisk v7 changes. - sh/kernel/setup.c: fix kernel parameter handling. - clk-sh7750.c: cleanup. - sh_tmu.c: cleanup. - irq-renesas-sh7751.c: IPR definition move to code. - irq-renesas-sh7751irl.c: update register definition. - pci-sh7751.c: Register initialization fix. - sm501 and sm501fb: Re-design Device Tree properties. v6 changes. - pci-sh7751: merge register define. - pci-sh7751: use 'dma-ranges' property. - pci-sh7751: rename general PCI properties. - sm501 and sm501fb: Re-design Device Tree properties. - sh/kernel/setup: cleanup command line setup. - irq-sh7751.c: some cleanup. v5 changes. - pci-sh7751: revert header changes. and some fix in previuous driver. - sh/kernel/iomap.c: Use SH io functions. - sm501 and sm501fb: re-write DT support. v4 changes. - cpg-sh7750: use clk-divider and clk-gate. - pci-sh7751: unified header files to old PCI driver. - irq-renesas-sh7751: IPR registers direct mapping. - irq-renesas-sh7751irl: useful register bit mapping. - sm501 and sm501fb: re-write dt parser. - j2_minus: fix build error. - dt-binding schema: fix some errors. - *.dts: cleanup. v3 changes. - Rewrite clk drivers. - Added sh_tmu to OF support. - Cleanup PCI stuff. - Update sm501 and sm501fb OF support. - Update devicetree and documents. v2 changes. - Rebasing v6,6-rc1 - re-write irqchip driver. - Add binding documents. - Cleanup review comment. Yoshinori Sato (37): sh: passing FDT address to kernel startup. sh: Kconfig unified OF supported targets. sh: Enable OF support for build and configuration. dt-bindings: interrupt-controller: Add header for Renesas SH3/4 INTC. sh: GENERIC_IRQ_CHIP support for CONFIG_OF=y sh: kernel/setup Update DT support. sh: Fix COMMON_CLK support in CONFIG_OF=y. clocksource: sh_tmu: CLOCKSOURCE support. dt-binding: Add compatible SH7750 SoC sh: Common PCI Framework driver support. pci: pci-sh7751: Add SH7751 PCI driver dt-bindings: pci: pci-sh7751: Add SH7751 PCI dt-bindings: clock: sh7750-cpg: Add renesas,sh7750-cpg header. clk: Compatible with narrow registers clk: renesas: Add SH7750/7751 CPG Driver irqchip: Add SH7751 INTC driver dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema irqchip: SH7751 external interrupt encoder with enable gate. dt-bindings: interrupt-controller: renesas,sh7751-irl-ext: Add json-schema serial: sh-sci: fix SH4 OF support. dt-bindings: serial: renesas,scif: Add scif-sh7751. dt-bindings: display: smi,sm501: SMI SM501 binding json-schema dt-bindings: display: sm501 register definition helper mfd: sm501: Convert platform_data to OF property dt-binding: sh: cpus: Add SH CPUs json-schema dt-bindings: vendor-prefixes: Add iodata dt-bindings: ata: ata-generic: Add new targets dt-bindings: soc: renesas: sh: Add SH7751 based target sh: SH7751R SoC Internal peripheral definition dtsi. sh: add RTS7751R2D Plus DTS sh: Add IO DATA LANDISK dts sh: Add IO DATA USL-5P dts sh: j2_mimas_v2.dts update sh: Add dtbs target support. sh: RTS7751R2D Plus OF defconfig sh: LANDISK OF defconfig sh: j2_defconfig: update .../devicetree/bindings/ata/ata-generic.yaml | 2 + .../bindings/clock/renesas,sh7750-cpg.yaml | 105 ++++ .../bindings/display/smi,sm501.yaml | 398 +++++++++++++++ .../renesas,sh7751-intc.yaml | 53 ++ .../renesas,sh7751-irl-ext.yaml | 57 +++ .../bindings/pci/renesas,sh7751-pci.yaml | 89 ++++ .../bindings/serial/renesas,scif.yaml | 1 + .../devicetree/bindings/sh/cpus.yaml | 63 +++ .../devicetree/bindings/soc/renesas/sh.yaml | 27 + .../bindings/timer/renesas,tmu.yaml | 2 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/sh/Kconfig | 33 +- arch/sh/boards/Kconfig | 23 +- arch/sh/boards/of-generic.c | 28 +- arch/sh/boot/compressed/head_32.S | 5 +- arch/sh/boot/dts/Makefile | 5 + arch/sh/boot/dts/j2_mimas_v2.dts | 2 +- arch/sh/boot/dts/landisk.dts | 77 +++ arch/sh/boot/dts/rts7751r2dplus.dts | 169 ++++++ arch/sh/boot/dts/sh7751r.dtsi | 105 ++++ arch/sh/boot/dts/usl-5p.dts | 85 ++++ arch/sh/configs/j2_defconfig | 11 +- arch/sh/configs/landisk-of_defconfig | 104 ++++ arch/sh/configs/rts7751r2dplus-of_defconfig | 75 +++ arch/sh/drivers/Makefile | 2 + arch/sh/include/asm/io.h | 8 + arch/sh/include/asm/irq.h | 10 +- arch/sh/include/asm/pci.h | 4 + arch/sh/include/asm/setup.h | 1 + arch/sh/kernel/cpu/Makefile | 6 +- arch/sh/kernel/cpu/irq/imask.c | 17 + arch/sh/kernel/cpu/sh4/Makefile | 3 + arch/sh/kernel/iomap.c | 18 + arch/sh/kernel/setup.c | 36 +- arch/sh/kernel/time.c | 12 + drivers/clk/clk-divider.c | 56 +- drivers/clk/clk-gate.c | 62 ++- drivers/clk/renesas/Kconfig | 13 +- drivers/clk/renesas/Makefile | 1 + drivers/clk/renesas/clk-sh7750.c | 480 ++++++++++++++++++ drivers/clocksource/sh_tmu.c | 198 +++++--- drivers/irqchip/Kconfig | 15 + drivers/irqchip/Makefile | 3 + drivers/irqchip/irq-renesas-sh7751.c | 282 ++++++++++ drivers/irqchip/irq-renesas-sh7751irl.c | 221 ++++++++ drivers/mfd/sm501.c | 315 ++++++++++++ drivers/pci/controller/Kconfig | 9 + drivers/pci/controller/Makefile | 1 + drivers/pci/controller/pci-sh7751.c | 342 +++++++++++++ drivers/tty/serial/Kconfig | 2 +- drivers/tty/serial/sh-sci.c | 6 +- drivers/video/fbdev/sm501fb.c | 106 ++++ include/dt-bindings/clock/sh7750-cpg.h | 26 + include/dt-bindings/display/sm501.h | 76 +++ .../renesas,sh7751-intc.h | 19 + include/linux/clk-provider.h | 22 +- include/linux/sh_intc.h | 7 +- 57 files changed, 3713 insertions(+), 187 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/renesas,sh7750-cpg.yaml create mode 100644 Documentation/devicetree/bindings/display/smi,sm501.yaml create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-irl-ext.yaml create mode 100644 Documentation/devicetree/bindings/pci/renesas,sh7751-pci.yaml create mode 100644 Documentation/devicetree/bindings/sh/cpus.yaml create mode 100644 Documentation/devicetree/bindings/soc/renesas/sh.yaml create mode 100644 arch/sh/boot/dts/landisk.dts create mode 100644 arch/sh/boot/dts/rts7751r2dplus.dts create mode 100644 arch/sh/boot/dts/sh7751r.dtsi create mode 100644 arch/sh/boot/dts/usl-5p.dts create mode 100644 arch/sh/configs/landisk-of_defconfig create mode 100644 arch/sh/configs/rts7751r2dplus-of_defconfig create mode 100644 drivers/clk/renesas/clk-sh7750.c create mode 100644 drivers/irqchip/irq-renesas-sh7751.c create mode 100644 drivers/irqchip/irq-renesas-sh7751irl.c create mode 100644 drivers/pci/controller/pci-sh7751.c create mode 100644 include/dt-bindings/clock/sh7750-cpg.h create mode 100644 include/dt-bindings/display/sm501.h create mode 100644 include/dt-bindings/interrupt-controller/renesas,sh7751-intc.h