diff mbox series

[v1,2/2] ACPI: LPSS: Advertise number of chip selects via property

Message ID 20240402152952.3578659-3-andriy.shevchenko@linux.intel.com (mailing list archive)
State Superseded, archived
Headers show
Series ACPI: LPSS: Prepare for SPI code cleanup | expand

Commit Message

Andy Shevchenko April 2, 2024, 3:28 p.m. UTC 
Advertise number of chip selects via property for Intel Braswell.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/acpi/acpi_lpss.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rafael J. Wysocki April 4, 2024, 10:58 a.m. UTC | #1 
On Tue, Apr 2, 2024 at 5:30 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Advertise number of chip selects via property for Intel Braswell.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

A Fixes: tag, please?

Also, IIUC this should be applied before
https://lore.kernel.org/linux-acpi/20240403170302.1073841-1-andriy.shevchenko@linux.intel.com/
?

> ---
>  drivers/acpi/acpi_lpss.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index 5b56f198d005..a3d2d94be5c0 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -325,6 +325,7 @@ static const struct lpss_device_desc bsw_i2c_dev_desc = {
>
>  static const struct property_entry bsw_spi_properties[] = {
>         PROPERTY_ENTRY_U32("intel,spi-pxa2xx-type", LPSS_BSW_SSP),
> +       PROPERTY_ENTRY_U32("num-cs", 2),
>         { }
>  };
>
> --
> 2.43.0.rc1.1.gbec44491f096
>
Andy Shevchenko April 4, 2024, 11:57 a.m. UTC | #2 
On Thu, Apr 04, 2024 at 12:58:29PM +0200, Rafael J. Wysocki wrote:
> On Tue, Apr 2, 2024 at 5:30 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Advertise number of chip selects via property for Intel Braswell.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> A Fixes: tag, please?

Sure.

> Also, IIUC this should be applied before
> https://lore.kernel.org/linux-acpi/20240403170302.1073841-1-andriy.shevchenko@linux.intel.com/
> ?

I believe yes for the sake of simplicity in maintaining / backporting
(if needed).
diff mbox series

Patch

diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 5b56f198d005..a3d2d94be5c0 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -325,6 +325,7 @@  static const struct lpss_device_desc bsw_i2c_dev_desc = {
 
 static const struct property_entry bsw_spi_properties[] = {
 	PROPERTY_ENTRY_U32("intel,spi-pxa2xx-type", LPSS_BSW_SSP),
+	PROPERTY_ENTRY_U32("num-cs", 2),
 	{ }
 };