| Message ID | 20240130-wcn3990-board-fw-v1-0-738f7c19a8c8@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | wifi: ath10k: fix board file loading for wcn3990 devices | expand |
On 1/29/2024 10:47 PM, Dmitry Baryshkov wrote: > The ath10k driver fails to properly handle fallback from board-2.bin to > board.bin for WCN3990 cards. This happens because the > ath10k_hw_params_list doesn't include .fw.board* parameters for the > WCN3990 platform. > > Add board data configuration for WCN3990. While we are at it, merge > common pieces of BDF support: drop .board and .eboard names from struct > ath10k_hw_params_fw and use the common name instead. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Dmitry Baryshkov (3): > wifi: ath10k: populate board data for WCN3990 > wifi: ath10k: drop chip-specific board data file name > wifi: ath10k: drop fw.eboard file name > > drivers/net/wireless/ath/ath10k/core.c | 32 ++++------------------------- > drivers/net/wireless/ath/ath10k/hw.h | 14 ++----------- > drivers/net/wireless/ath/ath10k/pci.c | 10 ++++----- > drivers/net/wireless/ath/ath10k/targaddrs.h | 3 +++ > 4 files changed, 14 insertions(+), 45 deletions(-) > --- > base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 > change-id: 20240129-wcn3990-board-fw-a2d97507a712 > > Best regards, This series looks OK to me, but would like Kalle to review as well
On Tue, 30 Jan 2024 at 08:47, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > The ath10k driver fails to properly handle fallback from board-2.bin to > board.bin for WCN3990 cards. This happens because the > ath10k_hw_params_list doesn't include .fw.board* parameters for the > WCN3990 platform. > > Add board data configuration for WCN3990. While we are at it, merge > common pieces of BDF support: drop .board and .eboard names from struct > ath10k_hw_params_fw and use the common name instead. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Dmitry Baryshkov (3): > wifi: ath10k: populate board data for WCN3990 > wifi: ath10k: drop chip-specific board data file name > wifi: ath10k: drop fw.eboard file name > > drivers/net/wireless/ath/ath10k/core.c | 32 ++++------------------------- > drivers/net/wireless/ath/ath10k/hw.h | 14 ++----------- > drivers/net/wireless/ath/ath10k/pci.c | 10 ++++----- > drivers/net/wireless/ath/ath10k/targaddrs.h | 3 +++ > 4 files changed, 14 insertions(+), 45 deletions(-) > --- > base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 > change-id: 20240129-wcn3990-board-fw-a2d97507a712 Kalle, Jeff, is there anything pending on me on this series?
On 3/29/2024 9:48 PM, Dmitry Baryshkov wrote: > On Tue, 30 Jan 2024 at 08:47, Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: >> >> The ath10k driver fails to properly handle fallback from board-2.bin to >> board.bin for WCN3990 cards. This happens because the >> ath10k_hw_params_list doesn't include .fw.board* parameters for the >> WCN3990 platform. >> >> Add board data configuration for WCN3990. While we are at it, merge >> common pieces of BDF support: drop .board and .eboard names from struct >> ath10k_hw_params_fw and use the common name instead. >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- >> Dmitry Baryshkov (3): >> wifi: ath10k: populate board data for WCN3990 >> wifi: ath10k: drop chip-specific board data file name >> wifi: ath10k: drop fw.eboard file name >> >> drivers/net/wireless/ath/ath10k/core.c | 32 ++++------------------------- >> drivers/net/wireless/ath/ath10k/hw.h | 14 ++----------- >> drivers/net/wireless/ath/ath10k/pci.c | 10 ++++----- >> drivers/net/wireless/ath/ath10k/targaddrs.h | 3 +++ >> 4 files changed, 14 insertions(+), 45 deletions(-) >> --- >> base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 >> change-id: 20240129-wcn3990-board-fw-a2d97507a712 > > Kalle, Jeff, is there anything pending on me on this series? > Nothing from me -- this is outside my area of expertise so I'm deferring to Kalle. Kalle?
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes: > On Tue, 30 Jan 2024 at 08:47, Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > >> >> The ath10k driver fails to properly handle fallback from board-2.bin to >> board.bin for WCN3990 cards. This happens because the >> ath10k_hw_params_list doesn't include .fw.board* parameters for the >> WCN3990 platform. >> >> Add board data configuration for WCN3990. While we are at it, merge >> common pieces of BDF support: drop .board and .eboard names from struct >> ath10k_hw_params_fw and use the common name instead. >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- >> Dmitry Baryshkov (3): >> wifi: ath10k: populate board data for WCN3990 >> wifi: ath10k: drop chip-specific board data file name >> wifi: ath10k: drop fw.eboard file name >> >> drivers/net/wireless/ath/ath10k/core.c | 32 ++++------------------------- >> drivers/net/wireless/ath/ath10k/hw.h | 14 ++----------- >> drivers/net/wireless/ath/ath10k/pci.c | 10 ++++----- >> drivers/net/wireless/ath/ath10k/targaddrs.h | 3 +++ >> 4 files changed, 14 insertions(+), 45 deletions(-) >> --- >> base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 >> change-id: 20240129-wcn3990-board-fw-a2d97507a712 > > Kalle, Jeff, is there anything pending on me on this series? This is in my queue (Deferred state): https://patchwork.kernel.org/project/linux-wireless/list/?series=821157&state=*&order=date Unfortunately there is not really much time for ath10k nowadays so there will be delays.
On Fri, 5 Apr 2024 at 14:57, Kalle Valo <kvalo@kernel.org> wrote: > > Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes: > > > On Tue, 30 Jan 2024 at 08:47, Dmitry Baryshkov > > <dmitry.baryshkov@linaro.org> wrote: > > > >> > >> The ath10k driver fails to properly handle fallback from board-2.bin to > >> board.bin for WCN3990 cards. This happens because the > >> ath10k_hw_params_list doesn't include .fw.board* parameters for the > >> WCN3990 platform. > >> > >> Add board data configuration for WCN3990. While we are at it, merge > >> common pieces of BDF support: drop .board and .eboard names from struct > >> ath10k_hw_params_fw and use the common name instead. > >> > >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >> --- > >> Dmitry Baryshkov (3): > >> wifi: ath10k: populate board data for WCN3990 > >> wifi: ath10k: drop chip-specific board data file name > >> wifi: ath10k: drop fw.eboard file name > >> > >> drivers/net/wireless/ath/ath10k/core.c | 32 ++++------------------------- > >> drivers/net/wireless/ath/ath10k/hw.h | 14 ++----------- > >> drivers/net/wireless/ath/ath10k/pci.c | 10 ++++----- > >> drivers/net/wireless/ath/ath10k/targaddrs.h | 3 +++ > >> 4 files changed, 14 insertions(+), 45 deletions(-) > >> --- > >> base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 > >> change-id: 20240129-wcn3990-board-fw-a2d97507a712 > > > > Kalle, Jeff, is there anything pending on me on this series? > > This is in my queue (Deferred state): > > https://patchwork.kernel.org/project/linux-wireless/list/?series=821157&state=*&order=date > > Unfortunately there is not really much time for ath10k nowadays so there > will be delays. No problems, each maintainer treats PW states slightly differently, so I was trying to understand if there is anything left on my side.
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes: > On Fri, 5 Apr 2024 at 14:57, Kalle Valo <kvalo@kernel.org> wrote: > >> >> Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes: >> >> > On Tue, 30 Jan 2024 at 08:47, Dmitry Baryshkov >> > <dmitry.baryshkov@linaro.org> wrote: >> > >> >> >> >> The ath10k driver fails to properly handle fallback from board-2.bin to >> >> board.bin for WCN3990 cards. This happens because the >> >> ath10k_hw_params_list doesn't include .fw.board* parameters for the >> >> WCN3990 platform. >> >> >> >> Add board data configuration for WCN3990. While we are at it, merge >> >> common pieces of BDF support: drop .board and .eboard names from struct >> >> ath10k_hw_params_fw and use the common name instead. >> >> >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> >> --- >> >> Dmitry Baryshkov (3): >> >> wifi: ath10k: populate board data for WCN3990 >> >> wifi: ath10k: drop chip-specific board data file name >> >> wifi: ath10k: drop fw.eboard file name >> >> >> >> drivers/net/wireless/ath/ath10k/core.c | 32 ++++------------------------- >> >> drivers/net/wireless/ath/ath10k/hw.h | 14 ++----------- >> >> drivers/net/wireless/ath/ath10k/pci.c | 10 ++++----- >> >> drivers/net/wireless/ath/ath10k/targaddrs.h | 3 +++ >> >> 4 files changed, 14 insertions(+), 45 deletions(-) >> >> --- >> >> base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 >> >> change-id: 20240129-wcn3990-board-fw-a2d97507a712 >> > >> > Kalle, Jeff, is there anything pending on me on this series? >> >> This is in my queue (Deferred state): >> >> https://patchwork.kernel.org/project/linux-wireless/list/?series=821157&state=*&order=date >> >> Unfortunately there is not really much time for ath10k nowadays so there >> will be delays. > > No problems, each maintainer treats PW states slightly differently, so > I was trying to understand if there is anything left on my side. That's true. I have tried to document how we in wireless use patchwork here: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork Though I guess I'm the only one using Deferred state.
On Fri, 5 Apr 2024 at 14:57, Kalle Valo <kvalo@kernel.org> wrote: > > Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes: > > > On Tue, 30 Jan 2024 at 08:47, Dmitry Baryshkov > > <dmitry.baryshkov@linaro.org> wrote: > > > >> > >> The ath10k driver fails to properly handle fallback from board-2.bin to > >> board.bin for WCN3990 cards. This happens because the > >> ath10k_hw_params_list doesn't include .fw.board* parameters for the > >> WCN3990 platform. > >> > >> Add board data configuration for WCN3990. While we are at it, merge > >> common pieces of BDF support: drop .board and .eboard names from struct > >> ath10k_hw_params_fw and use the common name instead. > >> > >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >> --- > >> Dmitry Baryshkov (3): > >> wifi: ath10k: populate board data for WCN3990 > >> wifi: ath10k: drop chip-specific board data file name > >> wifi: ath10k: drop fw.eboard file name > >> > >> drivers/net/wireless/ath/ath10k/core.c | 32 ++++------------------------- > >> drivers/net/wireless/ath/ath10k/hw.h | 14 ++----------- > >> drivers/net/wireless/ath/ath10k/pci.c | 10 ++++----- > >> drivers/net/wireless/ath/ath10k/targaddrs.h | 3 +++ > >> 4 files changed, 14 insertions(+), 45 deletions(-) > >> --- > >> base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 > >> change-id: 20240129-wcn3990-board-fw-a2d97507a712 > > > > Kalle, Jeff, is there anything pending on me on this series? > > This is in my queue (Deferred state): > > https://patchwork.kernel.org/project/linux-wireless/list/?series=821157&state=*&order=date > > Unfortunately there is not really much time for ath10k nowadays so there > will be delays. > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches Please excuse me, can we get at least patch 1? It fixes an actual issue with WCN3990 which prevents us from testing board data files (or adding new boards) without fixing board-2.bin first. The driver ignores board.bin even if it is present on rootfs.
The ath10k driver fails to properly handle fallback from board-2.bin to board.bin for WCN3990 cards. This happens because the ath10k_hw_params_list doesn't include .fw.board* parameters for the WCN3990 platform. Add board data configuration for WCN3990. While we are at it, merge common pieces of BDF support: drop .board and .eboard names from struct ath10k_hw_params_fw and use the common name instead. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Dmitry Baryshkov (3): wifi: ath10k: populate board data for WCN3990 wifi: ath10k: drop chip-specific board data file name wifi: ath10k: drop fw.eboard file name drivers/net/wireless/ath/ath10k/core.c | 32 ++++------------------------- drivers/net/wireless/ath/ath10k/hw.h | 14 ++----------- drivers/net/wireless/ath/ath10k/pci.c | 10 ++++----- drivers/net/wireless/ath/ath10k/targaddrs.h | 3 +++ 4 files changed, 14 insertions(+), 45 deletions(-) --- base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 change-id: 20240129-wcn3990-board-fw-a2d97507a712 Best regards,