| Message ID | 20240407-samsung-galaxy-zfold5-q5q-v4-1-8b67b1813653@yahoo.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Samsung Galaxy Z Fold5 initial support | expand |
On 07/04/2024 07:38, Alexandru Marc Serdeliuc via B4 Relay wrote: > From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > > This documents Samsung Galaxy Z Fold5 (samsung,q5q) > which is a foldable phone by Samsung based on the sm8550 SoC. > > Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > --- This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
I am terribly sorry, this is my first patch sent here, I am still trying to understand what and how to do it. How to proceed with those missing tags? i should create a v5 and add them? On 7/4/24 11:01, Krzysztof Kozlowski wrote: > On 07/04/2024 07:38, Alexandru Marc Serdeliuc via B4 Relay wrote: >> From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> >> >> This documents Samsung Galaxy Z Fold5 (samsung,q5q) >> which is a foldable phone by Samsung based on the sm8550 SoC. >> >> Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> >> --- > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > > Best regards, > Krzysztof >
On 07/04/2024 11:21, Alexandru Serdeliuc wrote: > I am terribly sorry, this is my first patch sent here, I am still > trying to understand what and how to do it. > > How to proceed with those missing tags? i should create a v5 and add them? > You need to add them. Please read the document I linked. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 66beaac60e1d..dea2a23b8fc2 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -1003,6 +1003,7 @@ properties: - qcom,sm8550-hdk - qcom,sm8550-mtp - qcom,sm8550-qrd + - samsung,q5q - const: qcom,sm8550 - items: